fix(view): commit 중복 bug fix #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
reviewed
Oct 6, 2023
| @@ -13,9 +13,9 @@ const useToggleHook = (init = false): UseToggleHook => { | |||
|
|
|||
| export const useCommitListHide = (commitNodeListInCluster: CommitNode[]) => { | |||
| const list = getSummaryCommitList(commitNodeListInCluster).reverse(); | |||
| const strech = commitNodeListInCluster.slice(5, commitNodeListInCluster.length).reverse(); | |||
| const strech = commitNodeListInCluster.reverse(); | |||
There was a problem hiding this comment.
아니요, 기존의 동작과 동일하게 작동합니다!
처음에 5개가 나온 후, readmore을 누르면 전체 commit 이 나오고 hide를 누르면 5개가 보여지는 처음의 상태로 돌아갑니다.
There was a problem hiding this comment.
5개 단위로 접혀서 나오도록 수정해보겠습니다!
ytaek
approved these changes
Oct 6, 2023
inthejim
commented
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#507
Result
전:
후:
Discussion
서브 그래프와 순서가 반대라, 헷갈릴 수 있을 것 같습니다.