Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle variadic functions #104

Open
kalexmills opened this issue Dec 26, 2020 · 2 comments
Open

Handle variadic functions #104

kalexmills opened this issue Dec 26, 2020 · 2 comments
Labels
bug Something isn't working false-positive the issue can create a false-positive vet-bot the issue is part of VetBot's responsibility
Milestone
Beta

Comments

@kalexmills
Copy link
Contributor

kalexmills commented Dec 26, 2020 •
edited
Loading

Right now, nothing is done in the callgraph (and therefore any of the analyzers) to consider variadic functions. This is a potential source of false-negatives.

EDIT: actually they may erroneously be reported as third-party functions when they shouldn't be. Changing the labels.
@kalexmills kalexmills added bug Something isn't working vet-bot the issue is part of VetBot's responsibility false-negative the issue can create a false-negative labels Dec 26, 2020
@kalexmills kalexmills changed the title Does not handle variadic functions Handle variadic functions Dec 26, 2020
@kalexmills kalexmills added this to the General Availability milestone Dec 26, 2020
@kalexmills kalexmills mentioned this issue Dec 26, 2020
Open
@kalexmills
Copy link
Contributor Author

Can also cause false-positives in #109

@kalexmills kalexmills added false-positive the issue can create a false-positive false-negative the issue can create a false-negative and removed false-negative the issue can create a false-negative labels Dec 26, 2020
@kalexmills
Copy link
Contributor Author

kalexmills commented Dec 28, 2020 •
edited
Loading

I'm not okay with allowing the tool to misreport variadic functions. We can tag when a signature has a declaration with variadic arguments and include that suspicion in case we suspect it may be involved as a "third-party" function.

Also the "third-party" message should be rewritten to say "function whose declaration could not be tracked".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working false-positive the issue can create a false-positive vet-bot the issue is part of VetBot's responsibility
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
1 participant
@kalexmills