Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track anonymous functions #127

Open
kalexmills opened this issue Dec 28, 2020 · 0 comments
Open

Track anonymous functions #127

kalexmills opened this issue Dec 28, 2020 · 0 comments
Labels
discussion Maintainers are inviting discussion. enhancement New feature or request false-positive the issue can create a false-positive vet-bot the issue is part of VetBot's responsibility

Comments

@kalexmills
Copy link
Contributor

There are a few cases where anonymous functions are used in reported findings. The current tool misreports them either as third-party, or, if their signature matches a declared function, yields a false-positive.

In theory, these could be tracked, if the anonymous function being used appears as an argument in a function declaration. That would allow us to match up the function signatures and consider each anonymous function declared in the codebase with a matching signature as a candidate "declaration". We could then trace any calls found whose signature matches the argument with the candidate declarations.

This probably won't be implemented as it's a substantial change, but it's a possibility in case we find a lot of reports that could use it.

@kalexmills kalexmills added enhancement New feature or request false-positive the issue can create a false-positive vet-bot the issue is part of VetBot's responsibility discussion Maintainers are inviting discussion. labels Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Maintainers are inviting discussion. enhancement New feature or request false-positive the issue can create a false-positive vet-bot the issue is part of VetBot's responsibility
Projects
None yet
Development

No branches or pull requests

1 participant