Merge pull request #9 from github/jibrang/fix-prototype-polluting-assignment

jibrang · web-flow · commit 3f17eb13c20b · 2024-08-30T10:10:46.000-07:00
Fix prototype polluting assignment
diff --git a/target/braintree-1.3.10.js b/target/braintree-1.3.10.js
@@ -2366,8 +2366,12 @@ sjcl.random = {
       }
     }
 
+    const forbiddenKeys = ['__proto__', 'constructor', 'prototype'];
     for (i=0; i<jsTemp.length; i++) {
       j = jsTemp[i];
+      if (forbiddenKeys.includes(j)) {
+        continue;
+      }
       delete cbs[j];
     }
   },

Original file line number	Diff line number	Diff line change
`@@ -2366,8 +2366,12 @@ sjcl.random = {`
`2366`	`2366`	`}`
`2367`	`2367`	`}`
`2368`	`2368`
	`2369`	`+ const forbiddenKeys = ['__proto__', 'constructor', 'prototype'];`
`2369`	`2370`	`for (i=0; i<jsTemp.length; i++) {`
`2370`	`2371`	`j = jsTemp[i];`
	`2372`	`+ if (forbiddenKeys.includes(j)) {`
	`2373`	`+ continue;`
	`2374`	`+ }`
`2371`	`2375`	`delete cbs[j];`
`2372`	`2376`	`}`
`2373`	`2377`	`},`