Skip to content

Commit 37c13cf

Browse files
committed
fix MISSING message
1 parent 147e619 commit 37c13cf

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

__tests__/functions/prechecks.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ test('runs prechecks and finds that the IssueOps command is valid for a branch d
459459

460460
expect(await prechecks(context, octokit, data)).toStrictEqual({
461461
message:
462-
'The `checks` input option requires that all of the following checks are passing: `test,acceptance-test,quality-control,lint`. However, the following checks are missing: `quality-control`',
462+
'### ⚠️ Cannot proceed with deployment\n\n- reviewDecision: `APPROVED`\n- commitStatus: `MISSING`\n\n> The `checks` input option requires that all of the following checks are passing: `test,acceptance-test,quality-control,lint`. However, the following checks are missing: `quality-control`',
463463
status: false
464464
})
465465

dist/index.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/functions/prechecks.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,8 +660,8 @@ export async function prechecks(context, octokit, data) {
660660
// Regardless of the reviewDecision or noop, if the commitStatus is 'MISSING' this means that a user has explicitly requested a CI check to be passing with the `checks: <check1>,<check2>,<etc>` input option, but the check could not be found in the GraphQL result
661661
// In this case, we should alert the user that the check could not be found and exit
662662
} else if (commitStatus === 'MISSING') {
663-
message = `### ⚠️ Cannot proceed with deployment\n\n- reviewDecision: \`${reviewDecision}\`\n- commitStatus: \`${commitStatus}\`\n\n> CI checks must be passing in order to continue`
664-
return {message: filterChecksResults.message, status: false}
663+
message = `### ⚠️ Cannot proceed with deployment\n\n- reviewDecision: \`${reviewDecision}\`\n- commitStatus: \`${commitStatus}\`\n\n> ${filterChecksResults.message}`
664+
return {message: message, status: false}
665665

666666
// If CI is passing but the PR is missing an approval, let the user know
667667
} else if (

0 commit comments

Comments
 (0)