Swap order of equality for easier comprehension

owen-mc · owen-mc · commit 0dc47380a3c6 · 2026-01-14T11:50:53.000Z
diff --git a/go/ql/lib/semmle/go/security/Xss.qll b/go/ql/lib/semmle/go/security/Xss.qll
@@ -143,10 +143,10 @@ module SharedXss {
     HtmlTemplateSanitizer() {
       exists(Method m, DataFlow::CallNode call | m = call.getCall().getTarget() |
         m.hasQualifiedName("html/template", "Template", "ExecuteTemplate") and
-        call.getArgument(2) = this
+        this = call.getArgument(2)
         or
         m.hasQualifiedName("html/template", "Template", "Execute") and
-        call.getArgument(1) = this
+        this = call.getArgument(1)
       )
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -143,10 +143,10 @@ module SharedXss {`
`143`	`143`	`HtmlTemplateSanitizer() {`
`144`	`144`	`exists(Method m, DataFlow::CallNode call \| m = call.getCall().getTarget() \|`
`145`	`145`	`m.hasQualifiedName("html/template", "Template", "ExecuteTemplate") and`
`146`		`- call.getArgument(2) = this`
	`146`	`+ this = call.getArgument(2)`
`147`	`147`	`or`
`148`	`148`	`m.hasQualifiedName("html/template", "Template", "Execute") and`
`149`		`- call.getArgument(1) = this`
	`149`	`+ this = call.getArgument(1)`
`150`	`150`	`)`
`151`	`151`	`}`
`152`	`152`	`}`