More feedback

Author: SteveSandersonMS

dotnet/src/Generated/Rpc.cs

@@ -188,7 +188,7 @@ public class AccountGetQuotaResult
     public Dictionary<string, AccountGetQuotaResultQuotaSnapshotsValue> QuotaSnapshots { get; set; } = new();
 }
 
-public class ModelGetCurrentResult
+public class SessionModelGetCurrentResult
 {
     [JsonPropertyName("modelId")]
     public string? ModelId { get; set; }
@@ -200,7 +200,7 @@ internal class GetCurrentRequest
     public string SessionId { get; set; } = string.Empty;
 }
 
-public class ModelSwitchToResult
+public class SessionModelSwitchToResult
 {
     [JsonPropertyName("modelId")]
     public string? ModelId { get; set; }
@@ -325,16 +325,16 @@ internal ModelApi(JsonRpc rpc, string sessionId)
     }
 
     /// <summary>Calls "session.model.getCurrent".</summary>
-    public async Task<ModelGetCurrentResult> GetCurrentAsync(CancellationToken cancellationToken = default)
+    public async Task<SessionModelGetCurrentResult> GetCurrentAsync(CancellationToken cancellationToken = default)
     {
         var request = new GetCurrentRequest { SessionId = _sessionId };
-        return await CopilotClient.InvokeRpcAsync<ModelGetCurrentResult>(_rpc, "session.model.getCurrent", [request], cancellationToken);
+        return await CopilotClient.InvokeRpcAsync<SessionModelGetCurrentResult>(_rpc, "session.model.getCurrent", [request], cancellationToken);
     }
 
     /// <summary>Calls "session.model.switchTo".</summary>
-    public async Task<ModelSwitchToResult> SwitchToAsync(string modelId, CancellationToken cancellationToken = default)
+    public async Task<SessionModelSwitchToResult> SwitchToAsync(string modelId, CancellationToken cancellationToken = default)
     {
         var request = new SwitchToRequest { SessionId = _sessionId, ModelId = modelId };
-        return await CopilotClient.InvokeRpcAsync<ModelSwitchToResult>(_rpc, "session.model.switchTo", [request], cancellationToken);
+        return await CopilotClient.InvokeRpcAsync<SessionModelSwitchToResult>(_rpc, "session.model.switchTo", [request], cancellationToken);
     }
 }

scripts/codegen/csharp.ts

@@ -662,7 +662,7 @@ function emitSessionApiClass(className: string, node: Record<string, unknown>, c
         if (!isRpcMethod(value)) continue;
         const method = value;
         const methodName = toPascalCase(key);
-        const resultClassName = `${typeToClassName(method.rpcMethod.replace(/^session\./, ""))}Result`;
+        const resultClassName = `${typeToClassName(method.rpcMethod)}Result`;
         const resultClass = emitRpcClass(resultClassName, method.result, "public", classes);
         if (resultClass) classes.push(resultClass);