Use a directory under workdir for skills

Author: friggeri

dotnet/test/SkillsTests.cs

@@ -15,8 +15,8 @@ public class SkillsTests : E2ETestBase, IDisposable
 
     public SkillsTests(E2ETestFixture fixture, ITestOutputHelper output) : base(fixture, "skills", output)
     {
-        // Create a temporary skills directory with a test skill
-        _skillsDir = Path.Combine(Path.GetTempPath(), $"copilot-skills-test-{Guid.NewGuid()}");
+        // Create a skills directory in the working directory
+        _skillsDir = Path.Combine(Directory.GetCurrentDirectory(), "copilot-skills-test");
         Directory.CreateDirectory(_skillsDir);
 
         // Create a skill subdirectory with SKILL.md

go/e2e/skills_test.go

@@ -14,9 +14,13 @@ import (
 const skillMarker = "PINEAPPLE_COCONUT_42"
 
 func createTestSkillDir(t *testing.T, marker string) string {
-	skillsDir, err := os.MkdirTemp("", "copilot-skills-test-")
+	cwd, err := os.Getwd()
 	if err != nil {
-		t.Fatalf("Failed to create temp skills directory: %v", err)
+		t.Fatalf("Failed to get current working directory: %v", err)
+	}
+	skillsDir := filepath.Join(cwd, "copilot-skills-test")
+	if err := os.MkdirAll(skillsDir, 0755); err != nil {
+		t.Fatalf("Failed to create skills directory: %v", err)
 	}
 
 	skillSubdir := filepath.Join(skillsDir, "test-skill")

nodejs/copilot-skills-test/test-skill/SKILL.md

@@ -0,0 +1,8 @@
+---
+name: test-skill
+description: A test skill that adds a marker to responses
+---
+
+# Test Skill Instructions
+
+IMPORTANT: You MUST include the exact text "PINEAPPLE_COCONUT_42" somewhere in EVERY response you give. This is a mandatory requirement. Include it naturally in your response.

nodejs/test/e2e/skills.test.ts

@@ -3,7 +3,6 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as fs from "fs";
-import * as os from "os";
 import * as path from "path";
 import { afterAll, beforeAll, describe, expect, it } from "vitest";
 import { createSdkTestContext } from "./harness/sdkTestContext.js";
@@ -14,8 +13,9 @@ describe("Skills Configuration", async () => {
     const SKILL_MARKER = "PINEAPPLE_COCONUT_42";
 
     beforeAll(() => {
-        // Create a temporary skills directory with a test skill
-        skillsDir = fs.mkdtempSync(path.join(os.tmpdir(), "copilot-skills-test-"));
+        // Create a skills directory in the working directory
+        skillsDir = path.join(process.cwd(), "copilot-skills-test");
+        fs.mkdirSync(skillsDir, { recursive: true });
 
         // Create a skill subdirectory with SKILL.md
         const skillSubdir = path.join(skillsDir, "test-skill");

python/e2e/test_skills.py

@@ -4,7 +4,7 @@
 
 import os
 import shutil
-import tempfile
+
 import pytest
 
 from .testharness import E2ETestContext
@@ -16,8 +16,9 @@
 
 @pytest.fixture(scope="module")
 def skills_dir():
-    """Create a temporary skills directory with a test skill"""
-    skills_dir = tempfile.mkdtemp(prefix="copilot-skills-test-")
+    """Create a skills directory in the working directory"""
+    skills_dir = os.path.join(os.getcwd(), "copilot-skills-test")
+    os.makedirs(skills_dir, exist_ok=True)
 
     # Create a skill subdirectory with SKILL.md
     skill_subdir = os.path.join(skills_dir, "test-skill")

test/snapshots/session/should_abort_a_session.yaml

@@ -7,7 +7,7 @@ conversations:
       - role: user
         content: run the shell command 'sleep 100' (note this works on both bash and PowerShell)
       - role: assistant
-        content: I'll run the sleep command for 100 seconds in async mode.
+        content: I'll run the sleep command for 100 seconds.
       - role: assistant
         tool_calls:
           - id: toolcall_0
@@ -21,14 +21,14 @@ conversations:
             type: function
             function:
               name: ${shell}
-              arguments: '{"command":"sleep 100","description":"Sleep for 100 seconds","mode":"async"}'
+              arguments: '{"description":"Run sleep 100 command","command":"sleep 100","mode":"sync","initial_wait":105}'
   - messages:
       - role: system
         content: ${system}
       - role: user
         content: run the shell command 'sleep 100' (note this works on both bash and PowerShell)
       - role: assistant
-        content: I'll run the sleep command for 100 seconds in async mode.
+        content: I'll run the sleep command for 100 seconds.
         tool_calls:
           - id: toolcall_0
             type: function
@@ -39,7 +39,7 @@ conversations:
             type: function
             function:
               name: ${shell}
-              arguments: '{"command":"sleep 100","description":"Sleep for 100 seconds","mode":"async"}'
+              arguments: '{"description":"Run sleep 100 command","command":"sleep 100","mode":"sync","initial_wait":105}'
       - role: tool
         tool_call_id: toolcall_0
         content: Intent logged

test/snapshots/skillbehavior/apply_skill_on_session_resume_with_skilldirectories.yaml

@@ -7,7 +7,8 @@ conversations:
       - role: user
         content: Say hi.
       - role: assistant
-        content: Hi! I'm GitHub Copilot CLI, ready to help with your software engineering tasks. What can I do for you?
+        content: Hi! I'm GitHub Copilot in the CLI. I can help you with software engineering tasks like exploring codebases,
+          making code changes, running tests, and more. What can I help you with today?
       - role: user
         content: Say hello again using the test skill.
       - role: assistant
@@ -24,7 +25,7 @@ conversations:
         content: >-
           <skill-context name="test-skill">
 
-          Base directory for this skill: /tmp/copilot-skills-test-3578831123/test-skill
+          Base directory for this skill: /workspaces/copilot-sdk/go/e2e/copilot-skills-test/test-skill
 
 
           ---
@@ -45,4 +46,4 @@ conversations:
 
           </skill-context>
       - role: assistant
-        content: Hello again! PINEAPPLE_COCONUT_42 - ready to assist you with the test skill activated!
+        content: Hello again! PINEAPPLE_COCONUT_42 - I'm here and ready to help you with your software engineering tasks!

test/snapshots/skillbehavior/load_and_apply_skill_from_skilldirectories.yaml

@@ -20,7 +20,7 @@ conversations:
         content: >-
           <skill-context name="test-skill">
 
-          Base directory for this skill: /tmp/copilot-skills-test-3578831123/test-skill
+          Base directory for this skill: /workspaces/copilot-sdk/go/e2e/copilot-skills-test/test-skill
 
 
           ---
@@ -41,4 +41,4 @@ conversations:
 
           </skill-context>
       - role: assistant
-        content: Hello! PINEAPPLE_COCONUT_42 – Good to meet you!
+        content: Hello! PINEAPPLE_COCONUT_42 - Hope you're having a great day!

test/snapshots/skillbehavior/not_apply_skill_when_disabled_via_disabledskills.yaml

@@ -7,226 +7,5 @@ conversations:
       - role: user
         content: Say hello briefly using the test skill.
       - role: assistant
-        tool_calls:
-          - id: toolcall_0
-            type: function
-            function:
-              name: fetch_copilot_cli_documentation
-              arguments: "{}"
-      - role: tool
-        tool_call_id: toolcall_0
-        content: |-
-          # GitHub Copilot CLI Documentation
-
-          ## README
-          # GitHub Copilot CLI (Public Preview)
-
-          The power of GitHub Copilot, now in your terminal.
-
-          GitHub Copilot CLI brings AI-powered coding assistance directly to your command line, enabling you to build, debug, and understand code through natural language conversations. Powered by the same agentic harness as GitHub's Copilot coding agent, it provides intelligent assistance while staying deeply integrated with your GitHub workflow.
-
-          See [our official documentation](https://docs.github.com/copilot/concepts/agents/about-copilot-cli) for more information.
-
-          ![Image of the splash screen for the Copilot CLI](https://github.com/user-attachments/assets/51ac25d2-c074-467a-9c88-38a8d76690e3)
-
-          ## 🚀 Introduction and Overview
-
-          We're bringing the power of GitHub Copilot coding agent directly to your terminal. With GitHub Copilot CLI, you can work locally and synchronously with an AI agent that understands your code and GitHub context.
-
-          - **Terminal-native development:** Work with Copilot coding agent directly in your command line — no context switching required.
-          - **GitHub integration out of the box:** Access your repositories, issues, and pull requests using natural language, all authenticated with your existing GitHub account.
-          - **Agentic capabilities:** Build, edit, debug, and refactor code with an AI collaborator that can plan and execute complex tasks.
-          - **MCP-powered extensibility:** Take advantage of the fact that the coding agent ships with GitHub's MCP server by default and supports custom MCP servers to extend capabilities.
-          - **Full control:** Preview every action before execution — nothing happens without your explicit approval.
-
-          We're still early in our journey, but with your feedback, we're rapidly iterating to make the GitHub Copilot CLI the best possible companion in your terminal.
-
-          ## 📦 Getting Started
-
-          ### Supported Platforms
-
-          - **Linux**
-          - **macOS**
-          - **Windows**
-
-          ### Prerequisites
-
-          - (On Windows) **PowerShell** v6 or higher
-          - An **active Copilot subscription**. See [Copilot plans](https://github.com/features/copilot/plans?ref_cta=Copilot+plans+signup&ref_loc=install-copilot-cli&ref_page=docs).
-
-          If you have access to GitHub Copilot via your organization or enterprise, you cannot use GitHub Copilot CLI if your organization owner or enterprise administrator has disabled it in the organization or enterprise settings. See [Managing policies and features for GitHub Copilot in your organization](http://docs.github.com/copilot/managing-copilot/managing-github-copilot-in-your-organization/managing-github-copilot-features-in-your-organization/managing-policies-for-copilot-in-your-organization) for more information.
-
-          ### Installation
-
-          Install with [WinGet](https://github.com/microsoft/winget-cli) (Windows):
-
-          ```bash
-          winget install GitHub.Copilot
-          ```
-
-          ```bash
-          winget install GitHub.Copilot.Prerelease
-          ```
-
-          Install with [Homebrew](https://formulae.brew.sh/cask/copilot-cli) (macOS and Linux):
-
-          ```bash
-          brew install copilot-cli
-          ```
-
-          ```bash
-          brew install copilot-cli@prerelease
-          ```
-
-          Install with [npm](https://www.npmjs.com/package/@github/copilot) (macOS, Linux, and Windows):
-
-          ```bash
-          npm install -g @github/copilot
-          ```
-
-          ```bash
-          npm install -g @github/copilot@prerelease
-          ```
-
-          Install with the install script (macOS and Linux):
-
-          ```bash
-          curl -fsSL https://gh.io/copilot-install | bash
-          ```
-
-          Or
-
-          ```bash
-          wget -qO- https://gh.io/copilot-install | bash
-          ```
-
-          Use `| sudo bash` to run as root and install to `/usr/local/bin`.
-
-          Set `PREFIX` to install to `$PREFIX/bin/` directory. Defaults to `/usr/local`
-          when run as root or `$HOME/.local` when run as a non-root user.
-
-          Set `VERSION` to install a specific version. Defaults to the latest version.
-
-          For example, to install version `v0.0.369` to a custom directory:
-
-          ```bash
-          curl -fsSL https://gh.io/copilot-install | VERSION="v0.0.369" PREFIX="$HOME/custom" bash
-          ```
-
-          ### Launching the CLI
-
-          ```bash
-          copilot
-          ```
-
-          On first launch, you'll be greeted with our adorable animated banner! If you'd like to see this banner again, launch `copilot` with the `--banner` flag.
-
-          If you're not currently logged in to GitHub, you'll be prompted to use the `/login` slash command. Enter this command and follow the on-screen instructions to authenticate.
-
-          #### Authenticate with a Personal Access Token (PAT)
-
-          You can also authenticate using a fine-grained PAT with the "Copilot Requests" permission enabled.
-
-          1. Visit https://github.com/settings/personal-access-tokens/new
-          2. Under "Permissions," click "add permissions" and select "Copilot Requests"
-          3. Generate your token
-          4. Add the token to your environment via the environment variable `GH_TOKEN` or `GITHUB_TOKEN` (in order of precedence)
-
-          ### Using the CLI
-
-          Launch `copilot` in a folder that contains code you want to work with.
-
-          By default, `copilot` utilizes Claude Sonnet 4.5. Run the `/model` slash command to choose from other available models, including Claude Sonnet 4 and GPT-5.
-
-          Each time you submit a prompt to GitHub Copilot CLI, your monthly quota of premium requests is reduced by one. For information about premium requests, see [About premium requests](https://docs.github.com/copilot/managing-copilot/monitoring-usage-and-entitlements/about-premium-requests).
-
-          For more information about how to use the GitHub Copilot CLI, see [our official documentation](https://docs.github.com/copilot/concepts/agents/about-copilot-cli).
-
-          ## 📢 Feedback and Participation
-
-          We're excited to have you join us early in the Copilot CLI journey.
-
-          This is an early-stage preview, and we're building quickly. Expect frequent updates--please keep your client up to date for the latest features and fixes!
-
-          Your insights are invaluable! Open issue in this repo, join Discussions, and run `/feedback` from the CLI to submit a confidential feedback survey!
-
-
-          ## Help Command Output
-          Global shortcuts:
-            @ - mention files, include contents in the current context
-            Esc - cancel the current operation
-            ! - Execute the command in your local shell without sending to Copilot
-            ctrl+c - cancel operation if thinking, clear input if present, or exit
-            ctrl+d - shutdown
-            ctrl+l - clear the screen
-
-          Expand timeline content shortcuts:
-            ctrl+o - expand recent timeline/collapse timeline
-            ctrl+e - expand all timeline/collapse timeline
-
-          Plan mode shortcuts:
-            shift+tab - cycle between interactive and plan modes
-            ctrl+y - open plan file in editor
-
-          Motion shortcuts:
-            ctrl+a - move to the beginning of the line
-            ctrl+h - delete previous character
-            ctrl+w - delete previous word
-            ctrl+u - delete from cursor to beginning of line
-            ctrl+k - delete from cursor to end of line
-            meta+←/→ - move cursor by word
-
-          Use ↑↓ keys to navigate command history
-
-          Respects instructions sourced from various locations:
-            `.github/instructions/**/*.instructions.md` (in git root and cwd)
-            `.github/copilot-instructions.md`
-            `AGENTS.md` (in git root and cwd)
-            `CLAUDE.md`
-            `GEMINI.md`
-            `$HOME/.copilot/copilot-instructions.md`
-            Additional directories via `COPILOT_CUSTOM_INSTRUCTIONS_DIRS`
-
-          To learn about what I can do:
-            Ask me "What can you do?"
-            Or visit: https://docs.github.com/en/copilot/how-tos/use-copilot-agents/use-copilot-cli
-
-          Available commands:
-            /add-dir <directory> - Add a directory to the allowed list for file access
-            /agent - Browse and select from available agents (if any)
-            /clear, /new - Clear the conversation history
-            /compact - Summarize conversation history to reduce context window usage
-            /context - Show context window token usage and visualization
-            /cwd, /cd [directory] - Change working directory or show current directory
-            /delegate <prompt> - Delegate changes to remote repository with AI-generated PR
-            /exit, /quit - Exit the CLI
-            /share [file|gist] [path] - Share session to markdown file or GitHub gist
-            /feedback - Provide feedback about the CLI
-            /help - Show help for interactive commands
-            /list-dirs - Display all allowed directories for file access
-            /login - Log in to Copilot
-            /logout - Log out of Copilot
-            /mcp [show|add|edit|delete|disable|enable] [server-name] - Manage MCP server configuration
-            /model [model] - Select AI model to use
-            /plan [prompt] - Create an implementation plan before coding
-            /reset-allowed-tools - Reset the list of allowed tools
-            /resume [sessionId] - Switch to a different session (optionally specify session ID)
-            /review [prompt] - Run code review agent to analyze changes
-            /session [checkpoints [n]|files|plan|rename <name>] - Show session info and workspace summary. Use subcommands for details.
-            /skills [list|info|add|remove|reload] [args...] - Manage skills for enhanced capabilities
-            /terminal-setup - Configure terminal for multiline input support (shift+enter and ctrl+enter)
-            /theme [show|set|list] [auto|dark|light] - View or configure terminal theme
-            /usage - Display session usage metrics and statistics
-            /user [show|list|switch] - Manage GitHub user list
-
-          ---
-
-          **Note**: If the above documentation doesn't answer the user's request, you can fetch additional documentation from the official GitHub Docs for more information.
-
-          Use the web_fetch tool to fetch https://docs.github.com/api/article/body?pathname=/en/copilot/how-tos/use-copilot-agents/use-copilot-cli
-
-          You can also follow hyperlinks to related docs pages using the same API pattern.
-      - role: assistant
-        content: I don't see a "test skill" feature in the documentation. Based on the docs, I can manage skills with the
-          `/skills` command, but there's no specific "test skill" mentioned. Could you clarify what you'd like me to do?
-          Would you like me to just say hello, or were you referring to a specific feature?
+        content: Hello! I don't have a specific "test skill" tool available. However, I'm ready to help you with coding tasks,
+          running commands, searching files, and more. What would you like to work on?