Skip to content

Commit 396e451

Browse files
Fix maccatalyst RID detection in SDK targets
The OS detection logic falls through to 'linux' for maccatalyst-* RIDs since they don't start with 'win' or 'osx'. Add explicit handling for the 'maccatalyst' prefix to map it to 'osx', so the correct Darwin CLI binary is downloaded. Relates to #454 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent ce54e43 commit 396e451

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

dotnet/src/build/GitHub.Copilot.SDK.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<!-- Determine OS: from RID prefix if set, otherwise from build host -->
99
<_CopilotOs Condition="'$(RuntimeIdentifier)' != '' And $(RuntimeIdentifier.StartsWith('win'))">win</_CopilotOs>
1010
<_CopilotOs Condition="'$(_CopilotOs)' == '' And '$(RuntimeIdentifier)' != '' And $(RuntimeIdentifier.StartsWith('osx'))">osx</_CopilotOs>
11+
<_CopilotOs Condition="'$(_CopilotOs)' == '' And '$(RuntimeIdentifier)' != '' And $(RuntimeIdentifier.StartsWith('maccatalyst'))">osx</_CopilotOs>
1112
<_CopilotOs Condition="'$(_CopilotOs)' == '' And '$(RuntimeIdentifier)' != ''">linux</_CopilotOs>
1213

1314
<!-- Determine arch: from RID suffix if set, otherwise from build host -->

0 commit comments

Comments
 (0)