fix nil access

Author: qmuntal

go/internal/e2e/compaction_test.go

@@ -83,6 +83,9 @@ func TestCompaction(t *testing.T) {
 		if err != nil {
 			t.Fatalf("Failed to send verification message: %v", err)
 		}
+		if answer == nil {
+			t.Fatalf("Expected an answer, got nil")
+		}
 		if answer.Data.Content == nil || !strings.Contains(strings.ToLower(*answer.Data.Content), "dragon") {
 			t.Errorf("Expected answer to contain 'dragon', got %v", answer.Data.Content)
 		}

go/internal/e2e/mcp_and_agents_test.go

@@ -44,6 +44,10 @@ func TestMCPServers(t *testing.T) {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if message == nil {
+			t.Fatal("Expected a message, got nil")
+		}
+
 		if message.Data.Content == nil || !strings.Contains(*message.Data.Content, "4") {
 			t.Errorf("Expected message to contain '4', got: %v", message.Data.Content)
 		}
@@ -170,6 +174,10 @@ func TestCustomAgents(t *testing.T) {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if message == nil {
+			t.Fatal("Expected a message, got nil")
+		}
+
 		if message.Data.Content == nil || !strings.Contains(*message.Data.Content, "10") {
 			t.Errorf("Expected message to contain '10', got: %v", message.Data.Content)
 		}

go/internal/e2e/session_test.go

@@ -533,6 +533,10 @@ func TestSession(t *testing.T) {
 			t.Fatalf("Failed to send message after abort: %v", err)
 		}
 
+		if answer == nil {
+			t.Fatalf("Expected an answer after abort, got nil")
+		}
+
 		if answer.Data.Content == nil || !strings.Contains(*answer.Data.Content, "4") {
 			t.Errorf("Expected answer to contain '4', got %v", answer.Data.Content)
 		}
@@ -550,7 +554,7 @@ func TestSession(t *testing.T) {
 
 		var deltaContents []string
 
-		unsubscribe := session.On(func(event copilot.SessionEvent) {
+		session.On(func(event copilot.SessionEvent) {
 			switch event.Type {
 			case "assistant.message_delta":
 				if event.Data.DeltaContent != nil {
@@ -561,11 +565,14 @@ func TestSession(t *testing.T) {
 		})
 
 		assistantMessage, err := session.SendAndWait(t.Context(), copilot.MessageOptions{Prompt: "What is 2+2?"})
-		unsubscribe()
 		if err != nil {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if assistantMessage == nil {
+			t.Fatal("Expected assistant message, got nil")
+		}
+
 		// Should have received delta events
 		if len(deltaContents) == 0 {
 			t.Error("Expected to receive delta events, got none")
@@ -605,6 +612,10 @@ func TestSession(t *testing.T) {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if assistantMessage == nil {
+			t.Fatal("Expected assistant message, got nil")
+		}
+
 		if assistantMessage.Data.Content == nil || !strings.Contains(*assistantMessage.Data.Content, "2") {
 			t.Errorf("Expected assistant message to contain '2', got %v", assistantMessage.Data.Content)
 		}
@@ -629,6 +640,10 @@ func TestSession(t *testing.T) {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if assistantMessage == nil {
+			t.Fatal("Expected assistant message, got nil")
+		}
+
 		// Should have received multiple events
 		if len(receivedEvents) == 0 {
 			t.Error("Expected to receive events, got none")
@@ -685,6 +700,10 @@ func TestSession(t *testing.T) {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if assistantMessage == nil {
+			t.Fatal("Expected assistant message, got nil")
+		}
+
 		if assistantMessage.Data.Content == nil || !strings.Contains(*assistantMessage.Data.Content, "2") {
 			t.Errorf("Expected assistant message to contain '2', got %v", assistantMessage.Data.Content)
 		}

go/internal/e2e/skills_test.go

@@ -71,6 +71,10 @@ func TestSkills(t *testing.T) {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if message == nil {
+			t.Fatalf("Expected a message, got nil")
+		}
+
 		if message.Data.Content == nil || !strings.Contains(*message.Data.Content, skillMarker) {
 			t.Errorf("Expected message to contain skill marker '%s', got: %v", skillMarker, message.Data.Content)
 		}
@@ -99,6 +103,10 @@ func TestSkills(t *testing.T) {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if message == nil {
+			t.Fatalf("Expected a message, got nil")
+		}
+
 		if message.Data.Content != nil && strings.Contains(*message.Data.Content, skillMarker) {
 			t.Errorf("Expected message to NOT contain skill marker '%s' when disabled, got: %v", skillMarker, *message.Data.Content)
 		}

go/internal/e2e/tools_test.go

@@ -35,6 +35,10 @@ func TestTools(t *testing.T) {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if answer == nil {
+			t.Fatalf("Expected an answer, got nil")
+		}
+
 		if answer.Data.Content == nil || !strings.Contains(*answer.Data.Content, "ELIZA") {
 			t.Errorf("Expected answer to contain 'ELIZA', got %v", answer.Data.Content)
 		}
@@ -64,6 +68,10 @@ func TestTools(t *testing.T) {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if answer == nil {
+			t.Fatalf("Expected an answer, got nil")
+		}
+
 		if answer.Data.Content == nil || !strings.Contains(*answer.Data.Content, "HELLO") {
 			t.Errorf("Expected answer to contain 'HELLO', got %v", answer.Data.Content)
 		}
@@ -93,6 +101,10 @@ func TestTools(t *testing.T) {
 			t.Fatalf("Failed to send message: %v", err)
 		}
 
+		if answer == nil {
+			t.Fatalf("Expected an answer, got nil")
+		}
+
 		// Check the underlying traffic
 		traffic, err := ctx.GetExchanges()
 		if err != nil {