Skip to content

Commit 9a31b5b

Browse files
committed
fix: add missing return after exitWithNoMatchingRequestError in CI mode
When running tests in CI mode with no cached response, the proxy would crash with ERR_HTTP_HEADERS_SENT because exitWithNoMatchingRequestError() calls onError() (which writes headers), but then execution continued to super.performRequest() which also tries to write headers. This caused cascading test failures because the proxy process would die and subsequent tests couldn't communicate with it. This is why the 'sendAndWait throws on timeout' test is currently skipped in CI. With this fix, that test could potentially be enabled.
1 parent 73c1431 commit 9a31b5b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/harness/replayingCapiProxy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,7 @@ export class ReplayingCapiProxy extends CapturingHttpProxy {
292292
state.workDir,
293293
state.toolResultNormalizers,
294294
);
295+
return;
295296
}
296297
super.performRequest(options);
297298
} catch (err) {

0 commit comments

Comments
 (0)