honor ClientOptions.UseStdio = false

Author: qmuntal

go/client.go

@@ -71,6 +71,7 @@ type Client struct {
 	sessionsMux      sync.Mutex
 	isExternalServer bool
 	conn             interface{} // stores net.Conn for external TCP connections
+	useStdio         bool        // resolved value from options
 	autoStart        bool        // resolved value from options
 	autoRestart      bool        // resolved value from options
 }
@@ -95,7 +96,6 @@ func NewClient(options *ClientOptions) *Client {
 		CLIPath:  "copilot",
 		Cwd:      "",
 		Port:     0,
-		UseStdio: true,
 		LogLevel: "info",
 	}
 
@@ -105,13 +105,14 @@ func NewClient(options *ClientOptions) *Client {
 		sessions:         make(map[string]*Session),
 		actualHost:       "localhost",
 		isExternalServer: false,
+		useStdio:         true,
 		autoStart:        true, // default
 		autoRestart:      true, // default
 	}
 
 	if options != nil {
 		// Validate mutually exclusive options
-		if options.CLIUrl != "" && (options.UseStdio || options.CLIPath != "") {
+		if options.CLIUrl != "" && ((options.UseStdio != nil && *options.UseStdio) || options.CLIPath != "") {
 			panic("CLIUrl is mutually exclusive with UseStdio and CLIPath")
 		}
 
@@ -126,7 +127,7 @@ func NewClient(options *ClientOptions) *Client {
 			client.actualHost = host
 			client.actualPort = port
 			client.isExternalServer = true
-			opts.UseStdio = false
+			client.useStdio = false
 			opts.CLIUrl = options.CLIUrl
 		}
 
@@ -139,14 +140,17 @@ func NewClient(options *ClientOptions) *Client {
 		if options.Port > 0 {
 			opts.Port = options.Port
 			// If port is specified, switch to TCP mode
-			opts.UseStdio = false
+			client.useStdio = false
 		}
 		if options.LogLevel != "" {
 			opts.LogLevel = options.LogLevel
 		}
 		if len(options.Env) > 0 {
 			opts.Env = options.Env
 		}
+		if options.UseStdio != nil {
+			client.useStdio = *options.UseStdio
+		}
 		if options.AutoStart != nil {
 			client.autoStart = *options.AutoStart
 		}
@@ -1050,7 +1054,7 @@ func (c *Client) startCLIServer() error {
 	args := []string{"--server", "--log-level", c.options.LogLevel}
 
 	// Choose transport mode
-	if c.options.UseStdio {
+	if c.useStdio {
 		args = append(args, "--stdio")
 	} else if c.options.Port > 0 {
 		args = append(args, "--port", strconv.Itoa(c.options.Port))
@@ -1096,7 +1100,7 @@ func (c *Client) startCLIServer() error {
 		c.process.Env = append(c.process.Env, "COPILOT_SDK_AUTH_TOKEN="+c.options.GithubToken)
 	}
 
-	if c.options.UseStdio {
+	if c.useStdio {
 		// For stdio mode, we need stdin/stdout pipes
 		stdin, err := c.process.StdinPipe()
 		if err != nil {
@@ -1171,7 +1175,7 @@ func (c *Client) startCLIServer() error {
 
 // connectToServer establishes a connection to the server.
 func (c *Client) connectToServer() error {
-	if c.options.UseStdio {
+	if c.useStdio {
 		// Already connected via stdio in startCLIServer
 		return nil
 	}

go/client_test.go

@@ -194,7 +194,7 @@ func TestClient_URLParsing(t *testing.T) {
 
 		NewClient(&ClientOptions{
 			CLIUrl:   "localhost:8080",
-			UseStdio: true,
+			UseStdio: Bool(true),
 		})
 	})
 
@@ -221,11 +221,31 @@ func TestClient_URLParsing(t *testing.T) {
 			CLIUrl: "8080",
 		})
 
-		if client.options.UseStdio {
+		if client.useStdio {
 			t.Error("Expected UseStdio to be false when CLIUrl is provided")
 		}
 	})
 
+	t.Run("should set UseStdio to false when UseStdio is set to true", func(t *testing.T) {
+		client := NewClient(&ClientOptions{
+			UseStdio: Bool(true),
+		})
+
+		if !client.useStdio {
+			t.Error("Expected UseStdio to be true when UseStdio is set to true")
+		}
+	})
+
+	t.Run("should set UseStdio to false when UseStdio is set to false", func(t *testing.T) {
+		client := NewClient(&ClientOptions{
+			UseStdio: Bool(false),
+		})
+
+		if client.useStdio {
+			t.Error("Expected UseStdio to be false when UseStdio is set to false")
+		}
+	})
+
 	t.Run("should mark client as using external server", func(t *testing.T) {
 		client := NewClient(&ClientOptions{
 			CLIUrl: "localhost:8080",

go/e2e/client_test.go

@@ -17,7 +17,7 @@ func TestClient(t *testing.T) {
 	t.Run("should start and connect to server using stdio", func(t *testing.T) {
 		client := copilot.NewClient(&copilot.ClientOptions{
 			CLIPath:  cliPath,
-			UseStdio: true,
+			UseStdio: copilot.Bool(true),
 		})
 		t.Cleanup(func() { client.ForceStop() })
 
@@ -54,7 +54,7 @@ func TestClient(t *testing.T) {
 	t.Run("should start and connect to server using tcp", func(t *testing.T) {
 		client := copilot.NewClient(&copilot.ClientOptions{
 			CLIPath:  cliPath,
-			UseStdio: false,
+			UseStdio: copilot.Bool(true),
 		})
 		t.Cleanup(func() { client.ForceStop() })
 
@@ -134,7 +134,7 @@ func TestClient(t *testing.T) {
 	t.Run("should get status with version and protocol info", func(t *testing.T) {
 		client := copilot.NewClient(&copilot.ClientOptions{
 			CLIPath:  cliPath,
-			UseStdio: true,
+			UseStdio: copilot.Bool(true),
 		})
 		t.Cleanup(func() { client.ForceStop() })
 
@@ -161,7 +161,7 @@ func TestClient(t *testing.T) {
 	t.Run("should get auth status", func(t *testing.T) {
 		client := copilot.NewClient(&copilot.ClientOptions{
 			CLIPath:  cliPath,
-			UseStdio: true,
+			UseStdio: copilot.Bool(true),
 		})
 		t.Cleanup(func() { client.ForceStop() })
 
@@ -190,7 +190,7 @@ func TestClient(t *testing.T) {
 	t.Run("should list models when authenticated", func(t *testing.T) {
 		client := copilot.NewClient(&copilot.ClientOptions{
 			CLIPath:  cliPath,
-			UseStdio: true,
+			UseStdio: copilot.Bool(true),
 		})
 		t.Cleanup(func() { client.ForceStop() })
 

go/types.go

@@ -19,7 +19,7 @@ type ClientOptions struct {
 	// Port for TCP transport (default: 0 = random port)
 	Port int
 	// UseStdio enables stdio transport instead of TCP (default: true)
-	UseStdio bool
+	UseStdio *bool
 	// CLIUrl is the URL of an existing Copilot CLI server to connect to over TCP
 	// Format: "host:port", "http://host:port", or just "port" (defaults to localhost)
 	// Examples: "localhost:8080", "http://127.0.0.1:9000", "8080"