From 395b66450a3cb1bb9e270aa1ebfafd07c135f51d Mon Sep 17 00:00:00 2001 From: Hirsch Singhal <1666363+hpsin@users.noreply.github.com> Date: Wed, 6 Nov 2024 11:09:47 -0800 Subject: [PATCH 1/2] Max 25 keys for GH Apps (#52074) Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com> --- .../managing-private-keys-for-github-apps.md | 6 ++++-- data/features/app-key-limit.yml | 6 ++++++ 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 data/features/app-key-limit.yml diff --git a/content/apps/creating-github-apps/authenticating-with-a-github-app/managing-private-keys-for-github-apps.md b/content/apps/creating-github-apps/authenticating-with-a-github-app/managing-private-keys-for-github-apps.md index 7bdcf49b81d8..b9f3eb9999e7 100644 --- a/content/apps/creating-github-apps/authenticating-with-a-github-app/managing-private-keys-for-github-apps.md +++ b/content/apps/creating-github-apps/authenticating-with-a-github-app/managing-private-keys-for-github-apps.md @@ -14,12 +14,14 @@ topics: After you create a {% data variables.product.prodname_github_app %}, you'll need to generate a private key in order to make requests to the {% data variables.product.product_name %} API as the application itself. For example, you need a private key to sign a JSON Web Token (JWT) in order to request an installation access token. For more information, see "[AUTOTITLE](/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app)" -You can create multiple private keys and rotate them to prevent downtime if a key is compromised or lost. To verify that a private key matches a public key, see "[Verifying private keys](#verifying-private-keys)". +You can create {% ifversion app-key-limit %}up to 25 {% else %}multiple {% endif %}private keys for an app. You should use multiple keys in order to rotate keys without downtime in the event of a key compromise. {% ifversion app-key-limit %}If your application has 25 or more keys, you must delete some before you can create more. {% endif %} -Private keys do not expire and instead need to be manually revoked. For more information about how to revoke a private key, see "[Deleting private keys](#deleting-private-keys)." +Private keys do not expire and instead need to be manually revoked. For more information about how to revoke or delete a private key, see "[Deleting private keys](#deleting-private-keys)." You must keep private keys for {% data variables.product.prodname_github_apps %} secure. For more information, see "[Storing private keys](#storing-private-keys)". +To verify that a private key matches a public key, see "[Verifying private keys](#verifying-private-keys)". + ## Generating private keys To generate a private key: diff --git a/data/features/app-key-limit.yml b/data/features/app-key-limit.yml new file mode 100644 index 000000000000..f9bcc852ac7c --- /dev/null +++ b/data/features/app-key-limit.yml @@ -0,0 +1,6 @@ +# Reference: #https://github.com/github/docs-content/issues/15738 + +versions: + fpt: '*' + ghec: '*' + ghes: '>=3.15' From 0c52ef2cf8fc82b6843891cbd8a9e87a29bfdcbf Mon Sep 17 00:00:00 2001 From: Devraj Mehta Date: Wed, 6 Nov 2024 15:50:15 -0500 Subject: [PATCH 2/2] Add Xcode to content exclusions supported IDEs (#52997) --- .../excluding-content-from-github-copilot.md | 1 + 1 file changed, 1 insertion(+) diff --git a/content/copilot/managing-copilot/managing-github-copilot-in-your-organization/setting-policies-for-copilot-in-your-organization/excluding-content-from-github-copilot.md b/content/copilot/managing-copilot/managing-github-copilot-in-your-organization/setting-policies-for-copilot-in-your-organization/excluding-content-from-github-copilot.md index 358e0f0d30fe..0f13ebf1f106 100644 --- a/content/copilot/managing-copilot/managing-github-copilot-in-your-organization/setting-policies-for-copilot-in-your-organization/excluding-content-from-github-copilot.md +++ b/content/copilot/managing-copilot/managing-github-copilot-in-your-organization/setting-policies-for-copilot-in-your-organization/excluding-content-from-github-copilot.md @@ -45,6 +45,7 @@ Repository administrators{% ifversion ghec %}, organization owners, and enterpri | {% data variables.product.prodname_vscode %} | {% octicon "check" aria-label="Supported" %} | {% octicon "check" aria-label="Supported" %} | | JetBrains IDEs | {% octicon "check" aria-label="Supported" %} | {% octicon "check" aria-label="Supported" %} | | Vim/Neovim | {% octicon "check" aria-label="Supported" %} | Not applicable | +| Xcode | {% octicon "check" aria-label="Supported" %} | Not applicable | | Azure Data Studio | {% octicon "x" aria-label="Not supported" %} | Not applicable | | The {% data variables.product.github %} website | Not applicable | {% octicon "x" aria-label="Not supported" %} |