🎯 Repository Quality Report: Validator File Size Compliance (2026-02-23)

[github-actions[bot]]

Overview

This analysis focuses on Validator File Size Compliance — a custom, repository-specific focus area. The project's documented guidelines in AGENTS.md define a hard limit of 300 lines for validator files (pkg/workflow/*_validation.go), with a target range of 100–200 lines. This run identified 7 validator files currently exceeding that hard limit, with the most severe case at 566 lines (89% over limit).

The good news: the majority of validators (39 out of 46 validation files) are already within acceptable size bounds, indicating the architecture is sound and these oversized files are outliers that need splitting.

Critical Issues — Files Exceeding Hard Limit (300 lines)

File	Lines	% Over Limit	Status
pkg/workflow/strict_mode_validation.go	566	+89%	❌ Critical
pkg/workflow/expression_validation.go	490	+63%	❌ Critical
pkg/workflow/safe_output_validation_config.go	412	+37%	❌ High
pkg/workflow/concurrency_validation.go	353	+18%	⚠️ Medium
pkg/workflow/repository_features_validation.go	352	+17%	⚠️ Medium
pkg/workflow/permissions_validation.go	340	+13%	⚠️ Medium
pkg/workflow/mcp_config_validation.go	326	+9%	⚠️ Low

Full Analysis Report

Focus Area: Validator File Size Compliance

Analysis Date: 2026-02-23
Strategy Type: Custom (60% allocation)
Rationale: This repository has explicit documented guidelines (in AGENTS.md) about validator file sizes. Periodic compliance checking ensures maintainability and test quality stay on track as validators accumulate new rules.

Current State Assessment

Metrics Collected:

Metric	Value	Status
Total validation files	46	✅
Files within target (≤300 lines)	39	✅
Files over hard limit (>300 lines)	7	❌
Largest violator	566 lines	❌
Files in ideal range (100-200 lines)	21	✅
Average validator size	~180 lines	✅

Strengths

• Strong overall compliance: 85% of validators are within guidelines
• Well-documented validation architecture: Each oversized file has detailed header comments explaining purpose and structure
• Existing patterns in place: The codebase already demonstrates correct splitting with many validators in the 90–200 line range
• Clear naming convention: {domain}_{subdomain}_validation.go is consistently followed
• Comprehensive test coverage: Test files are co-located with validation logic

Areas for Improvement

1. strict_mode_validation.go (566 lines) — Highest priority: contains 3+ distinct validation domains (permissions, network, MCP network, bash tools). Should be split into strict_mode_permissions_validation.go, strict_mode_network_validation.go, etc.

2. expression_validation.go (490 lines) — Contains allowlist management, pattern matching, and expression extraction. Could be split into expression_allowlist_validation.go and expression_syntax_validation.go.

3. safe_output_validation_config.go (412 lines) — This is primarily a data/config file containing TypeValidationConfig structs and a large data table. The config table itself (~330 lines) could be extracted to a separate file like safe_output_type_configs.go.

4. concurrency_validation.go (353 lines) — Contains expression parsing logic mixed with validation logic; the expression parser could be extracted.

5. repository_features_validation.go (352 lines) — Contains feature detection, caching layer, and validation logic — three distinct concerns.

6. permissions_validation.go (340 lines) — Contains toolset-to-permissions mapping data + validation logic. The data table could be a separate file.

7. mcp_config_validation.go (326 lines) — Just slightly over limit; likely a quick win with minor extraction.

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: The following tasks are designed for GitHub Copilot coding agent execution. Please split these into individual work items for Claude to process. Each task is self-contained and targets a specific file.

Task 1: Split strict_mode_validation.go (566 lines → target ≤300/file)

Priority: High
Estimated Effort: Medium
Focus Area: Validator File Size Compliance

Description:
pkg/workflow/strict_mode_validation.go at 566 lines is 89% over the 300-line hard limit. It contains multiple distinct validation domains that should be split into separate files following the {domain}_{subdomain}_validation.go naming convention.

Acceptance Criteria:

• Original file reduced to ≤300 lines
• Each new split file is ≤300 lines
• All existing tests continue to pass (make test-unit)
• New files follow {domain}_{subdomain}_validation.go naming
• Each new file has an appropriate header comment block
• No functional changes — only reorganization

Code Region: pkg/workflow/strict_mode_validation.go

Refactor `pkg/workflow/strict_mode_validation.go` (currently 566 lines, exceeds the 300-line hard limit documented in AGENTS.md).

1. Read the file carefully to identify distinct validation domains
2. Split into 2-3 files following the naming convention `{domain}_{subdomain}_validation.go`:
   - `strict_mode_permissions_validation.go` — permissions-related strict checks
   - `strict_mode_network_validation.go` — network and MCP network checks  
   - Keep `strict_mode_validation.go` as the orchestrator (≤150 lines)
3. Ensure each new file has a header comment explaining its purpose
4. Run `make test-unit` to verify all tests pass
5. Run `make fmt` to format the code
6. Do NOT change any logic or validation rules — only reorganize the code

---

Task 2: Split expression_validation.go (490 lines → target ≤300/file)

Priority: High
Estimated Effort: Medium
Focus Area: Validator File Size Compliance

Description:
pkg/workflow/expression_validation.go at 490 lines contains expression allowlist management, pattern matching logic, and syntax validation — three separable concerns.

Acceptance Criteria:

• Original file reduced to ≤300 lines
• Each new split file is ≤300 lines
• All existing tests continue to pass (make test-unit)
• No functional changes — only reorganization

Code Region: pkg/workflow/expression_validation.go

Refactor `pkg/workflow/expression_validation.go` (currently 490 lines, exceeds 300-line hard limit in AGENTS.md).

1. Read the file to identify distinct responsibilities
2. Extract the allowlist data and pattern definitions into `expression_allowlist_validation.go`
3. Keep the core validation orchestration in `expression_validation.go` (≤300 lines)
4. Ensure all header comments are preserved/updated in both files
5. Run `make test-unit` to verify correctness
6. Run `make fmt` before committing

---

Task 3: Extract config data from safe_output_validation_config.go (412 lines)

Priority: Medium
Estimated Effort: Small
Focus Area: Validator File Size Compliance

Description:
pkg/workflow/safe_output_validation_config.go contains a large ValidationConfig data table (~330 lines of type configuration entries) mixed with helper functions. The data table should be extracted to a separate file.

Acceptance Criteria:

• Config data table extracted to safe_output_type_configs.go or similar
• Original file reduced to ≤300 lines
• All existing tests continue to pass (make test-unit)
• No functional changes

Code Region: pkg/workflow/safe_output_validation_config.go

Refactor `pkg/workflow/safe_output_validation_config.go` (412 lines, over 300-line limit in AGENTS.md).

1. Identify the large `ValidationConfig` data structure and its entries
2. Extract the data table to a new file `safe_output_type_configs.go`
3. Keep the type definitions (`FieldValidation`, `TypeValidationConfig`, etc.) and helper functions (`GetValidationConfigJSON`, `GetValidationConfigForType`, `GetDefaultMaxForType`) in the original file
4. Add appropriate header comments to both files
5. Run `make test-unit` to confirm no regressions
6. Run `make fmt` before committing

---

Task 4: Split repository_features_validation.go (352 lines)

Priority: Medium
Estimated Effort: Small
Focus Area: Validator File Size Compliance

Description:
pkg/workflow/repository_features_validation.go mixes three concerns: caching infrastructure (sync.Map, sync.Once patterns), GitHub API calls for feature detection, and validation logic. Extracting the caching/API layer would bring the file within limits.

Acceptance Criteria:

• File reduced to ≤300 lines
• Caching and API detection logic separated from validation orchestration
• All existing tests continue to pass (make test-unit)
• No functional changes

Code Region: pkg/workflow/repository_features_validation.go

Refactor `pkg/workflow/repository_features_validation.go` (352 lines, over 300-line limit).

1. Read the file to understand the three concerns: validation logic, GitHub API calls, and caching
2. Extract the caching layer and GitHub API detection functions into `repository_features_cache.go`
3. Keep the main `validateRepositoryFeatures()` orchestration in the original file
4. Update header comments in both files to reflect their scope
5. Run `make test-unit` to verify no regressions
6. Run `make fmt` before committing

---

Task 5: Quick fix mcp_config_validation.go (326 lines)

Priority: Low
Estimated Effort: Small
Focus Area: Validator File Size Compliance

Description:
pkg/workflow/mcp_config_validation.go is just 26 lines over the limit (9%). A targeted extraction of the MCP type requirements data or helper utilities would bring it within guidelines.

Acceptance Criteria:

• File reduced to ≤300 lines
• All existing tests pass (make test-unit)
• No functional changes

Code Region: pkg/workflow/mcp_config_validation.go

Refactor `pkg/workflow/mcp_config_validation.go` (326 lines, slightly over 300-line hard limit).

1. Identify the smallest logical unit that can be extracted (likely type requirements data or helper validation functions)
2. Extract ~30+ lines to a new file or consolidate with an existing related validator
3. Ensure all tests pass with `make test-unit`
4. Run `make fmt` before committing

---

📊 Historical Context

Previous Focus Areas

Date	Focus Area	Type	Custom	Key Outcomes
2026-02-23	Validator File Size Compliance	Custom	Yes	7 oversized validators identified, 5 refactoring tasks generated

---

🎯 Recommendations

Immediate Actions (This Week)

1. Refactor strict_mode_validation.go (566 lines) — Priority: High
2. Refactor expression_validation.go (490 lines) — Priority: High

Short-term Actions (This Month)

1. Extract config data from safe_output_validation_config.go (412 lines) — Priority: Medium
2. Split repository_features_validation.go (352 lines) — Priority: Medium

Long-term Actions (This Quarter)

1. Fix mcp_config_validation.go (326 lines) — Priority: Low
2. Add a CI lint check that fails when any *_validation.go file exceeds 300 lines to prevent future regressions

---

📈 Success Metrics

• Validators over hard limit: 7 → 0 (target)
• Largest validator: 566 lines → ≤300 lines (target)
• Validators in ideal range (100–200 lines): 21/46 (46%) → ≥60% (target)

---

References:

• §22308423339

AI generated by Repository Quality Improvement Agent

• expires on Feb 24, 2026, 1:43 PM UTC

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-02-24T13:43:30.052Z.

Closed by Workflow