Merge detection job into action job by pelikhan · Pull Request #18079 · github/gh-aw

pelikhan · 2026-02-24T07:04:41Z

Consolidate the detection job into the action job to streamline the workflow and improve efficiency. This change simplifies the process by integrating detection steps directly into the action job, eliminating the need for a separate detection job.

✨ PR Review Safe Output Test - Run 22349857400

💥 [THE END] — Illustrated by Smoke Claude

github-actions · 2026-02-24T07:14:17Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-02-24T07:18:34Z

Smoke test results (Codex)
PRs: fix: add copilot-requests to GitHub Actions workflow JSON schema
PRs: fix: update wasm golden files for Copilot CLI v0.0.415
GitHub MCP ✅ | Serena MCP ✅ | Playwright ✅
Web fetch ✅ | File write ✅ | Bash cat ✅
Build (make build) ✅
Overall: PASS

🔮 The oracle has spoken through Smoke Codex

Detection steps now run after all agent artifact uploads are complete, ensuring artifacts are available before detection analysis begins. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-02-24T07:23:39Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

- Added steps to upload engine output files and agent artifacts in multiple workflows. - Implemented parsing of agent logs and MCP Gateway logs for step summaries. - Included firewall log printing with permission fixes to ensure logs can be uploaded. - Introduced cache-memory data upload as an artifact. - Ensured all new steps are set to run always and handle errors gracefully.

github-actions · 2026-02-24T07:28:48Z

Smoke test results
PRs: #18067 fix: add copilot-requests to GitHub Actions workflow JSON schema; #17754 parser: stabilize strict unknown-property ordering
GitHub MCP ✅
Serena activate ✅; Serena find_symbol ❌ (MCP EOF)
Playwright ✅; Web-fetch ✅
File write ✅; Bash cat ✅
Build ✅
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-02-24T07:30:11Z

Commit pushed: d7ffa89

Generated by Changeset Generator

pelikhan · 2026-02-24T07:30:54Z

@copilot do a code review of the change to ensure quality. Review the pull request description for the goal: running the detection in the action job.

Copilot · 2026-02-24T07:31:01Z

@pelikhan I've opened a new pull request, #18081, to work on those changes. Once the pull request is ready, I'll request review from you.

pelikhan · 2026-02-24T07:34:44Z

@copilot make sure to clear the MCP configuration file before the detection job.

Copilot · 2026-02-24T07:34:58Z

@pelikhan I've opened a new pull request, #18085, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

github-actions · 2026-02-24T09:18:48Z

Hey @pelikhan 👋 — thanks for the work on consolidating the detection job inline with the action job! The approach is clear, the change is coherent across all 177 lock files and the backing Go compiler/threat-detection code, and a changeset entry was included. A few things to flag before this can be merged:

Process: direct PR — CONTRIBUTING.md is explicit: "Traditional Pull Requests Are Not Enabled" and "You cannot create pull requests directly." The expected workflow is: open an issue with a detailed agentic plan → maintainer assigns it to GitHub Copilot Agent → agent creates the PR. This PR was created directly on branch merged_detection_job, bypassing that flow. If you are a maintainer making an intentional exception, that context would be helpful to call out in the PR body.
Removed test file — pkg/workflow/detection_permissions_test.go was deleted (118 lines of coverage removed). The commit message doesn't explain why those tests are no longer needed. A brief note confirming the permissions scenarios are now covered by the updated tests (e.g., safe_jobs_threat_detection_test.go, threat_detection_test.go) would help reviewers validate nothing was silently dropped.
PR description is thin — the body explains what was done but not why this is better (latency? permissions simplification? job count?). Adding a line or two about the motivation strengthens the review context.

If you'd like to bring this into compliance with the agentic workflow, here's a prompt you can assign to your coding agent:

Review PR #18079 in github/gh-aw (branch: merged_detection_job).

The PR merges the threat detection job into the main action job across all .lock.yml compiled workflows and updates the Go compiler in pkg/workflow/.

Do the following:
1. Verify that the deletion of detection_permissions_test.go is justified — confirm the permission-checking scenarios it covered are now exercised by the remaining test files (detection_success_test.go, safe_jobs_threat_detection_test.go, threat_detection_test.go, threat_detection_isolation_test.go). If any scenarios are missing, add them back.
2. Update the PR description to include: (a) the motivation for inlining detection (e.g., fewer jobs, simpler permissions model, latency), and (b) a note on the test deletion rationale.
3. Run `make agent-finish` to confirm build, tests, lint, and recompile all pass with the changes.

Generated by Contribution Check

github-actions · 2026-02-24T12:00:00Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-02-24T12:00:02Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-02-24T12:00:06Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-02-24T12:01:44Z

📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident...

github-actions · 2026-02-24T12:03:44Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-02-24T12:05:51Z

Smoke test results:
PRs: [docs] Update glossary - daily scan; Clear MCP config before inline threat detection
GitHub MCP: ✅
Serena MCP (activate+find_symbol>=3): ❌
Playwright: ✅
Web Fetch: ✅
File Write: ✅
Bash Cat: ✅
Build: ✅
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-02-24T12:08:44Z

🤖 Smoke test §22349857389 | @pelikhan

Test
GitHub MCP	✅
Safe Inputs GH CLI	✅
Serena MCP	❌
Playwright	✅
Web Fetch	✅
File Write + Bash	✅
Discussion Interaction	✅
Build	✅
Discussion Creation	✅
Workflow Dispatch	✅
PR Review	✅

Overall: ⚠️ PARTIAL PASS (11/12 - Serena MCP unavailable)

📰 BREAKING: Report filed by Smoke Copilot

github-actions

🤖 Smoke test agent review: PR merges the detection job into the action job, removing the copilot-requests permission schema entry. Changes look clean across the lock files. No issues found.

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-02-24T12:08:46Z

.changeset/patch-merge-detection-job.md

+---
+"gh-aw": patch
+---
+Merged the detection job into the action job so the detection steps run inline with the main workflow and removed the unused `copilot-requests` permission schema entry.


✅ Good changeset description - clear and concise about what was merged and removed.

github-actions · 2026-02-24T12:09:01Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-02-24T12:09:59Z

Commit pushed: a9d8f1e

💥 [THE END] — Illustrated by Smoke Claude

github-actions · 2026-02-24T12:10:04Z

Smoke Test Results — Run §22349857400

Core Tests #1–10: ✅✅✅✅✅✅✅✅✅✅
PR Review Tests #11–17: ✅✅✅⚠️✅✅⚠️

Overall: PARTIAL (14 ✅, 2 ⚠️ skipped — no review threads, no test PR to close)

💥 [THE END] — Illustrated by Smoke Claude

github-actions

💥 Automated smoke test review - all systems nominal!

💥 [THE END] — Illustrated by Smoke Claude

merging detection job into action job

2e2e452

Copilot AI review requested due to automatic review settings February 24, 2026 07:04

fix: correct comment formatting in TestGenerateKnownNeedsExpressions

389bc35

pelikhan added the smoke label Feb 24, 2026

fix: move inline detection steps after Upload agent artifacts

0b5f03d

Detection steps now run after all agent artifact uploads are complete, ensuring artifacts are available before detection analysis begins. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

pelikhan added smoke and removed smoke labels Feb 24, 2026

Add changeset [skip-ci]

d7ffa89

Copilot AI mentioned this pull request Feb 24, 2026

Code review: merge detection job into action job #18081

Closed

Copilot AI mentioned this pull request Feb 24, 2026

Clear MCP config before inline threat detection #18085

Merged

Copilot AI reviewed Feb 24, 2026

View reviewed changes

github-actions bot mentioned this pull request Feb 24, 2026

[Contribution Check Report] Contribution Check — 2026-02-24 #18102

Open

github-actions bot mentioned this pull request Feb 24, 2026

[Daily Report] Daily Status Report — 2026-02-24 #18104

Open

Clear MCP config before inline threat detection (#18085)

53ba9b9

pelikhan added smoke and removed smoke labels Feb 24, 2026

github-actions bot added smoke-copilot and removed smoke labels Feb 24, 2026

github-actions bot reviewed Feb 24, 2026

View reviewed changes

test: Add smoke test file for run 22349857400

a9d8f1e

github-actions bot mentioned this pull request Feb 24, 2026

Smoke Test: Claude - 22349857400 #18127

Open

github-actions bot added the smoke-claude label Feb 24, 2026

github-actions bot reviewed Feb 24, 2026

View reviewed changes

pelikhan merged commit bfa05d0 into main Feb 24, 2026

pelikhan deleted the merged_detection_job branch February 24, 2026 12:11

Comments

Conversation

pelikhan commented Feb 24, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

pelikhan commented Feb 24, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

pelikhan commented Feb 24, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Smoke Test Results — Run §22349857400

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pelikhan commented Feb 24, 2026 •

edited by github-actions bot

Loading

github-actions bot commented Feb 24, 2026 •

edited

Loading

github-actions bot commented Feb 24, 2026 •

edited

Loading

github-actions bot commented Feb 24, 2026 •

edited

Loading

github-actions bot commented Feb 24, 2026 •

edited

Loading