Rename `supportsLLMGateway` bool to `llmGatewayPort` int and remove `SupportsLLMGateway()` from interface by Copilot · Pull Request #18838 · github/gh-aw

Copilot · 2026-02-28T13:34:56Z

Update BaseEngine struct: replace supportsLLMGateway bool with llmGatewayPort int
Remove per-engine SupportsLLMGateway() overrides
Remove SupportsLLMGateway() int from the CodingAgentEngine interface
Remove BaseEngine.SupportsLLMGateway() method; add unexported getLLMGatewayPort() for Register() validation
Remove UsesAPIProxy field from AWFCommandConfig entirely — --enable-host-access and --enable-api-proxy are now added unconditionally in BuildAWFArgs
Simplify docker.go: remove conditional registry lookup
Clean up strict_mode_validation.go: remove dead llmGatewayPort < 0 branch and unused GetEngine call
Update tests: remove TestSupportsLLMGateway, remove SupportsLLMGateway() assertion

Original prompt

Rename supportLLMGateway to llmGatewayPort in agentic workflows engine. It is mandatory, fail if < 0

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Changeset

Type: minor
Description: Renamed the agentic workflow engine's supportsLLMGateway flag to llmGatewayPort, required/validated the gateway port, removed the SupportsLLMGateway interface hooks, and consolidated the API proxy/host-access workflow flags.

Generated by Changeset Generator for issue #18838

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

✨ PR Review Safe Output Test - Run 22522442966

💥 [THE END] — Illustrated by Smoke Claude

…f < 0 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-02-28T13:48:06Z

@copilot remove SupportsLLMGateway() it must always be true

…ndatory Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-02-28T13:57:16Z

@copilot remove SupportsLLMGateway() it must always be true

Done in dccbed6. Removed SupportsLLMGateway() from the interface and BaseEngine entirely. All callers simplified to usesAPIProxy := true, the dead < 0 branch in strict-mode validation was removed, and docker.go no longer needs to query the engine registry to decide whether to add the api-proxy image.

pkg/workflow/claude_engine.go

pkg/workflow/copilot_engine_execution.go

…variable Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-02-28T14:06:03Z

@copilot UsesAPIProxy is alway true. Remove and simplify code using it

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-02-28T14:11:48Z

@copilot UsesAPIProxy is alway true. Remove and simplify code using it

Done in 5373113. Removed the UsesAPIProxy field from AWFCommandConfig entirely — --enable-host-access and --enable-api-proxy are now added unconditionally in BuildAWFArgs, and all four engine call sites no longer pass the field.

github-actions · 2026-02-28T14:18:22Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-02-28T14:18:25Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-02-28T14:18:28Z

🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation...

github-actions · 2026-02-28T14:20:55Z

Agent Container Tool Check

Tool	Status	Version
bash	✅	5.2.21
sh	✅	available
git	✅	2.53.0
jq	✅	1.7
yq	✅	v4.52.4
curl	✅	8.5.0
gh	✅	2.87.3
node	✅	v20.20.0
python3	✅	3.12.3
go	✅	1.24.13
java	✅	10.0.102
dotnet	✅	10.0.102

Result: 12/12 tools available ✅

Overall Status: PASS

🔧 Tool validation by Agent Container Smoke Test

github-actions · 2026-02-28T14:21:37Z

Commit pushed: 1df9e44

Generated by Changeset Generator

github-actions · 2026-02-28T14:23:36Z

Smoke test results for @pelikhan and @Copilot:

✅ GitHub MCP
✅ Safe Inputs GH CLI
❌ Serena MCP (not available)
✅ Playwright
✅ Web Fetch
✅ File Writing
✅ Bash Tool
✅ Discussion Interaction
✅ Build gh-aw
✅ Discussion Creation
✅ Workflow Dispatch
✅ PR Review

Overall: ⚠️ PARTIAL PASS (11/12 — Serena MCP unavailable)

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-02-28T14:23:54Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions

💥 Automated smoke test review - all systems nominal! The rename from SupportsLLMGateway() bool to llmGatewayPort int is a clean simplification that removes an unnecessary abstraction layer.

💥 [THE END] — Illustrated by Smoke Claude

Copilot

Pull request overview

Renames per-engine LLM gateway support flag/method to a single llmGatewayPort int on BaseEngine, removes SupportsLLMGateway() from engine APIs, and makes AWF API-proxy/host-access flags unconditional.

Changes:

Replace supportsLLMGateway bool + SupportsLLMGateway() overrides with llmGatewayPort int on BaseEngine and registry-time validation.
Make AWF argument building always include --enable-host-access and --enable-api-proxy; remove UsesAPIProxy from AWFCommandConfig.
Simplify strict-mode firewall validation/tests and ensure api-proxy image collection no longer depends on per-engine gateway support.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/workflow/agentic_engine.go	Reworks engine capability surface; introduces `llmGatewayPort` and registry validation.
pkg/workflow/awf_helpers.go	Removes `UsesAPIProxy` config and unconditionally enables host-access + api-proxy flags.
pkg/workflow/docker.go	Simplifies docker image collection for AWF sidecars (api-proxy).
pkg/workflow/strict_mode_validation.go	Removes engine lookup / LLM gateway branching from strict firewall validation.
pkg/workflow/strict_mode_llm_gateway_test.go	Updates strict-mode tests to align with new “general error” behavior.
pkg/workflow/claude_engine.go	Sets `llmGatewayPort` and removes per-engine `SupportsLLMGateway()` override/usage.
pkg/workflow/codex_engine.go	Sets `llmGatewayPort` and removes per-engine `SupportsLLMGateway()` override/usage.
pkg/workflow/copilot_engine.go	Sets `llmGatewayPort` and removes per-engine `SupportsLLMGateway()` override.
pkg/workflow/copilot_engine_execution.go	Removes conditional `UsesAPIProxy` wiring into AWF command build.
pkg/workflow/gemini_engine.go	Sets `llmGatewayPort` and removes per-engine `SupportsLLMGateway()` override/usage.
pkg/workflow/gemini_engine_test.go	Removes `SupportsLLMGateway()` assertion from capability tests.
.changeset/minor-rename-llmgateway-port.md	Adds changeset entry describing the rename and behavior changes.

Comments suppressed due to low confidence (1)

pkg/workflow/agentic_engine.go:378

The llmGatewayPort validation only checks < 0, which allows the zero value (0) when an engine forgets to initialize the field. Since this value represents a network port (and built-in ports are positive), it would be safer to validate it’s within a valid port range (e.g., 1–65535) or at least > 0 to catch misconfiguration early.

	type portProvider interface{ getLLMGatewayPort() int }
	if p, ok := engine.(portProvider); ok && p.getLLMGatewayPort() < 0 {
		panic(fmt.Sprintf("engine '%s': llmGatewayPort must be >= 0, got %d", engine.GetID(), p.getLLMGatewayPort()))
	}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-28T14:30:37Z

pkg/workflow/docker.go

 		if workflowData != nil && workflowData.AI != "" {
-			registry := GetGlobalEngineRegistry()
-			engine, err := registry.GetEngine(workflowData.AI)
-			if err == nil && engine.SupportsLLMGateway() > 0 {
-				apiProxyImage := constants.DefaultFirewallRegistry + "/api-proxy:" + awfImageTag
-				if !imageSet[apiProxyImage] {
-					images = append(images, apiProxyImage)
-					imageSet[apiProxyImage] = true
-					dockerLog.Printf("Added AWF api-proxy sidecar container for engine with LLM gateway support: %s", apiProxyImage)
-				}
+			apiProxyImage := constants.DefaultFirewallRegistry + "/api-proxy:" + awfImageTag
+			if !imageSet[apiProxyImage] {
+				images = append(images, apiProxyImage)
+				imageSet[apiProxyImage] = true
+				dockerLog.Printf("Added AWF api-proxy sidecar container: %s", apiProxyImage)
 			}
 		}


collectDockerImages only adds the api-proxy sidecar image when workflowData.AI != "". However, workflows that rely on the default engine can legitimately have AI == "" (the compiler falls back to GetDefaultEngine()), while AWF args now always include --enable-api-proxy and --skip-pull. In that case the workflow can fail at runtime because the required api-proxy image was never pre-downloaded. Consider removing the workflowData.AI != "" guard (or basing the decision on whether AWF will be invoked) so api-proxy is always included whenever the firewall/AWF is enabled.

See below for a potential fix:

apiProxyImage := constants.DefaultFirewallRegistry + "/api-proxy:" + awfImageTag if !imageSet[apiProxyImage] { images = append(images, apiProxyImage) imageSet[apiProxyImage] = true dockerLog.Printf("Added AWF api-proxy sidecar container: %s", apiProxyImage)

Copilot · 2026-02-28T14:30:38Z

pkg/workflow/agentic_engine.go

 func (r *EngineRegistry) Register(engine CodingAgentEngine) {
+	type portProvider interface{ getLLMGatewayPort() int }
+	if p, ok := engine.(portProvider); ok && p.getLLMGatewayPort() < 0 {
+		panic(fmt.Sprintf("engine '%s': llmGatewayPort must be >= 0, got %d", engine.GetID(), p.getLLMGatewayPort()))
+	}


Register validates llmGatewayPort only when the engine satisfies an interface with an unexported method (getLLMGatewayPort). Engines implemented outside the workflow package can’t implement that method, so the assertion will always fail and the validation will be skipped. If llmGatewayPort is mandatory, consider making the port accessor exported (or part of a public optional interface) and/or treating “missing port provider” as an error so invalid/misconfigured engines can’t be registered silently.

This issue also appears on line 375 of the same file.

Initial plan

28726f8

Copilot AI assigned Copilot and pelikhan Feb 28, 2026

Copilot started work on behalf of pelikhan February 28, 2026 13:35 View session

Rename supportsLLMGateway to llmGatewayPort in agentic engine, fail i…

45254fe

…f < 0 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Rename supportLLMGateway to llmGatewayPort in workflows engine~~ Rename supportsLLMGateway bool to llmGatewayPort int in BaseEngine Feb 28, 2026

Copilot finished work on behalf of pelikhan February 28, 2026 13:47

Copilot started work on behalf of pelikhan February 28, 2026 13:48 View session

Remove SupportsLLMGateway() from interface — LLM gateway is always ma…

dccbed6

…ndatory Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~Rename supportsLLMGateway bool to llmGatewayPort int in BaseEngine~~ Rename supportsLLMGateway bool to llmGatewayPort int and remove SupportsLLMGateway() from interface Feb 28, 2026

Copilot finished work on behalf of pelikhan February 28, 2026 13:57

pelikhan reviewed Feb 28, 2026

View reviewed changes

pkg/workflow/claude_engine.go Outdated Show resolved Hide resolved

pkg/workflow/copilot_engine_execution.go Outdated Show resolved Hide resolved

Copilot started work on behalf of pelikhan February 28, 2026 13:59 View session

Inline UsesAPIProxy: true directly, remove intermediate usesAPIProxy …

7c1d9c0

…variable Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan February 28, 2026 14:04

Copilot started work on behalf of pelikhan February 28, 2026 14:06 View session

Remove UsesAPIProxy field — always true, inline unconditionally

5373113

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan February 28, 2026 14:12

pelikhan added the smoke label Feb 28, 2026

Add changeset [skip-ci]

1df9e44

ci: trigger CI checks

be822dd

github-actions bot mentioned this pull request Feb 28, 2026

Smoke Test: Copilot - 22522442977 #18847

Closed

github-actions bot added smoke-copilot and removed smoke labels Feb 28, 2026

pelikhan marked this pull request as ready for review February 28, 2026 14:26

Copilot AI review requested due to automatic review settings February 28, 2026 14:26

Copilot started reviewing on behalf of pelikhan February 28, 2026 14:26 View session

pelikhan merged commit 8cea8a9 into main Feb 28, 2026
51 checks passed

pelikhan deleted the copilot/rename-support-llm-gateway branch February 28, 2026 14:27

github-actions bot reviewed Feb 28, 2026

View reviewed changes

Copilot AI reviewed Feb 28, 2026

View reviewed changes

github-actions bot mentioned this pull request Feb 28, 2026

Smoke Test: Claude - 22524436360 #18862

Closed

Conversation

Copilot AI commented Feb 28, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset

Uh oh!

pelikhan commented Feb 28, 2026

Uh oh!

Copilot AI commented Feb 28, 2026

Uh oh!

Uh oh!

Uh oh!

pelikhan commented Feb 28, 2026

Uh oh!

Copilot AI commented Feb 28, 2026

Uh oh!

github-actions bot commented Feb 28, 2026

Uh oh!

github-actions bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 28, 2026

Agent Container Tool Check

Uh oh!

github-actions bot commented Feb 28, 2026

Uh oh!

github-actions bot commented Feb 28, 2026

Uh oh!

github-actions bot commented Feb 28, 2026

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 28, 2026 •

edited by github-actions bot

Loading

github-actions bot commented Feb 28, 2026 •

edited

Loading

github-actions bot commented Feb 28, 2026 •

edited

Loading