From a57c2ce88a71ad20ea52aa529a16a36292fe1340 Mon Sep 17 00:00:00 2001
From: GitHub Copilot <copilot@github.com>
Date: Tue, 24 Feb 2026 19:05:39 +0000
Subject: [PATCH] refactor: extract execGHAPI helper in checks_command to
 eliminate duplicated error handling
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The three gh API fetch functions (fetchPRHeadSHA, fetchCheckRuns,
fetchCommitStatuses) all shared identical patterns for building args,
calling workflow.ExecGH, handling exec.ExitError, and classifying API
errors. Extract a single execGHAPI helper that centralises this logic.

Each caller is now reduced to: build the URL, call execGHAPI, parse the
JSON response — making the intent of each function immediately clear.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 pkg/cli/checks_command.go | 53 ++++++++++++++++-----------------------
 1 file changed, 21 insertions(+), 32 deletions(-)

diff --git a/pkg/cli/checks_command.go b/pkg/cli/checks_command.go
index 2601c3d1ef..2f02846a70 100644
--- a/pkg/cli/checks_command.go
+++ b/pkg/cli/checks_command.go
@@ -163,22 +163,31 @@ func FetchChecksResult(repoOverride string, prNumber string) (*ChecksResult, err
 	}, nil
 }
 
-// fetchPRHeadSHA fetches the head commit SHA for a given PR.
-func fetchPRHeadSHA(repoOverride string, prNumber string) (string, error) {
-	args := []string{"api", "repos/{owner}/{repo}/pulls/" + prNumber, "--jq", ".head.sha"}
+// execGHAPI runs a gh api subcommand and returns raw output.
+// repoOverride is appended as --repo if non-empty; context labels error messages.
+func execGHAPI(repoOverride string, context string, args ...string) ([]byte, error) {
 	if repoOverride != "" {
 		args = append(args, "--repo", repoOverride)
 	}
-
 	cmd := workflow.ExecGH(args...)
 	output, err := cmd.Output()
 	if err != nil {
 		var exitErr *exec.ExitError
 		if errors.As(err, &exitErr) {
 			stderr := strings.TrimSpace(string(exitErr.Stderr))
-			return "", classifyGHAPIError(exitErr.ExitCode(), stderr, prNumber, repoOverride)
+			return nil, classifyGHAPIError(exitErr.ExitCode(), stderr, context, repoOverride)
 		}
-		return "", fmt.Errorf("gh api call failed: %w", err)
+		return nil, fmt.Errorf("gh api call failed: %w", err)
+	}
+	return output, nil
+}
+
+// fetchPRHeadSHA fetches the head commit SHA for a given PR.
+func fetchPRHeadSHA(repoOverride string, prNumber string) (string, error) {
+	output, err := execGHAPI(repoOverride, prNumber,
+		"api", "repos/{owner}/{repo}/pulls/"+prNumber, "--jq", ".head.sha")
+	if err != nil {
+		return "", err
 	}
 
 	sha := strings.TrimSpace(string(output))
@@ -238,20 +247,10 @@ type checkRunsAPIResponse struct {
 
 // fetchCheckRuns fetches check runs for a commit SHA.
 func fetchCheckRuns(repoOverride string, sha string) ([]PRCheckRun, error) {
-	args := []string{"api", "repos/{owner}/{repo}/commits/" + sha + "/check-runs", "--paginate"}
-	if repoOverride != "" {
-		args = append(args, "--repo", repoOverride)
-	}
-
-	cmd := workflow.ExecGH(args...)
-	output, err := cmd.Output()
+	output, err := execGHAPI(repoOverride, sha,
+		"api", "repos/{owner}/{repo}/commits/"+sha+"/check-runs", "--paginate")
 	if err != nil {
-		var exitErr *exec.ExitError
-		if errors.As(err, &exitErr) {
-			stderr := strings.TrimSpace(string(exitErr.Stderr))
-			return nil, classifyGHAPIError(exitErr.ExitCode(), stderr, sha, repoOverride)
-		}
-		return nil, fmt.Errorf("gh api call failed: %w", err)
+		return nil, err
 	}
 
 	var resp checkRunsAPIResponse
@@ -270,20 +269,10 @@ type commitStatusAPIResponse struct {
 
 // fetchCommitStatuses fetches commit statuses (legacy Status API) for a commit SHA.
 func fetchCommitStatuses(repoOverride string, sha string) ([]PRCommitStatus, error) {
-	args := []string{"api", "repos/{owner}/{repo}/commits/" + sha + "/status"}
-	if repoOverride != "" {
-		args = append(args, "--repo", repoOverride)
-	}
-
-	cmd := workflow.ExecGH(args...)
-	output, err := cmd.Output()
+	output, err := execGHAPI(repoOverride, sha,
+		"api", "repos/{owner}/{repo}/commits/"+sha+"/status")
 	if err != nil {
-		var exitErr *exec.ExitError
-		if errors.As(err, &exitErr) {
-			stderr := strings.TrimSpace(string(exitErr.Stderr))
-			return nil, classifyGHAPIError(exitErr.ExitCode(), stderr, sha, repoOverride)
-		}
-		return nil, fmt.Errorf("gh api call failed: %w", err)
+		return nil, err
 	}
 
 	var resp commitStatusAPIResponse