Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding labels will still show as deletion #764

Open
stokkie90 opened this issue Feb 26, 2025 · 0 comments
Open

Excluding labels will still show as deletion #764

stokkie90 opened this issue Feb 26, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@stokkie90
Copy link

Problem Description

When configuring labels.exclude to exclude some/all labels it will still show as a Deletion in PR context. After some looking into the code i think it shouldn't actually run the delete API call. (in NOP mode it also doesn't print the delete message) Link to exclude code block.

What is actually happening

  • Showing labels that should be exluded in the deletion column!

What is the expected behavior

  • Do not show any excluded labels in the PR Comment.

Context

Are you using the hosted instance of probot/settings or running your own?

self-hosted

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

2.1.16

@stokkie90 stokkie90 added the bug Something isn't working label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant