From 12f21adce66e2de3bf73a06768bf7179a86e8d11 Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 16:06:20 +0200 Subject: [PATCH 01/12] -Wclazy-qstring-arg --- mainwindow.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mainwindow.cpp b/mainwindow.cpp index 4794b430..c426c0bb 100644 --- a/mainwindow.cpp +++ b/mainwindow.cpp @@ -1764,8 +1764,9 @@ void MainWindow::on_actionCreate_Movie_of_wavefronts_triggered() if (QMessageBox::Yes == QMessageBox::question(0,"---------- 3D wave front Video maker -------------","Do you have FFMpeg and want it to make a video from these images?")) { - QString cmd = QString("ffmpeg -framerate 1 -i %1%03d.jpg -c:v libx264 -vf format=yuv420p -y -r 25 %2").arg(dowavefront? waveprefix:astigprefix). \ - arg(dowavefront? "waveFronts.mp4": "astig.mp4"); + QString cmd = QString("ffmpeg -framerate 1 -i %1%03d.jpg -c:v libx264 -vf format=yuv420p -y -r 25 %2") + .arg(dowavefront ? waveprefix : astigprefix, + dowavefront ? "waveFronts.mp4" : "astig.mp4"); bool ok = false; QString text = QInputDialog::getText(this, From 57b012e92a514cf2e85d39f0b16ed10e4f20e592 Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 16:52:57 +0200 Subject: [PATCH 02/12] -Wclazy-unused-non-trivial-variable, fix memleak in movie maker, no UI freeze in movie maker --- astigpolargraph.cpp | 1 - mainwindow.cpp | 22 ++++++++++++---------- percentcorrectiondlg.cpp | 2 -- settingsigramimportconfig.cpp | 2 +- 4 files changed, 13 insertions(+), 14 deletions(-) diff --git a/astigpolargraph.cpp b/astigpolargraph.cpp index aa880750..654127a6 100644 --- a/astigpolargraph.cpp +++ b/astigpolargraph.cpp @@ -30,7 +30,6 @@ astigPolargraph::astigPolargraph( QListlist, QWidget *parent) : chart->addAxis(radialAxis, QPolarChart::PolarOrientationRadial); double maxAstig = 1.; - QVector wavefronts =SurfaceManager::get_instance()->m_wavefronts; QScreen *screen = QGuiApplication::primaryScreen(); qreal screenDPI = screen->physicalDotsPerInchX(); int pensize = 5 * screenDPI/256.; // adjust pen size to screen resolution. 256 is DPI of my 4K 17 inch laptop diff --git a/mainwindow.cpp b/mainwindow.cpp index c426c0bb..d62b3578 100644 --- a/mainwindow.cpp +++ b/mainwindow.cpp @@ -1796,6 +1796,7 @@ void MainWindow::on_actionCreate_Movie_of_wavefronts_triggered() qDebug() << "plain text"<< text; QApplication::setOverrideCursor(Qt::WaitCursor); QProcess *proc = new QProcess; + connect(proc, &QProcess::finished, proc, &QObject::deleteLater); connect(proc, QOverload::of(&QProcess::finished), [=](int exitCode, QProcess::ExitStatus exitStatus){ qDebug() << "what" << exitStatus << "code" << exitCode; }); @@ -1806,22 +1807,23 @@ void MainWindow::on_actionCreate_Movie_of_wavefronts_triggered() proc->start("ffmpeg",args.mid(1)); - while (!proc->waitForFinished(200)){ - QString q = proc->readAll(); - if (q != "") - textEdit->append(q); - QApplication::processEvents(); - } + connect(proc, &QProcess::readyRead, [proc, textEdit]() { + QString output = proc->readAll(); + if (!output.isEmpty()) + textEdit->append(output); + }); + + QEventLoop loop; + connect(proc, &QProcess::finished, &loop, &QEventLoop::quit); + loop.exec(); qDebug() << "done" ; + - proc->waitForFinished(); - QString out = proc->readAll() ; QApplication::restoreOverrideCursor(); - QString fn = dir + "/" + args[args.length()-1]; + QString fn = dir + "/" + args.last(); QDesktopServices::openUrl(fn); - } } diff --git a/percentcorrectiondlg.cpp b/percentcorrectiondlg.cpp index 6f1eee33..db01e98f 100644 --- a/percentcorrectiondlg.cpp +++ b/percentcorrectiondlg.cpp @@ -345,8 +345,6 @@ QPolygonF percentCorrectionDlg::makePercentages(surfaceData *surf){ QVector IdealzoneKnife; QVector ActualZoneKnife; - QVector idealDelta; - QVector actualDelta; IdealzoneKnife << 0.; ActualZoneKnife << 0.0; diff --git a/settingsigramimportconfig.cpp b/settingsigramimportconfig.cpp index 91081f12..c5b1a8f2 100644 --- a/settingsigramimportconfig.cpp +++ b/settingsigramimportconfig.cpp @@ -27,7 +27,7 @@ void settingsIgramImportConfig::on_browse_clicked() { QSettings set; QString defaultPath = set.value("lastPath",".").toString(); - QString path = set.value("importIgramPath",defaultPath).toString(); + //QString path = set.value("importIgramPath",defaultPath).toString(); //unused QString directory = QFileDialog::getExistingDirectory( 0, "Choose directory", "", QFileDialog::ShowDirsOnly | QFileDialog::DontResolveSymlinks); From 6b0be51a9366eeb0366b94f9c80bfcfc9f528dc7 Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 17:02:41 +0200 Subject: [PATCH 03/12] -Wclazy-overloaded-signal --- astigscatterplot.cpp | 2 +- myplotpicker.cpp | 2 +- myplotpicker.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/astigscatterplot.cpp b/astigscatterplot.cpp index 0e308d88..706056ee 100644 --- a/astigscatterplot.cpp +++ b/astigscatterplot.cpp @@ -12,7 +12,7 @@ astigScatterPlot::astigScatterPlot(QWidget *parent):QwtPlot( parent ),m_max(.3) { Picker = new myPlotPicker( this ); - connect(Picker, SIGNAL(selected(QString)),this,SLOT(selectedwave(QString))); + connect(Picker, SIGNAL(mySelected(QString)),this,SLOT(selectedwave(QString))); QwtPlotGrid *grid = new QwtPlotGrid(); grid->setPen( Qt::gray, 0.0, Qt::DotLine ); diff --git a/myplotpicker.cpp b/myplotpicker.cpp index f1e3201d..d091d6de 100644 --- a/myplotpicker.cpp +++ b/myplotpicker.cpp @@ -59,7 +59,7 @@ void myPlotPicker::select(const QPointF &p){ QString s = find(p); if (s == "") return; - emit selected(s); + emit mySelected(s); } QString myPlotPicker::find(const QPointF &p)const{ diff --git a/myplotpicker.h b/myplotpicker.h index 9c263c3b..3be301a8 100644 --- a/myplotpicker.h +++ b/myplotpicker.h @@ -18,7 +18,7 @@ class myPlotPicker : public QwtPlotPicker QString find(const QPointF &p)const; QwtPlot *m_plot; signals: - void selected(const QString); + void mySelected(const QString); public slots: }; From f5e6f35231f3f9d3d363f4aad53d36fdabacc4ce Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 17:04:02 +0200 Subject: [PATCH 04/12] re-enable clazy problem matcher as there are few enough warnings --- .github/workflows/build-linux-clazy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-linux-clazy.yml b/.github/workflows/build-linux-clazy.yml index b42fec41..a0222614 100644 --- a/.github/workflows/build-linux-clazy.yml +++ b/.github/workflows/build-linux-clazy.yml @@ -17,7 +17,7 @@ jobs: - run: sudo apt update - run: sudo apt install -y clazy apt-utils build-essential wget qt5-qmake qt5-qmake-bin qt5-assistant qtbase5-dev qtmultimedia5-dev libqt5charts5 libqt5charts5-dev libqt5multimedia* libqt5datavisualization5-dev libqt5datavisualization5 libopencv-core-dev libopencv-dev libqwt-qt5-6 libqwt-qt5-dev libarmadillo-dev - run: qmake -spec linux-clang QMAKE_CXX="clazy" - #- uses: ammaraskar/gcc-problem-matcher@master #TODO 2023/08/05 re-enable problem matcher when all warnings are fixed + - uses: ammaraskar/gcc-problem-matcher@master # ignore noisy dirs from QT files itself # all level 1 checks but ignore clazy-no-connect-by-name # no parallel make with clazy to not mess log From 987553e46d453449e41cd136a043a25d3529f0fd Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 19:02:16 +0200 Subject: [PATCH 05/12] more safety and memory leaks --- mainwindow.cpp | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/mainwindow.cpp b/mainwindow.cpp index d62b3578..c5adc8d5 100644 --- a/mainwindow.cpp +++ b/mainwindow.cpp @@ -1778,11 +1778,11 @@ void MainWindow::on_actionCreate_Movie_of_wavefronts_triggered() QDialog *dialog = new QDialog; dialog->setWindowTitle("ffmpeg output"); dialog->resize(1000,1000); - QTextEdit *textEdit = new QTextEdit(); + QTextEdit *textEdit = new QTextEdit(dialog); - QPushButton *closeButton = new QPushButton("Close"); + QPushButton *closeButton = new QPushButton("Close", dialog); - QVBoxLayout *layout = new QVBoxLayout; + QVBoxLayout *layout = new QVBoxLayout(dialog); layout->addWidget(textEdit); layout->addWidget(closeButton); @@ -1800,14 +1800,23 @@ void MainWindow::on_actionCreate_Movie_of_wavefronts_triggered() connect(proc, QOverload::of(&QProcess::finished), [=](int exitCode, QProcess::ExitStatus exitStatus){ qDebug() << "what" << exitStatus << "code" << exitCode; }); + // ensure we kill ffmpeg if the dialog is closed + connect(dialog, &QDialog::finished, dialog, [=](int) { + if (proc->state() == QProcess::Running) { + proc->kill(); + proc->waitForFinished(); + qDebug() << "ffmpeg Process killed by user"; + } + }); + proc->setProcessChannelMode(QProcess::MergedChannels); proc->setWorkingDirectory(dir); - QStringList args = text.split(" "); + QStringList args = QProcess::splitCommand(text); qDebug() << "args" << args.mid(1); proc->start("ffmpeg",args.mid(1)); - connect(proc, &QProcess::readyRead, [proc, textEdit]() { + connect(proc, &QProcess::readyRead, textEdit, [proc, textEdit]() { QString output = proc->readAll(); if (!output.isEmpty()) textEdit->append(output); From 8b2c8900976fb1ba9ac320cb5fab117449210a3c Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 19:21:15 +0200 Subject: [PATCH 06/12] clazy-range-loop-reference --- astigpolargraph.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/astigpolargraph.cpp b/astigpolargraph.cpp index 654127a6..bba6eab6 100644 --- a/astigpolargraph.cpp +++ b/astigpolargraph.cpp @@ -126,7 +126,7 @@ int astigPolargraph::findClosestPoint(const QPointF clickedPoint){ qreal distance(INT_MAX); int closeNdx = -1; int ndx = 0; - for (auto sample : m_list) { + for (const auto& sample : m_list) { QPointF currentPoint(sample.m_xastig, sample.m_yastig); qreal currentDistance = qSqrt((currentPoint.x() - clickedPoint.x()) * (currentPoint.x() - clickedPoint.x()) From 04b0b77cf1290f913f8d74f60674a28248397b70 Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 19:23:31 +0200 Subject: [PATCH 07/12] clazy-unused-non-trivial-variable --- camwizardpage1.cpp | 2 -- psi_dlg.cpp | 1 - settingsigramimportconfig.cpp | 4 ++-- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/camwizardpage1.cpp b/camwizardpage1.cpp index ef45e963..b8c435f6 100644 --- a/camwizardpage1.cpp +++ b/camwizardpage1.cpp @@ -462,7 +462,6 @@ void CamWizardPage1::on_pushButton_2_clicked() void CamWizardPage1::showResuslts() { - QStringList parms; ui->xFv->setText(QString().number(cameraMatrix.at(0,0))); ui->yFv->setText(QString().number(cameraMatrix.at(1,1))); ui->XFc->setText(QString().number(cameraMatrix.at(0,2))); @@ -473,7 +472,6 @@ void CamWizardPage1::showResuslts() ui->P1->setText(QString().number(distCoeffs.at(0,2))); ui->P2->setText(QString().number(distCoeffs.at(0,3))); ui->K3->setText(QString().number(distCoeffs.at(0,4))); - } void CamWizardPage1::on_currentLens_clicked() diff --git a/psi_dlg.cpp b/psi_dlg.cpp index e181fb3a..36fc64e2 100644 --- a/psi_dlg.cpp +++ b/psi_dlg.cpp @@ -69,7 +69,6 @@ void PSI_dlg::on_browse_clicked() //m_surfaceManager->process_psi(dialog.selectedFiles()); QStringList files = dialog.selectedFiles(); ui->igramList->addItems(files); - QStringList phases; double deltaAngle = ui->PSIPhaseValue->value(); int index = 0; double startAngle = 0; diff --git a/settingsigramimportconfig.cpp b/settingsigramimportconfig.cpp index c5b1a8f2..2867e889 100644 --- a/settingsigramimportconfig.cpp +++ b/settingsigramimportconfig.cpp @@ -25,8 +25,8 @@ settingsIgramImportConfig::~settingsIgramImportConfig() void settingsIgramImportConfig::on_browse_clicked() { - QSettings set; - QString defaultPath = set.value("lastPath",".").toString(); + //QSettings set; + //QString defaultPath = set.value("lastPath",".").toString(); //QString path = set.value("importIgramPath",defaultPath).toString(); //unused QString directory = QFileDialog::getExistingDirectory( 0, "Choose directory", "", From 5ca7c49683975b52a9532b21f3326aca61e91069 Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 19:27:43 +0200 Subject: [PATCH 08/12] clazy-container-anti-pattern --- nullvariationdlg.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nullvariationdlg.cpp b/nullvariationdlg.cpp index 5222ab0c..775c9d69 100644 --- a/nullvariationdlg.cpp +++ b/nullvariationdlg.cpp @@ -128,10 +128,10 @@ QMap histo(const QList data, int bins){ { intervals[ *minma.first + histInterval * (i+1)] = 0; } - QVector keys = intervals.keys().toVector(); + const QList& keys = intervals.keys(); for (int i = 0; i < data.size(); ++i){ for (int j = 0; j < bins; ++j){ - if (data[i]<= keys[j]) { + if (data[i] <= keys[j]) { ++intervals[keys[j]]; break; } From cc79f500bafd3e4f9c18a07ba965108900fdb772 Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 19:38:17 +0200 Subject: [PATCH 09/12] clazy-detaching-temporary --- edgeplot.cpp | 13 ++++++------- mainwindow.cpp | 4 ++-- psi_dlg.cpp | 3 ++- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/edgeplot.cpp b/edgeplot.cpp index b5e7f4d0..bc28d0d7 100644 --- a/edgeplot.cpp +++ b/edgeplot.cpp @@ -64,13 +64,12 @@ void EdgePlot::Update(){ m_chart->createDefaultAxes(); - m_chart->axes(Qt::Horizontal).first()->setRange(-1,105); - - m_chart->axes(Qt::Vertical).first()->setRange(-10,10); - - - m_chart->axes(Qt::Horizontal).first()->setTitleText("start edge at percent of radius of mirror"); - m_chart->axes(Qt::Vertical).first()->setTitleText("waves"); + auto axesH = m_chart->axes(Qt::Horizontal); + axesH.first()->setRange(-1,105); + axesH.first()->setTitleText("start edge at percent of radius of mirror"); + auto axesV = m_chart->axes(Qt::Vertical); + axesV.first()->setRange(-10,10); + axesV.first()->setTitleText("waves"); } void EdgePlot::on_height_valueChanged(int value) { diff --git a/mainwindow.cpp b/mainwindow.cpp index c5adc8d5..b69d9b26 100644 --- a/mainwindow.cpp +++ b/mainwindow.cpp @@ -475,8 +475,8 @@ void MainWindow::on_actionLoad_Interferogram_triggered() ui->useAnnulust->hide(); if (dialog.exec()){ if (dialog.selectedFiles().size() == 1){ - loadFile(dialog.selectedFiles().first()); - + QStringList selectedFiles = dialog.selectedFiles(); + loadFile(selectedFiles.first()); } else{ m_igramsToProcess = dialog.selectedFiles(); diff --git a/psi_dlg.cpp b/psi_dlg.cpp index 36fc64e2..c55da6c1 100644 --- a/psi_dlg.cpp +++ b/psi_dlg.cpp @@ -64,7 +64,8 @@ void PSI_dlg::on_browse_clicked() }); dialog.setNameFilters(filters); if (dialog.exec()){ - QFileInfo a(dialog.selectedFiles().first()); + QStringList files = dialog.selectedFiles(); + QFileInfo a(files.first()); settings.setValue("lastPath",a.absoluteFilePath()); //m_surfaceManager->process_psi(dialog.selectedFiles()); QStringList files = dialog.selectedFiles(); From b418b42f872342d37036095889eb577315db5fd1 Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 19:53:50 +0200 Subject: [PATCH 10/12] fix QT5 build --- mainwindow.cpp | 4 ++-- psi_dlg.cpp | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/mainwindow.cpp b/mainwindow.cpp index b69d9b26..4059437c 100644 --- a/mainwindow.cpp +++ b/mainwindow.cpp @@ -1796,7 +1796,7 @@ void MainWindow::on_actionCreate_Movie_of_wavefronts_triggered() qDebug() << "plain text"<< text; QApplication::setOverrideCursor(Qt::WaitCursor); QProcess *proc = new QProcess; - connect(proc, &QProcess::finished, proc, &QObject::deleteLater); + QObject::connect(proc, SIGNAL(finished(int, QProcess::ExitStatus)), proc, SLOT(deleteLater())); connect(proc, QOverload::of(&QProcess::finished), [=](int exitCode, QProcess::ExitStatus exitStatus){ qDebug() << "what" << exitStatus << "code" << exitCode; }); @@ -1823,7 +1823,7 @@ void MainWindow::on_actionCreate_Movie_of_wavefronts_triggered() }); QEventLoop loop; - connect(proc, &QProcess::finished, &loop, &QEventLoop::quit); + QObject::connect(proc, SIGNAL(finished(int, QProcess::ExitStatus)), &loop, SLOT(quit())); loop.exec(); qDebug() << "done" ; diff --git a/psi_dlg.cpp b/psi_dlg.cpp index c55da6c1..8bbf4c78 100644 --- a/psi_dlg.cpp +++ b/psi_dlg.cpp @@ -68,7 +68,6 @@ void PSI_dlg::on_browse_clicked() QFileInfo a(files.first()); settings.setValue("lastPath",a.absoluteFilePath()); //m_surfaceManager->process_psi(dialog.selectedFiles()); - QStringList files = dialog.selectedFiles(); ui->igramList->addItems(files); double deltaAngle = ui->PSIPhaseValue->value(); int index = 0; From 38a805c154e1d38bdfc99b66b591ff1c38bcdd9a Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Sun, 20 Jul 2025 21:44:39 +0200 Subject: [PATCH 11/12] some less warnings --- camwizardpage1.cpp | 4 ++-- contourplot.cpp | 11 ++++------- dftarea.cpp | 2 -- intensityplot.cpp | 5 ++--- unwraperrorsview.cpp | 4 ++-- wavefrontloader.cpp | 4 ++-- 6 files changed, 12 insertions(+), 18 deletions(-) diff --git a/camwizardpage1.cpp b/camwizardpage1.cpp index b8c435f6..88612770 100644 --- a/camwizardpage1.cpp +++ b/camwizardpage1.cpp @@ -246,7 +246,7 @@ void CamWizardPage1::on_compute_clicked() std::vector keypoints; detector.detect( dial, keypoints); - int horz = 1; + /*int horz = 1; int vert = 1; for (std::size_t ndx = 1; ndx < keypoints.size(); ++ndx){ float del = keypoints[ndx-1].pt.x - keypoints[ndx].pt.x; @@ -258,7 +258,7 @@ void CamWizardPage1::on_compute_clicked() horz = 1; ++vert; } - } + }*/ } } diff --git a/contourplot.cpp b/contourplot.cpp index bf7ad123..b0f6f0a1 100644 --- a/contourplot.cpp +++ b/contourplot.cpp @@ -181,20 +181,17 @@ void ContourPlot::showContoursChanged(double val){ } void ContourPlot::applyZeroOffset(bool useMiddle){ - double min,max; - max = m_wf->max; - min = m_wf->min; + //double max = m_wf->max; + double min = m_wf->min; if (useMiddle){ zOffset = 0.; m_useMiddleOffset = true; - } else { zOffset = min; m_useMiddleOffset = false; - max -= zOffset; - min -= zOffset; - + //max -= zOffset; + //min -= zOffset; } setZRange(); diff --git a/dftarea.cpp b/dftarea.cpp index ad151f09..f8895b45 100644 --- a/dftarea.cpp +++ b/dftarea.cpp @@ -720,8 +720,6 @@ cv::Mat DFTArea::vortex(QImage &img, double low) dft(imageMat,fdomMat); imageMat.release(); - double dc = fdomMat.at(0,0,0); - dc/=size; int count = 0; bool *bp = m_mask.ptr(0); for (int i = 0; i < size; ++i){ diff --git a/intensityplot.cpp b/intensityplot.cpp index cbfc7a06..ccd94deb 100644 --- a/intensityplot.cpp +++ b/intensityplot.cpp @@ -52,7 +52,7 @@ class iSurfaceData: public QwtSyntheticPointData int m_rad; iSurfaceData(cv::Mat plane): QwtSyntheticPointData( plane.cols ), - m_plane(plane), m_rad(plane.cols/2),m_angle(90) + m_plane(plane), m_rad(plane.cols/2) { } @@ -73,9 +73,8 @@ class iSurfaceData: public QwtSyntheticPointData } - private: - double m_angle; + }; bool intensityPlot::eventFilter( QObject *object, QEvent *event ) diff --git a/unwraperrorsview.cpp b/unwraperrorsview.cpp index e5b037e7..1a8d5ca6 100644 --- a/unwraperrorsview.cpp +++ b/unwraperrorsview.cpp @@ -30,12 +30,12 @@ void unwrapErrorsView::createUnwrapErrors(){ double v2 = m_wf.data.at(y,x+1); double v3 = m_wf.data.at(y+1,x); if ((fabs(v1 - v2) > .5) || (fabs(v1 - v3) > .5)){ - errorView.at(y,x) = 255; + errorView.at(y,x) = 255; ++cnt; } } else { - errorView.at(y,x) = 100; + errorView.at(y,x) = 100; } } diff --git a/wavefrontloader.cpp b/wavefrontloader.cpp index e2723904..1216a918 100644 --- a/wavefrontloader.cpp +++ b/wavefrontloader.cpp @@ -50,7 +50,7 @@ void waveFrontLoader::loadx( SurfaceManager *sm){ int size = m_list.size(); emit status(0); - bool mirrorConfigChanged = false; + //bool mirrorConfigChanged = false; done = false; emit progressRange(0, size); @@ -84,7 +84,7 @@ void waveFrontLoader::loadx( SurfaceManager *sm){ emit currentWavefront(file); emit status(++prog); - mirrorConfigChanged |= sm->loadWavefront(file); + /*mirrorConfigChanged |= */sm->loadWavefront(file); } } catch (const std::bad_alloc &ex) From 1b6b16aff67fd811987262eb439b2e8b548e3e7e Mon Sep 17 00:00:00 2001 From: Julien Staub Date: Mon, 21 Jul 2025 18:53:32 +0200 Subject: [PATCH 12/12] Wclazy-incorrect-emit --- batchigramwizard.cpp | 1 - pixelstats.cpp | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/batchigramwizard.cpp b/batchigramwizard.cpp index 47539228..03283a65 100644 --- a/batchigramwizard.cpp +++ b/batchigramwizard.cpp @@ -43,7 +43,6 @@ batchIgramWizard::batchIgramWizard(QStringList files, QWidget *parent, Qt::Windo layout << QWizard::Stretch << QWizard::CancelButton; setButtonLayout(layout); resize(800,600); - emit swapBathConnections(true); } batchIgramWizard::~batchIgramWizard() diff --git a/pixelstats.cpp b/pixelstats.cpp index e9bc20bd..f0c1ad60 100644 --- a/pixelstats.cpp +++ b/pixelstats.cpp @@ -210,7 +210,7 @@ void CanvasPicker::move( const QPoint &pos ) plot()->replot(); plotCanvas->setPaintAttribute( QwtPlotCanvas::ImmediatePaint, false ); - emit(markerMoved()); + emit markerMoved(); }