Conversation
|
I assume you had to do the "increase()" one manually. How many others? I'd like to look over the ones you did manually carefully but don't want to look over all of them as there are so many but a typo in any of them could cause a bug, right? A signal could be lost. |
|
everything that is NOT in first commit e82c3ac has been coded manually. If you want to check everything I recommend you do commit by commit. I tried to make them as reviewable as possible one by one.
Yes but not anything near the way it was before. Now all connect are compile time checked. This means there cannot be "no connection" as before with a warning in the logs. If you think the risk is too high with legacy code I can live with it. Personally I prefer live with an unlikely but possible break in the futur alpha and have a the compile time checks. |
|
Ah! I don't usually look at the commits tab above. I usually look at the files tab above. That's a good way for me to break up this PR into smaller chunks. |
that's one way of doing it. You can also select individual commits or ranges with this method in file tab |
| fitToWindowAct->setEnabled(false); | ||
| fitToWindowAct->setCheckable(true); | ||
| fitToWindowAct->setShortcut(tr("Ctrl+f")); | ||
| connect(fitToWindowAct, SIGNAL(triggered()), this, SLOT(fitToWindow())); |
There was a problem hiding this comment.
Wow! This function: fitToWindow() doesn't appear to exist and it didn't exist in the very first version of DFTF checked into git back in 2016.
|
It's draft. I still have one small change to add (but now you know how to review single commit). |
|
Last change done. Ready for review |
3 participants
close #229
I place this here to show you. Feel free to approve or reject.
I still need to replace one last slot that will require a small rework but is working as is. Hence the "draft" pull request.
Some have been automatically replaced, some manually. You can look at changes commit by commit if you want to dig.
I have found no real issue with original code (except one fixed in #231). This will just make it easier to maintain.