From 761f9fd6dae4ae0c14ddf24f500ffce86395aa39 Mon Sep 17 00:00:00 2001
From: Julien Staub <atsju2@yahoo.fr>
Date: Sun, 9 Nov 2025 08:49:54 +0100
Subject: [PATCH 1/6] Comment PR with installer link on new build

---
 .github/workflows/build-windows.yml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml
index faaf1ad4..6d1a0c59 100644
--- a/.github/workflows/build-windows.yml
+++ b/.github/workflows/build-windows.yml
@@ -385,3 +385,12 @@ jobs:
             DFTFringeInstaller_${{env.WORKFLOW_VERSION}}.exe
             Z_DFTFringe.exe.debug
 
+      - name: Comment PR with artifact link
+        if: github.event_name == 'pull_request'
+        uses: peter-evans/create-or-update-comment@v4
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.pull_request.number }}
+          body: |
+            🚀 New build available for commit ${{ github.sha.substring(0,7) }}
+            [Download installer here](${{ steps.upload_artifact.outputs.artifact-url }})

From 5485183b3f30dcd5ff7b22adf9986a9774f90381 Mon Sep 17 00:00:00 2001
From: Julien Staub <atsju2@yahoo.fr>
Date: Sun, 9 Nov 2025 08:53:54 +0100
Subject: [PATCH 2/6] Add step to get short SHA for build comments

---
 .github/workflows/build-windows.yml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml
index 6d1a0c59..785539ba 100644
--- a/.github/workflows/build-windows.yml
+++ b/.github/workflows/build-windows.yml
@@ -385,6 +385,10 @@ jobs:
             DFTFringeInstaller_${{env.WORKFLOW_VERSION}}.exe
             Z_DFTFringe.exe.debug
 
+      - name: Get short SHA
+        id: short_sha
+        run: echo "short_sha=${GITHUB_SHA::7}" >> $GITHUB_OUTPUT
+        
       - name: Comment PR with artifact link
         if: github.event_name == 'pull_request'
         uses: peter-evans/create-or-update-comment@v4
@@ -392,5 +396,5 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
           issue-number: ${{ github.event.pull_request.number }}
           body: |
-            🚀 New build available for commit ${{ github.sha.substring(0,7) }}
+            🚀 New build available for commit `${{ steps.short_sha.outputs.short_sha }}`
             [Download installer here](${{ steps.upload_artifact.outputs.artifact-url }})

From 0b5063c3a3cc21636911aa1a87e99fbaff1f5118 Mon Sep 17 00:00:00 2001
From: Julien Staub <atsju2@yahoo.fr>
Date: Sun, 9 Nov 2025 10:06:23 +0100
Subject: [PATCH 3/6] fix link and sha

---
 .github/workflows/build-windows.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml
index 785539ba..7a6bc7bf 100644
--- a/.github/workflows/build-windows.yml
+++ b/.github/workflows/build-windows.yml
@@ -378,6 +378,7 @@ jobs:
         run: Tools\QtInstallerFramework\4.7\bin\binarycreator.exe -c DFTFringe\DFTFringeInstaller\config\config.xml -p DFTFringe\DFTFringeInstaller\packages DFTFringeInstaller_${{env.WORKFLOW_VERSION}}
 
       - name: Upload Artifact
+        id: upload_artifact
         uses: actions/upload-artifact@v4
         with:
           name: DFTFringe-windows-build-artifact
@@ -387,8 +388,10 @@ jobs:
 
       - name: Get short SHA
         id: short_sha
+        # Use bash so ${GITHUB_SHA::7} substring syntax works on Windows runners
+        shell: bash
         run: echo "short_sha=${GITHUB_SHA::7}" >> $GITHUB_OUTPUT
-        
+
       - name: Comment PR with artifact link
         if: github.event_name == 'pull_request'
         uses: peter-evans/create-or-update-comment@v4

From b492a8d7a379a4d0ae033ca13894b49be48e9f86 Mon Sep 17 00:00:00 2001
From: Julien Staub <atsju2@yahoo.fr>
Date: Sun, 9 Nov 2025 10:32:30 +0100
Subject: [PATCH 4/6] fix commit ID

---
 .github/workflows/build-windows.yml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml
index 7a6bc7bf..97af63c1 100644
--- a/.github/workflows/build-windows.yml
+++ b/.github/workflows/build-windows.yml
@@ -388,9 +388,8 @@ jobs:
 
       - name: Get short SHA
         id: short_sha
-        # Use bash so ${GITHUB_SHA::7} substring syntax works on Windows runners
         shell: bash
-        run: echo "short_sha=${GITHUB_SHA::7}" >> $GITHUB_OUTPUT
+        run: echo "short_sha=${github.event.pull_request.head.sha::7}" >> $GITHUB_OUTPUT
 
       - name: Comment PR with artifact link
         if: github.event_name == 'pull_request'

From a9ed883bd398630c32aad8c7b5f5cd73aa787b86 Mon Sep 17 00:00:00 2001
From: Julien Staub <atsju2@yahoo.fr>
Date: Sun, 9 Nov 2025 10:46:45 +0100
Subject: [PATCH 5/6] fix

---
 .github/workflows/build-windows.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml
index 97af63c1..bd9da9ab 100644
--- a/.github/workflows/build-windows.yml
+++ b/.github/workflows/build-windows.yml
@@ -389,7 +389,7 @@ jobs:
       - name: Get short SHA
         id: short_sha
         shell: bash
-        run: echo "short_sha=${github.event.pull_request.head.sha::7}" >> $GITHUB_OUTPUT
+        run: echo "short_sha=${{github.event.pull_request.head.sha::7}}" >> $GITHUB_OUTPUT
 
       - name: Comment PR with artifact link
         if: github.event_name == 'pull_request'

From 9057a5789a9bc746118ea3e1890b4073ac8b8c61 Mon Sep 17 00:00:00 2001
From: Julien Staub <atsju2@yahoo.fr>
Date: Sun, 9 Nov 2025 10:59:33 +0100
Subject: [PATCH 6/6] fix

---
 .github/workflows/build-windows.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml
index bd9da9ab..07aed21e 100644
--- a/.github/workflows/build-windows.yml
+++ b/.github/workflows/build-windows.yml
@@ -389,7 +389,9 @@ jobs:
       - name: Get short SHA
         id: short_sha
         shell: bash
-        run: echo "short_sha=${{github.event.pull_request.head.sha::7}}" >> $GITHUB_OUTPUT
+        run: |
+          SHA="${{ github.event.pull_request.head.sha }}"
+          echo "short_sha=${SHA::7}" >> $GITHUB_OUTPUT
 
       - name: Comment PR with artifact link
         if: github.event_name == 'pull_request'