From fca0767abc994a0cdac93fa78cb8b5850bea6b83 Mon Sep 17 00:00:00 2001
From: Adam Setch <adam.setch@outlook.com>
Date: Fri, 27 Sep 2024 09:51:13 -0700
Subject: [PATCH] refactor: use sentence case for interaction (#1558)

* refactor: rename `Done` and `Read` to `done` and `read`

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* refactor: mark repository sentence case

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>
---
 src/components/NotificationRow.test.tsx       |  4 +-
 src/components/NotificationRow.tsx            |  4 +-
 .../RepositoryNotifications.test.tsx          |  4 +-
 src/components/RepositoryNotifications.tsx    |  4 +-
 .../AccountNotifications.test.tsx.snap        | 32 +++++------
 .../NotificationRow.test.tsx.snap             | 48 ++++++++--------
 .../RepositoryNotifications.test.tsx.snap     | 56 +++++++++----------
 .../settings/NotificationSettings.tsx         |  4 +-
 src/utils/helpers.ts                          |  2 +-
 9 files changed, 79 insertions(+), 79 deletions(-)

diff --git a/src/components/NotificationRow.test.tsx b/src/components/NotificationRow.test.tsx
index da8813b4c..8432db2ae 100644
--- a/src/components/NotificationRow.test.tsx
+++ b/src/components/NotificationRow.test.tsx
@@ -204,7 +204,7 @@ describe('components/NotificationRow.tsx', () => {
         </AppContext.Provider>,
       );
 
-      fireEvent.click(screen.getByTitle('Mark as Read'));
+      fireEvent.click(screen.getByTitle('Mark as read'));
       expect(markNotificationRead).toHaveBeenCalledTimes(1);
     });
 
@@ -224,7 +224,7 @@ describe('components/NotificationRow.tsx', () => {
         </AppContext.Provider>,
       );
 
-      fireEvent.click(screen.getByTitle('Mark as Done'));
+      fireEvent.click(screen.getByTitle('Mark as done'));
       expect(markNotificationDone).toHaveBeenCalledTimes(1);
     });
 
diff --git a/src/components/NotificationRow.tsx b/src/components/NotificationRow.tsx
index 1f0752f22..c5299372c 100644
--- a/src/components/NotificationRow.tsx
+++ b/src/components/NotificationRow.tsx
@@ -131,7 +131,7 @@ export const NotificationRow: FC<INotificationRow> = ({
         <HoverGroup>
           {isMarkAsDoneFeatureSupported(notification.account) && (
             <InteractionButton
-              title="Mark as Done"
+              title="Mark as done"
               icon={CheckIcon}
               size={Size.MEDIUM}
               onClick={() => {
@@ -142,7 +142,7 @@ export const NotificationRow: FC<INotificationRow> = ({
             />
           )}
           <InteractionButton
-            title="Mark as Read"
+            title="Mark as read"
             icon={ReadIcon}
             size={Size.SMALL}
             onClick={() => {
diff --git a/src/components/RepositoryNotifications.test.tsx b/src/components/RepositoryNotifications.test.tsx
index 635463ff2..c2bbf92c6 100644
--- a/src/components/RepositoryNotifications.test.tsx
+++ b/src/components/RepositoryNotifications.test.tsx
@@ -64,7 +64,7 @@ describe('components/RepositoryNotifications.tsx', () => {
       </AppContext.Provider>,
     );
 
-    fireEvent.click(screen.getByTitle('Mark Repository as Read'));
+    fireEvent.click(screen.getByTitle('Mark repository as read'));
 
     expect(markRepoNotificationsRead).toHaveBeenCalledWith(
       mockSingleNotification,
@@ -80,7 +80,7 @@ describe('components/RepositoryNotifications.tsx', () => {
       </AppContext.Provider>,
     );
 
-    fireEvent.click(screen.getByTitle('Mark Repository as Done'));
+    fireEvent.click(screen.getByTitle('Mark repository as done'));
 
     expect(markRepoNotificationsDone).toHaveBeenCalledWith(
       mockSingleNotification,
diff --git a/src/components/RepositoryNotifications.tsx b/src/components/RepositoryNotifications.tsx
index c07baa892..fa5604432 100644
--- a/src/components/RepositoryNotifications.tsx
+++ b/src/components/RepositoryNotifications.tsx
@@ -83,7 +83,7 @@ export const RepositoryNotifications: FC<IRepositoryNotifications> = ({
           <HoverGroup>
             {isMarkAsDoneFeatureSupported(repoNotifications[0].account) && (
               <InteractionButton
-                title="Mark Repository as Done"
+                title="Mark repository as done"
                 icon={CheckIcon}
                 size={Size.MEDIUM}
                 onClick={(event: MouseEvent<HTMLElement>) => {
@@ -96,7 +96,7 @@ export const RepositoryNotifications: FC<IRepositoryNotifications> = ({
               />
             )}
             <InteractionButton
-              title="Mark Repository as Read"
+              title="Mark repository as read"
               icon={ReadIcon}
               size={Size.SMALL}
               onClick={(event: MouseEvent<HTMLElement>) => {
diff --git a/src/components/__snapshots__/AccountNotifications.test.tsx.snap b/src/components/__snapshots__/AccountNotifications.test.tsx.snap
index 51ee5543b..6334f5343 100644
--- a/src/components/__snapshots__/AccountNotifications.test.tsx.snap
+++ b/src/components/__snapshots__/AccountNotifications.test.tsx.snap
@@ -611,11 +611,11 @@ exports[`components/AccountNotifications.tsx should render itself - group notifi
         >
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark as Done"
+            title="Mark as done"
             type="button"
           >
             <svg
-              aria-label="Mark as Done"
+              aria-label="Mark as done"
               class="octicon octicon-check"
               fill="currentColor"
               focusable="false"
@@ -632,11 +632,11 @@ exports[`components/AccountNotifications.tsx should render itself - group notifi
           </button>
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark as Read"
+            title="Mark as read"
             type="button"
           >
             <svg
-              aria-label="Mark as Read"
+              aria-label="Mark as read"
               class="octicon octicon-read"
               fill="currentColor"
               focusable="false"
@@ -774,11 +774,11 @@ exports[`components/AccountNotifications.tsx should render itself - group notifi
         >
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark as Done"
+            title="Mark as done"
             type="button"
           >
             <svg
-              aria-label="Mark as Done"
+              aria-label="Mark as done"
               class="octicon octicon-check"
               fill="currentColor"
               focusable="false"
@@ -795,11 +795,11 @@ exports[`components/AccountNotifications.tsx should render itself - group notifi
           </button>
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark as Read"
+            title="Mark as read"
             type="button"
           >
             <svg
-              aria-label="Mark as Read"
+              aria-label="Mark as read"
               class="octicon octicon-read"
               fill="currentColor"
               focusable="false"
@@ -1097,11 +1097,11 @@ exports[`components/AccountNotifications.tsx should render itself - group notifi
       >
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark as Done"
+          title="Mark as done"
           type="button"
         >
           <svg
-            aria-label="Mark as Done"
+            aria-label="Mark as done"
             class="octicon octicon-check"
             fill="currentColor"
             focusable="false"
@@ -1118,11 +1118,11 @@ exports[`components/AccountNotifications.tsx should render itself - group notifi
         </button>
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark as Read"
+          title="Mark as read"
           type="button"
         >
           <svg
-            aria-label="Mark as Read"
+            aria-label="Mark as read"
             class="octicon octicon-read"
             fill="currentColor"
             focusable="false"
@@ -1260,11 +1260,11 @@ exports[`components/AccountNotifications.tsx should render itself - group notifi
       >
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark as Done"
+          title="Mark as done"
           type="button"
         >
           <svg
-            aria-label="Mark as Done"
+            aria-label="Mark as done"
             class="octicon octicon-check"
             fill="currentColor"
             focusable="false"
@@ -1281,11 +1281,11 @@ exports[`components/AccountNotifications.tsx should render itself - group notifi
         </button>
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark as Read"
+          title="Mark as read"
           type="button"
         >
           <svg
-            aria-label="Mark as Read"
+            aria-label="Mark as read"
             class="octicon octicon-read"
             fill="currentColor"
             focusable="false"
diff --git a/src/components/__snapshots__/NotificationRow.test.tsx.snap b/src/components/__snapshots__/NotificationRow.test.tsx.snap
index 83c13cb35..4dd045ee9 100644
--- a/src/components/__snapshots__/NotificationRow.test.tsx.snap
+++ b/src/components/__snapshots__/NotificationRow.test.tsx.snap
@@ -145,11 +145,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
         >
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark as Done"
+            title="Mark as done"
             type="button"
           >
             <svg
-              aria-label="Mark as Done"
+              aria-label="Mark as done"
               class="octicon octicon-check"
               fill="currentColor"
               focusable="false"
@@ -166,11 +166,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
           </button>
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark as Read"
+            title="Mark as read"
             type="button"
           >
             <svg
-              aria-label="Mark as Read"
+              aria-label="Mark as read"
               class="octicon octicon-read"
               fill="currentColor"
               focusable="false"
@@ -351,11 +351,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
       >
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark as Done"
+          title="Mark as done"
           type="button"
         >
           <svg
-            aria-label="Mark as Done"
+            aria-label="Mark as done"
             class="octicon octicon-check"
             fill="currentColor"
             focusable="false"
@@ -372,11 +372,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
         </button>
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark as Read"
+          title="Mark as read"
           type="button"
         >
           <svg
-            aria-label="Mark as Read"
+            aria-label="Mark as read"
             class="octicon octicon-read"
             fill="currentColor"
             focusable="false"
@@ -597,11 +597,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
         >
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark as Done"
+            title="Mark as done"
             type="button"
           >
             <svg
-              aria-label="Mark as Done"
+              aria-label="Mark as done"
               class="octicon octicon-check"
               fill="currentColor"
               focusable="false"
@@ -618,11 +618,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
           </button>
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark as Read"
+            title="Mark as read"
             type="button"
           >
             <svg
-              aria-label="Mark as Read"
+              aria-label="Mark as read"
               class="octicon octicon-read"
               fill="currentColor"
               focusable="false"
@@ -786,11 +786,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
       >
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark as Done"
+          title="Mark as done"
           type="button"
         >
           <svg
-            aria-label="Mark as Done"
+            aria-label="Mark as done"
             class="octicon octicon-check"
             fill="currentColor"
             focusable="false"
@@ -807,11 +807,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - gr
         </button>
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark as Read"
+          title="Mark as read"
           type="button"
         >
           <svg
-            aria-label="Mark as Read"
+            aria-label="Mark as read"
             class="octicon octicon-read"
             fill="currentColor"
             focusable="false"
@@ -1032,11 +1032,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - hi
         >
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark as Done"
+            title="Mark as done"
             type="button"
           >
             <svg
-              aria-label="Mark as Done"
+              aria-label="Mark as done"
               class="octicon octicon-check"
               fill="currentColor"
               focusable="false"
@@ -1053,11 +1053,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - hi
           </button>
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark as Read"
+            title="Mark as read"
             type="button"
           >
             <svg
-              aria-label="Mark as Read"
+              aria-label="Mark as read"
               class="octicon octicon-read"
               fill="currentColor"
               focusable="false"
@@ -1221,11 +1221,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - hi
       >
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark as Done"
+          title="Mark as done"
           type="button"
         >
           <svg
-            aria-label="Mark as Done"
+            aria-label="Mark as done"
             class="octicon octicon-check"
             fill="currentColor"
             focusable="false"
@@ -1242,11 +1242,11 @@ exports[`components/NotificationRow.tsx should render itself & its children - hi
         </button>
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark as Read"
+          title="Mark as read"
           type="button"
         >
           <svg
-            aria-label="Mark as Read"
+            aria-label="Mark as read"
             class="octicon octicon-read"
             fill="currentColor"
             focusable="false"
diff --git a/src/components/__snapshots__/RepositoryNotifications.test.tsx.snap b/src/components/__snapshots__/RepositoryNotifications.test.tsx.snap
index 92cd56027..7c50de6cf 100644
--- a/src/components/__snapshots__/RepositoryNotifications.test.tsx.snap
+++ b/src/components/__snapshots__/RepositoryNotifications.test.tsx.snap
@@ -27,11 +27,11 @@ exports[`components/RepositoryNotifications.tsx should render itself & its child
         >
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark Repository as Done"
+            title="Mark repository as done"
             type="button"
           >
             <svg
-              aria-label="Mark Repository as Done"
+              aria-label="Mark repository as done"
               class="octicon octicon-check"
               fill="currentColor"
               focusable="false"
@@ -48,11 +48,11 @@ exports[`components/RepositoryNotifications.tsx should render itself & its child
           </button>
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark Repository as Read"
+            title="Mark repository as read"
             type="button"
           >
             <svg
-              aria-label="Mark Repository as Read"
+              aria-label="Mark repository as read"
               class="octicon octicon-read"
               fill="currentColor"
               focusable="false"
@@ -121,11 +121,11 @@ exports[`components/RepositoryNotifications.tsx should render itself & its child
       >
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark Repository as Done"
+          title="Mark repository as done"
           type="button"
         >
           <svg
-            aria-label="Mark Repository as Done"
+            aria-label="Mark repository as done"
             class="octicon octicon-check"
             fill="currentColor"
             focusable="false"
@@ -142,11 +142,11 @@ exports[`components/RepositoryNotifications.tsx should render itself & its child
         </button>
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark Repository as Read"
+          title="Mark repository as read"
           type="button"
         >
           <svg
-            aria-label="Mark Repository as Read"
+            aria-label="Mark repository as read"
             class="octicon octicon-read"
             fill="currentColor"
             focusable="false"
@@ -281,11 +281,11 @@ exports[`components/RepositoryNotifications.tsx should toggle repository notific
         >
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark Repository as Done"
+            title="Mark repository as done"
             type="button"
           >
             <svg
-              aria-label="Mark Repository as Done"
+              aria-label="Mark repository as done"
               class="octicon octicon-check"
               fill="currentColor"
               focusable="false"
@@ -302,11 +302,11 @@ exports[`components/RepositoryNotifications.tsx should toggle repository notific
           </button>
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark Repository as Read"
+            title="Mark repository as read"
             type="button"
           >
             <svg
-              aria-label="Mark Repository as Read"
+              aria-label="Mark repository as read"
               class="octicon octicon-read"
               fill="currentColor"
               focusable="false"
@@ -377,11 +377,11 @@ exports[`components/RepositoryNotifications.tsx should toggle repository notific
         >
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark Repository as Done"
+            title="Mark repository as done"
             type="button"
           >
             <svg
-              aria-label="Mark Repository as Done"
+              aria-label="Mark repository as done"
               class="octicon octicon-check"
               fill="currentColor"
               focusable="false"
@@ -398,11 +398,11 @@ exports[`components/RepositoryNotifications.tsx should toggle repository notific
           </button>
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark Repository as Read"
+            title="Mark repository as read"
             type="button"
           >
             <svg
-              aria-label="Mark Repository as Read"
+              aria-label="Mark repository as read"
               class="octicon octicon-read"
               fill="currentColor"
               focusable="false"
@@ -480,11 +480,11 @@ exports[`components/RepositoryNotifications.tsx should toggle repository notific
       >
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark Repository as Done"
+          title="Mark repository as done"
           type="button"
         >
           <svg
-            aria-label="Mark Repository as Done"
+            aria-label="Mark repository as done"
             class="octicon octicon-check"
             fill="currentColor"
             focusable="false"
@@ -501,11 +501,11 @@ exports[`components/RepositoryNotifications.tsx should toggle repository notific
         </button>
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark Repository as Read"
+          title="Mark repository as read"
           type="button"
         >
           <svg
-            aria-label="Mark Repository as Read"
+            aria-label="Mark repository as read"
             class="octicon octicon-read"
             fill="currentColor"
             focusable="false"
@@ -640,11 +640,11 @@ exports[`components/RepositoryNotifications.tsx should use default repository ic
         >
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark Repository as Done"
+            title="Mark repository as done"
             type="button"
           >
             <svg
-              aria-label="Mark Repository as Done"
+              aria-label="Mark repository as done"
               class="octicon octicon-check"
               fill="currentColor"
               focusable="false"
@@ -661,11 +661,11 @@ exports[`components/RepositoryNotifications.tsx should use default repository ic
           </button>
           <button
             class="h-full hover:text-green-500 focus:outline-none"
-            title="Mark Repository as Read"
+            title="Mark repository as read"
             type="button"
           >
             <svg
-              aria-label="Mark Repository as Read"
+              aria-label="Mark repository as read"
               class="octicon octicon-read"
               fill="currentColor"
               focusable="false"
@@ -743,11 +743,11 @@ exports[`components/RepositoryNotifications.tsx should use default repository ic
       >
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark Repository as Done"
+          title="Mark repository as done"
           type="button"
         >
           <svg
-            aria-label="Mark Repository as Done"
+            aria-label="Mark repository as done"
             class="octicon octicon-check"
             fill="currentColor"
             focusable="false"
@@ -764,11 +764,11 @@ exports[`components/RepositoryNotifications.tsx should use default repository ic
         </button>
         <button
           class="h-full hover:text-green-500 focus:outline-none"
-          title="Mark Repository as Read"
+          title="Mark repository as read"
           type="button"
         >
           <svg
-            aria-label="Mark Repository as Read"
+            aria-label="Mark repository as read"
             class="octicon octicon-read"
             fill="currentColor"
             focusable="false"
diff --git a/src/components/settings/NotificationSettings.tsx b/src/components/settings/NotificationSettings.tsx
index 056a85b9b..6c8afc152 100644
--- a/src/components/settings/NotificationSettings.tsx
+++ b/src/components/settings/NotificationSettings.tsx
@@ -78,7 +78,7 @@ export const NotificationSettings: FC = () => {
         }
         tooltip={
           <div>
-            <strong>Mark as Done</strong> feature is supported in GitHub Cloud
+            <strong>Mark as done</strong> feature is supported in GitHub Cloud
             and GitHub Enterprise Server 3.13 or later.
           </div>
         }
@@ -92,7 +92,7 @@ export const NotificationSettings: FC = () => {
         }
         tooltip={
           <div>
-            <strong>Mark as Done</strong> feature is supported in GitHub Cloud
+            <strong>Mark as done</strong> feature is supported in GitHub Cloud
             and GitHub Enterprise Server 3.13 or later.
           </div>
         }
diff --git a/src/utils/helpers.ts b/src/utils/helpers.ts
index 59c5ff231..6f81194ff 100644
--- a/src/utils/helpers.ts
+++ b/src/utils/helpers.ts
@@ -24,7 +24,7 @@ export function isEnterpriseServerHost(hostname: Hostname): boolean {
 
 export function isMarkAsDoneFeatureSupported(account: Account): boolean {
   if (isEnterpriseServerHost(account.hostname)) {
-    // Support for "Mark as Done" was added to GitHub Enterprise Server in v3.13 or newer
+    // Support for "Mark as done" was added to GitHub Enterprise Server in v3.13 or newer
     if (account.version) {
       const version = account?.version.split('.').map(Number);
       return version[0] >= 3 && version[1] >= 13;