-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken avatar on GHE (again) #1224
Comments
thanks for reporting @LunaticMuch so to confirm, the avatar url returns a valid image, but renders as broken 🤔 |
Yes. I checked the code, the console, but I can get my head around it. I only suspected the cookie, but also I cannot see the "relationship" |
Puzzling indeed... together I'm sure we'll get to the bottom of it 🤝 Any chance you are able to run gitify from the source code to see if that has the same issue? 🤞
|
I also wonder whether there's a network request for the image at all? Maybe there's a security policy that prevents the loading, for instance. Would need @LunaticMuch to check that, I don't have GHE to try to repro |
@setchy and @bmulholland I can definitely help... give me a bit, feels more a debug I need to squeeze after work 😄 |
absolutely! thank you again @LunaticMuch 🙇 |
First debug session, following your guidance @setchy
|
Looks like you have |
The default icons used for workflows (and as a default when no avatar available) are from the primer/octicons package |
Perhaps a fix lies in setting the crossorigin attribute on the img tags... https://www.geeksforgeeks.org/how-to-allow-cross-origin-use-of-images-and-canvas/ @LunaticMuch - when you said these urls load in a new tab, was that in an incognito/private or a regular instance? |
@LunaticMuch - just wanted to confirm if you're still experiencing this issue? |
Closing as stale. Happy to reopen if others report more details to help triage |
I can confirm the issue still occurs as of today |
@mislavperi - are you able to share further details please, such as Gitify version, GitHub account type(s), OS type. Any log screenshots would also be useful (via Developer Tools network console or app log file) |
@setchy Yes I'll get you those today |
Perfect! I've also been wondering if these broken avatars also occur on this feature branch which uses the official GitHub Primer avatar components |
🔍 Is there already an issue for your problem?
📝 Description
In a GHE situation, avatars for users are broken.
This seems similar to #564 but in fact is not.
Looking at the inspector tab, the
src
for the image is correctly populated and points a valid image if I open it from my browser.Incidentally, I have an amount of warnings as
Whether that's the real problem or not...I am yet to understand. I cannot find any other error.
🪜 Steps To Reproduce
Gitify Version
5.7.0
Operating System
macOS
GitHub Account
GitHub Enterprise
📸 Screenshots
The text was updated successfully, but these errors were encountered: