Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-unsub of merged/closed PRs #1317

Closed
1 task done
y-nk opened this issue Jun 27, 2024 · 6 comments
Closed
1 task done

Auto-unsub of merged/closed PRs #1317

y-nk opened this issue Jun 27, 2024 · 6 comments
Labels
enhancement New feature or enhancement to existing functionality

Comments

@y-nk
Copy link

y-nk commented Jun 27, 2024

πŸ“ Provide a description of the new feature

In the setting, there should be a checkbox to enable the feature. When enabled, the feature should auto-unsubscribe PRs which have been merged or closed automatically.

βž• Additional Information

I understand this is a bit on the edge of gitify, so i wouldn't be surprised it it's rejected. That being said, the frequent pull mechanism of notifications + the existing "unsubscribe" button looks like making it a cheap feature to implement.

  • I'm willing to help and implement the feature if agreed on the scope.
@y-nk y-nk added the enhancement New feature or enhancement to existing functionality label Jun 27, 2024
@bmulholland
Copy link
Collaborator

Yeah, this feels outside the project's goals to me :)

https://github.com/gitify-app/gitify/blob/main/CONTRIBUTING.md#project-philosophy

@setchy
Copy link
Member

setchy commented Jun 27, 2024

@y-nk have you seen our upcoming filters feature - #1304?

Perhaps filtering on notification type and/or state could be a middle ground?

Otherwise, I guess we do have all the buildings blocks. Not too different from "Mark as done on ...", except the trigger is on fetch

@y-nk
Copy link
Author

y-nk commented Jun 27, 2024

@setchy it's gonna help on the ui level but i'll be frank this is clearly for the sake of maintaining a clean state at GitHub level. I'd love to have submitted this to them directly but the chances they ever see my feat request are already lower than low ; chances to have them backlog it, prioritize it, implemented and released... well... let's put it nicely: it's a big organisation.

Since i use Gitify since about forever i thought it'd be a great place to get this done ; I'm sure some user would love it (probably the same who use the unsub button). I know the team is smaller and friendlier, so at least I got an audience ✌️ but yeah, the unsubscribe button was already at the edge, having automation around it seems pushing this edge another mile above scope πŸ₯²

thanks for considering anyhow @bmulholland πŸ™

@afonsojramos
Copy link
Member

@y-nk Unless we create a sort of "automations" section, I agree with @bmulholland. Might be an idea for the future. But not sure if there are enough useful automations to justify such a thing.

I'd definitely opt out of this one though. What if someone wants to re-spark a conversation on an old PR (even though it might not be the best place for it)?

@setchy
Copy link
Member

setchy commented Jun 28, 2024

@setchy it's gonna help on the ui level but i'll be frank this is clearly for the sake of maintaining a clean state at GitHub level.

πŸ˜„ I thought that might be your answer (I'd have answered the same way, too πŸ˜‰)

@y-nk
Copy link
Author

y-nk commented Jul 1, 2024

@afonsojramos indeed an automation would be nice. tbh if automation is there, i'd rather have Github implement "user based triggers" in GHA, but this is definitely off-topic :D

I'll close this as there's no further debate imho. I thought that proposing to implement it all would have been enough appeal to include this as "it's a 0 cost feature" but I understand your standpoint that is not in the roadmap or interest of the app overall.

Thanks for the time spent on this πŸ™

@y-nk y-nk closed this as completed Jul 1, 2024
@setchy setchy reopened this Jul 1, 2024
@setchy setchy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants