Skip to content

Commit

Permalink
fix(editissuecomment, textinput): Fix height rendering for Android (#428
Browse files Browse the repository at this point in the history
)
  • Loading branch information
Houssein Djirdeh authored Oct 4, 2017
1 parent 5ed6dfc commit 775a9c0
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/issue/screens/edit-issue-comment.screen.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { editIssueBody, editIssueComment } from '../issue.action';

const styles = StyleSheet.create({
textInput: {
maxHeight: Dimensions.get('window').height / 2,
paddingVertical: 10,
fontSize: normalize(12),
marginHorizontal: 15,
Expand Down Expand Up @@ -116,7 +115,13 @@ class EditIssueComment extends Component {
issueCommentHeight: event.nativeEvent.contentSize.height,
})}
placeholderTextColor={colors.grey}
style={styles.textInput}
style={[
styles.textInput,
{
height: this.state.issueCommentHeight,
maxHeight: Dimensions.get('window').height / 2,
},
]}
value={issueComment}
/>
</SectionList>
Expand Down

3 comments on commit 775a9c0

@lex111
Copy link
Member

@lex111 lex111 commented on 775a9c0 Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@housseindjirdeh Will the app be updated on Google Play?

@housseindjirdeh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already is @lex111 :)

@lex111
Copy link
Member

@lex111 lex111 commented on 775a9c0 Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@housseindjirdeh did not see at once, but in package.json why the version is not updated?

Please sign in to comment.