Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this okay that you validate on test set? #25

Open
BorisLestsov opened this issue Jun 1, 2019 · 1 comment
Open

Is this okay that you validate on test set? #25

BorisLestsov opened this issue Jun 1, 2019 · 1 comment

Comments

@BorisLestsov
Copy link

val_set = UCF_QNRF(cfg.DATA.DATA_PATH+'/test', 'test', main_transform=val_main_transform, img_transform=img_transform, gt_transform=gt_transform)
- here validation set is created from test set of UCF_QNRF. Is this okay?

@gjy3035
Copy link
Owner

gjy3035 commented Jun 2, 2019

we will add the following description:
In this code, the validation is directly on the test set. Strictly speaking, it is evaluated on the val set (randomly selected from the training set, which is adopted in the paper). Here, for a comparable reproduction (namely fixed splitting sets), this code directly adopts the test set for validation, which causes that the results of this code are better than that of our paper.
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants