Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all functions with trapz in the name to trapezoid in line with NumPy v2 #384

Closed
paddyroddy opened this issue Oct 25, 2024 · 0 comments · Fixed by #392
Closed

Change all functions with trapz in the name to trapezoid in line with NumPy v2 #384

paddyroddy opened this issue Oct 25, 2024 · 0 comments · Fixed by #392
Assignees
@paddyroddy
Labels
api An (incompatible) API change blocked The issue or pull request is blocked by something enhancement New feature or request

Comments

@paddyroddy
Copy link
Member

Is Your Feature Request Related to a Problem? Please Describe

As part of #163 we will have to change all uses of np.trapz to np.trapezoid, it would make sense to change the functions like cumtrapz to cumtrapezoid etc.

Describe the Solution You'd Like

No response

Describe Alternatives You've Considered

No response

Additional Context

No response
@paddyroddy paddyroddy added api An (incompatible) API change enhancement New feature or request labels Oct 25, 2024
@paddyroddy paddyroddy self-assigned this Oct 30, 2024
@paddyroddy paddyroddy mentioned this issue Oct 30, 2024
Merged
@paddyroddy paddyroddy added the blocked The issue or pull request is blocked by something label Oct 30, 2024
@paddyroddy paddyroddy linked a pull request Oct 30, 2024 that will close this issue
gh-384: rename all internal functions to trapezoid over trapz #392
Merged
paddyroddy added a commit that referenced this issue Nov 20, 2024
@paddyroddy @pre-commit-ci
gh-384: rename all internal functions to trapezoid over trapz (#392)
15e6847 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Saransh-cpp pushed a commit that referenced this issue Nov 26, 2024
@paddyroddy @pre-commit-ci @Saransh-cpp
gh-384: rename all internal functions to trapezoid over trapz (#392)
150398f 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
api An (incompatible) API change blocked The issue or pull request is blocked by something enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-384: rename all internal functions to trapezoid over trapz glass-dev/glass
1 participant
@paddyroddy