Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scipy dependency in test_array #440

Closed
paddyroddy opened this issue Nov 20, 2024 · 0 comments · Fixed by #462
Closed

Remove scipy dependency in test_array #440

paddyroddy opened this issue Nov 20, 2024 · 0 comments · Fixed by #462
Assignees
@Saransh-cpp
Labels
dependencies Pull requests that update a dependency file testing Work is related to testing

Comments

@paddyroddy
Copy link
Member

I just realised that I thought we were testing the cumulative trapezoid by chopping the array down to 1, 2, 3, ... elements, not scipy. Maybe a change for the future to get rid of that dependency.

Originally posted by @ntessore in #392 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Saransh-cpp Saransh-cpp

Labels
dependencies Pull requests that update a dependency file testing Work is related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-440: remove scipy as a test dependency glass-dev/glass
2 participants
@paddyroddy @Saransh-cpp