Add type annotation to main in new project template #4326
Conversation
compiler-cli/src/new/tests.rs
Outdated
| } | ||
| }); | ||
|
|
||
| insta::glob!(&path, "my_project/**/*.gleam", |file_path| { |
There was a problem hiding this comment.
Sorry, what has this file been changed for?
There was a problem hiding this comment.
The existing snapshot tests only test the files at the top-level of the generated project. That means neither src/<my_project>.gleam nor test/<my_project>.gleam had a test around their content. Given that I was updating one of those files, I figured having a snapshot test would be valuable. Let me know if you'd prefer I remove this change.
There was a problem hiding this comment.
I see! Could you change the pattern please rather than copying the code twice with 2 different patterns 🙏
There was a problem hiding this comment.
Done. Note that I'm excluding hidden directories so that we don't look at contents within .git.
drewolson
force-pushed
the
new-project-main-annotation
branch
from
d9ec3ec to
9a35396
Compare
Done. |
drewolson
force-pushed
the
new-project-main-annotation
branch
2 times, most recently
from
95a8f4c to
72944dd
Compare
| import gleeunit/should | ||
|
|
||
| pub fn main() { | ||
| gleeunit.main() |
There was a problem hiding this comment.
Return annotation on the test main function too please 🙏
drewolson
force-pushed
the
new-project-main-annotation
branch
from
72944dd to
c89844f
Compare
This PR adds an annotation of
-> Nilto themainfunction created by thegleam newcommand. It also adds the same annotation to themainfunction inthe generated
README.mdfile.I've added new snapshot tests for all
*.gleamfiles created in both the erlangand javascript templates.
Fixes #4313