From 91dbdf23bb564588aa2b2cd4f16fc1889e85966c Mon Sep 17 00:00:00 2001 From: GearsDatapacks Date: Tue, 3 Dec 2024 10:50:26 +0000 Subject: [PATCH 1/2] Fix nested tuple access bug --- CHANGELOG.md | 4 +++ compiler-core/src/parse/lexer.rs | 5 ++- ...s__nested_tuple_access_after_function.snap | 36 +++++++++++++++++++ compiler-core/src/parse/tests.rs | 8 +++++ 4 files changed, 50 insertions(+), 3 deletions(-) create mode 100644 compiler-core/src/parse/snapshots/gleam_core__parse__tests__nested_tuple_access_after_function.snap diff --git a/CHANGELOG.md b/CHANGELOG.md index e9677a04701..691a688144f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -214,6 +214,10 @@ not emit a warning if an @external function had been referenced. ([Richard Viney](https://github.com/richard-viney)) +- Fixed a bug where nested tuple access would not be parsed correctly when + the left-hand side was a function call. + ([Surya Rose](https://github.com/GearsDatapacks)) + ## v1.6.1 - 2024-11-19 ### Bug fixed diff --git a/compiler-core/src/parse/lexer.rs b/compiler-core/src/parse/lexer.rs index bc14cf61e1e..004a71bc48e 100644 --- a/compiler-core/src/parse/lexer.rs +++ b/compiler-core/src/parse/lexer.rs @@ -154,7 +154,6 @@ where check_for_minus = true; let name = self.lex_name()?; self.emit(name); - self.maybe_lex_dot_access()?; } else if self.is_number_start(c, self.chr1) { check_for_minus = true; let num = self.lex_number()?; @@ -437,6 +436,7 @@ where } else { let tok_end = self.get_pos(); self.emit((tok_start, Token::Dot, tok_end)); + self.maybe_lex_dot_access()?; } } '#' => { @@ -647,8 +647,7 @@ where fn maybe_lex_dot_access(&mut self) -> Result<(), LexicalError> { // It can be nested like: `tuple.1.2.3.4` loop { - if Some('.') == self.chr0 && matches!(self.chr1, Some('0'..='9')) { - self.eat_single_char(Token::Dot); + if matches!(self.chr0, Some('0'..='9')) { let number = self.lex_int_number()?; self.emit(number); } else { diff --git a/compiler-core/src/parse/snapshots/gleam_core__parse__tests__nested_tuple_access_after_function.snap b/compiler-core/src/parse/snapshots/gleam_core__parse__tests__nested_tuple_access_after_function.snap new file mode 100644 index 00000000000..2382accddf4 --- /dev/null +++ b/compiler-core/src/parse/snapshots/gleam_core__parse__tests__nested_tuple_access_after_function.snap @@ -0,0 +1,36 @@ +--- +source: compiler-core/src/parse/tests.rs +expression: tuple().0.1 +--- +[ + Expression( + TupleIndex { + location: SrcSpan { + start: 0, + end: 11, + }, + index: 1, + tuple: TupleIndex { + location: SrcSpan { + start: 0, + end: 9, + }, + index: 0, + tuple: Call { + location: SrcSpan { + start: 0, + end: 7, + }, + fun: Var { + location: SrcSpan { + start: 0, + end: 5, + }, + name: "tuple", + }, + arguments: [], + }, + }, + }, + ), +] diff --git a/compiler-core/src/parse/tests.rs b/compiler-core/src/parse/tests.rs index b1731ee63ac..aba6632dda3 100644 --- a/compiler-core/src/parse/tests.rs +++ b/compiler-core/src/parse/tests.rs @@ -1672,3 +1672,11 @@ type Wibble { "# ); } + +#[test] +// https://github.com/gleam-lang/gleam/issues/3870 +fn nested_tuple_access_after_function() { + assert_parse!( + "tuple().0.1" + ); +} From 86f77ad5a79a69f6bc7fe4521c70e67d8babf3d6 Mon Sep 17 00:00:00 2001 From: GearsDatapacks Date: Tue, 3 Dec 2024 10:54:18 +0000 Subject: [PATCH 2/2] Format --- compiler-core/src/parse/tests.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/compiler-core/src/parse/tests.rs b/compiler-core/src/parse/tests.rs index aba6632dda3..8a6bafc54f3 100644 --- a/compiler-core/src/parse/tests.rs +++ b/compiler-core/src/parse/tests.rs @@ -1676,7 +1676,5 @@ type Wibble { #[test] // https://github.com/gleam-lang/gleam/issues/3870 fn nested_tuple_access_after_function() { - assert_parse!( - "tuple().0.1" - ); + assert_parse!("tuple().0.1"); }