diff --git a/DESCRIPTION b/DESCRIPTION index 6a692aaf..51feefac 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Package: reactable Type: Package Title: Interactive Data Tables Based on 'React Table' -Version: 0.1.0 +Version: 0.1.0.1 Authors@R: c( person("Greg", "Lin", email = "glin@glin.io", role = c("aut", "cre")), person("Tanner", "Linsley", role = c("ctb", "cph"), comment = "React Table library") diff --git a/cran-comments.md b/cran-comments.md index cc73287a..78b33bc7 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,11 +1,2 @@ -## Resubmission -This is a resubmission. In this version I have: - -* Documented return values for all functions. - -## Resubmission -This is a resubmission. In this version I have: - -* Added single quotes to package and software names in the Description. - -* Replaced `\dontrun{}` with `if (interactive()) {}` in examples. +This submission updates the tests to be compatible with R 4.0.0 using +stringsAsFactors = FALSE by default. diff --git a/tests/testthat/test-reactable.R b/tests/testthat/test-reactable.R index b61084a1..ca5b146e 100644 --- a/tests/testthat/test-reactable.R +++ b/tests/testthat/test-reactable.R @@ -61,7 +61,7 @@ test_that("reactable handles invalid args", { test_that("reactable", { # Default args - tbl <- reactable(data.frame(x = 1, y = "b")) + tbl <- reactable(data.frame(x = 1, y = "b", stringsAsFactors = TRUE)) attribs <- getAttribs(tbl) data <- data.frame(x = 1, y = "b") data <- jsonlite::toJSON(data, dataframe = "columns", rownames = FALSE) @@ -84,7 +84,7 @@ test_that("reactable", { expect_null(tbl$elementId) # Table options - tbl <- reactable(data.frame(x = "a"), rownames = TRUE, + tbl <- reactable(data.frame(x = "a", stringsAsFactors = TRUE), rownames = TRUE, columnGroups = list(colGroup("group", "x")), sortable = FALSE, resizable = TRUE, filterable = TRUE, searchable = TRUE, defaultSortOrder = "desc", defaultSorted = list(x = "asc"),