Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support to npm, yarn is better #414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

drop support to npm, yarn is better #414

wants to merge 1 commit into from

Conversation

rodrigondec
Copy link

Yarn is better at solving dependency conflicts.

By using yarn ONLY, the conflict is automagically resolved.

Related Issue

Proposed Changes

  • use yarn instead of npm
  • drop support to npm on Makefile

@rodrigondec
drop support to NPM
a4dd709 
Yarn is better at solving dependency conflicts.
@rodrigondec
Copy link
Author

At this point, the conflict is a warning on yarn. But yarn solves the problem by itself.

Should I tackle the versions to avoid the warning too?

yarn install v1.22.19
warning ../package.json: No license field
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > eslint-watch@5.1.2" has incorrect peer dependency "eslint@>=4 <6.0.0".
warning " > estraverse-fb@1.3.2" has unmet peer dependency "estraverse@*".
warning " > react-markdown@4.3.1" has incorrect peer dependency "react@^15.0.0 || ^16.0.0".
warning " > react-tap-event-plugin@3.0.3" has incorrect peer dependency "react@^16.0.0-0 < 16.4.0".
warning " > react-tap-event-plugin@3.0.3" has incorrect peer dependency "react-dom@^16.0.0-0 < 16.4.0".
warning " > react-test-renderer@16.14.0" has incorrect peer dependency "react@^16.14.0".
[4/4] Building fresh packages...
$ yarn run build
yarn run v1.22.19
warning ../package.json: No license field
$ yarn run build:lib && gulp sass && gulp sass-copy
warning ../package.json: No license field
$ babel src/ -d lib/

@rodrigondec rodrigondec changed the title drop support to NPM drop support to npm, yarn is better Oct 21, 2022
lucianapepelucio
lucianapepelucio reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@lucianapepelucio lucianapepelucio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianapepelucio lucianapepelucio lucianapepelucio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible dependency conflict
2 participants
@rodrigondec @lucianapepelucio