Merge pull request #1964 from glotzerlab/fix-pair-modulator-warning

joaander · web-flow · commit e2b20e652e24 · 2025-01-09T13:17:58.000-05:00
Fix maybe uninitialized warning in PairModulator
diff --git a/hoomd/md/PairModulator.h b/hoomd/md/PairModulator.h
@@ -144,7 +144,8 @@ template<typename PairEvaluator, typename DirectionalEnvelope> class PairModulat
                          const Scalar4& _q_j,
                          const Scalar _rcutsq,
                          const param_type& _params)
-        : dr(_dr), rsq(dot(_dr, _dr)), rcutsq(_rcutsq), q_i(_q_i), q_j(_q_j), params(_params)
+        : dr(_dr), rsq(dot(_dr, _dr)), rcutsq(_rcutsq), q_i(_q_i), q_j(_q_j), params(_params),
+          shape_i(nullptr), shape_j(nullptr), m_charge_i(0), m_charge_j(0)
         {
         }
 

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,8 @@ template<typename PairEvaluator, typename DirectionalEnvelope> class PairModulat`
`144`	`144`	`const Scalar4& _q_j,`
`145`	`145`	`const Scalar _rcutsq,`
`146`	`146`	`const param_type& _params)`
`147`		`- : dr(_dr), rsq(dot(_dr, _dr)), rcutsq(_rcutsq), q_i(_q_i), q_j(_q_j), params(_params)`
	`147`	`+ : dr(_dr), rsq(dot(_dr, _dr)), rcutsq(_rcutsq), q_i(_q_i), q_j(_q_j), params(_params),`
	`148`	`+ shape_i(nullptr), shape_j(nullptr), m_charge_i(0), m_charge_j(0)`
`148`	`149`	`{`
`149`	`150`	`}`
`150`	`151`