Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWS: incorrect representation of the quote endpoint #127

Open
vforchi opened this issue Jan 19, 2021 · 1 comment
Open

UWS: incorrect representation of the quote endpoint #127

vforchi opened this issue Jan 19, 2021 · 1 comment
Assignees
Labels

Comments

@vforchi
Copy link
Contributor

vforchi commented Jan 19, 2021

Currently the endpoint quote returns the value of the field quote in the class UWSJob, with -1 meaning no quote, but according to UWS it should return either the empty string or an ISO8601 date:

https://www.ivoa.net/documents/UWS/20161024/REC-UWS-1.1-20161024.html#Quote

/{jobs}/{job-id}/quote the Quote for {job-id} [std:iso8601] If no quote available then return empty string.
@gmantele gmantele self-assigned this Jan 19, 2021
@gmantele gmantele added the bug label Jan 19, 2021
@gmantele
Copy link
Owner

gmantele commented Jan 19, 2021

Indeed, you're right. It seems UWSLib stays at version 1.0 on this point, where the quote property was an integer (-1 when not set). In 1.1, it apparently changes and I missed that (it was not explicit either in the Appendix "A. Updates from previous versions").
I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants