Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAP resource returning HTTP-501 #129

Open
gmantele opened this issue Apr 14, 2021 · 0 comments
Open

TAP resource returning HTTP-501 #129

gmantele opened this issue Apr 14, 2021 · 0 comments
Assignees

Comments

@gmantele
Copy link
Owner

VOLLT/TAPLib intentionally returns an HTTP-501 (Not Implemented) with a VOTable document describing the error when a requested TAP resource (e.g. sync, async, examples) does not exist. This is made on purpose as VOLLT/TAPLib offers the possibility to attach additional resources behind the root TAP URL (i.e. /tap/), as any other standard resource (e.g. /tap/async, /tap/capabilities).

This situation especially applies for the optional resource Examples (i.e. /tap/examples). The problem is that TAP validators or clients check the URL directly to see if the resource exists or not, and most of them expect a 404 error being returned if not implemented. The returned 501 by VOLLT/TAPLib then generates an unexpected error on the client/validator side.

Besides, for this Examples resource, DALI explicitly requires the DALI service to return a 404 error if not implemented.

In order to follow the behavior of the other existing TAP services (and DALI for the Examples resource), VOLLT/TAPLib should now return a 404 instead of the current 501 when a TAP resource is not implemented.

@gmantele gmantele self-assigned this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant