You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Registry references are, as a whole, compared case-insensitively, and must be treated case-insensitively throughout to maintain backwards compatibility with version 1 of this specification. When comparing full IVOIDs, the local part must be split off and compared preserving case, while the registry part must be compared case-insensitively.
I think this could be fixed by just modifying the (already overridden) equals and hashcode methods in adql.parsers.feature.LanguageFeature to work with case-folded values of type.
I'm happy to write a PR on request, but I don't know whether it could cause subtle unwanted effects elsewhere.
The text was updated successfully, but these errors were encountered:
mbtaylor
added a commit
to mbtaylor/vollt
that referenced
this issue
Jul 4, 2023
Language Features currently need canonical capitalisation of the feature type in order to be recognised, for instance if I create a feature like this:
it is recognised by VOLLT as referring to the standard CIRCLE geometry function, but if I do it like this:
it's not.
This isn't strictly speaking a bug, but it goes against the rule from the IVOID 2.0 specification section 2.1:
I think this could be fixed by just modifying the (already overridden)
equals
andhashcode
methods inadql.parsers.feature.LanguageFeature
to work with case-folded values oftype
.I'm happy to write a PR on request, but I don't know whether it could cause subtle unwanted effects elsewhere.
The text was updated successfully, but these errors were encountered: