Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK v2 #199

Closed
wants to merge 315 commits into from
Closed

SDK v2 #199

wants to merge 315 commits into from

Conversation

jfschwarz
Copy link
Collaborator

@jfschwarz jfschwarz commented Apr 19, 2023

SDK design overview:
https://github.com/gnosis/zodiac-modifier-roles/blob/sdk/packages/sdk/README.md

Example for layer 2 – preset: (ABI types are manually provided for scoped parameters, no TypeScript support)
https://github.com/gnosis/zodiac-modifier-roles/blob/sdk/packages/sdk/test/karpatkey/presets/deFiManageENS1Untyped.ts

Example for layer 3 – typed allow kit: (ABI is fetched automatically, full TypeScript support)
https://github.com/gnosis/zodiac-modifier-roles/blob/sdk/packages/sdk/test/karpatkey/presets/deFiManageBalancer1TypedKit.ts

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-roles-app ❌ Failed (Inspect) Aug 30, 2023 11:04am

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nledo
Copy link
Collaborator

nledo commented Apr 19, 2023

I have read the CLA Document and I hereby sign the CLA

* former "permissions" (array of allowed targets) is now called "targets"
* former "preset allow entry" is now called "permission"
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5859987974

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 5017089347: 0.0%
Covered Lines: 663
Relevant Lines: 663

💛 - Coveralls

@jfschwarz
Copy link
Collaborator Author

superseded by #208

@jfschwarz jfschwarz closed this Aug 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
@jfschwarz jfschwarz deleted the sdk branch January 4, 2024 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants