Add Search, move Add/Upload File, delete directory & "copy path" functionality to the repo's tree view UI #35911

brymut · 2025-11-10T08:49:31Z

Summary of key changes:

Add search functionality to tree view
Add backend functionality to delete directory
Add context menu for directories with functionality to copy path & delete a directory
Move Add/Upload file dropdown to right for parity with Github UI
Add tree view to the edit/upload & patch UI
Remove redundant repo name from Apply Patch breadcrumb UI

Detailed breakdown:

1. Add search functionality to tree view

Added search to tree view using existing searchfilterRepoFilesWeighted, with new modal to display the search results. User can navigate through search results using keyboard to scroll, select and escape the search on top of using mouse. No matches found notice when no results are found.

Screen.Recording.2025-11-11.at.09.51.16.mov

2. Add backend functionality to delete directory

Modified the DeleteFilePost endpoint to also allow for deletion of whole directories to support the "Delete directory" menu option added to the context menu.

3. Add context menu for directories with functionality to copy path & delete a directory

Added context menu for "Copy path", "Copy Permalink" & "Delete directory" supported by backend change listed above.

Screen.Recording.2025-11-11.at.10.10.41.mov

4. Move Add/Upload file dropdown to right for parity with Github UI

Minor change to move this option to the right since already existed.

5. Add tree view to the edit/upload & patch UI

lunny · 2025-11-11T19:24:56Z

When creating a new file, it currently redirects to the classic “new file” page. Instead, it should open an inline editor similar to GitHub’s implementation, keeping the left tree view visible. The same behavior should apply to Upload Files and Apply Patch actions.
There is no way to add a new file for the root directory in the tree view UI.

brymut · 2025-11-12T09:07:27Z

2. There is no way to add a new file for the root directory in the tree view UI.

You can do so in the main repo page in the code tab, same as to how its done on Github. Since I'm not aware of a way to view the root directory except for in the main repo page on the code tab (same on Github). Or perhaps I'm not understanding what you mean.

brymut · 2025-11-12T10:11:56Z

When creating a new file, it currently redirects to the classic “new file” page. Instead, it should open an inline editor similar to GitHub’s implementation, keeping the left tree view visible. The same behavior should apply to Upload Files and Apply Patch actions.

Added

lunny · 2025-11-12T19:02:47Z

It seems there is a bug that the icon to show/hide tree view will always be hidden.

And maybe the commit box should be move to up right corner like what github did after the tree view introduced to the editor page.

brymut · 2025-11-13T11:12:41Z

It seems there is a bug that the icon to show/hide tree view will always be hidden.

Fixed

And maybe the commit box should be move to up right corner like what github did after the tree view introduced to the editor page.

Moved. Should be more like Github's UX now:

Screen.Recording.2025-11-13.at.14.04.46.mov

lunny · 2025-11-13T17:03:55Z

Great work!

It seems the Delete File UI needs some improvements? The close button in the top-right corner doesn’t seem to work either. Perhaps converting this into a popup dialog would provide a better experience than open in a new page.
The Apply Patch UI seems to need some improvements. There are two “Cancel” buttons and the repository name appears twice. I don’t think this issue is caused by this PR, but since it’s related, it would be better to address them together.

Creating a new file under the root folder is inconvenient because I have to return to the repository’s home page each time. I understand this behavior is inherited from GitHub, but it doesn’t seem like the best design. Could you also add buttons for Create File / Upload File / Apply Patch directly in the file view, so that new items can be created under the same folder as the currently viewed file?

brymut · 2025-11-20T15:16:54Z

I don't think the "file list" code should be in ViewFileTree, don't see any relation between them.

Sorry about that, I thought I had pushed my refactor of that. Updated.

…r search

…ove editor.

…iew and apply patch ui improvements.

…vice with testing

…ts message.

…ew component.

brymut · 2025-11-21T14:29:59Z

Rebased and had a look again with fresh eyes today. Debounced the search input and fixed an issue with scrolling while searching that I noticed. I've had a look through the changed lines and unless I've developed a blindspot to something in this PR I'm happy to sign off on it as is @wxiaoguang.

wxiaoguang · 2025-11-22T12:26:12Z

Thank you for the updates. I've been very busy lately so I am not sure when I can get time to do a full review. Meanwhile other maintainers can also review.

brymut · 2025-11-22T13:06:23Z

Thank you for the updates. I've been very busy lately so I am not sure when I can get time to do a full review. Meanwhile other maintainers can also review.

Thanks for your time on this. I appreciate it. I feel like we're pretty close here, maybe @silverwind?

brymut · 2025-11-28T21:45:40Z

Any chance you could help out with a review here since you've got good context on it @wxiaoguang? Since we've lost momentum here for a week now, I'd appreciate the help.

wxiaoguang · 2025-11-29T02:22:28Z

Any chance you could help out with a review here since you've got good context on it @wxiaoguang? Since we've lost momentum here for a week now, I'd appreciate the help.

Did a quick test, it works but it doesn't look good to me.

Misalignments: some elements have different sizes and spaces and make the UI look not good
When the left tree view is hidden, then no way to "go to file"
- GitHub shows the "go to file" on the right if the left tree view is hidden.
- Maybe it needs some methods to make the code maintainable if this would be done.
The repo home's "go to file" button becomes inconsistent with the file list page's "go to file" input
- Add Search, move Add/Upload File, delete directory & "copy path" functionality to the repo's tree view UI #35911 (comment)
- if the "go to file" list is shown on the file list page, then should the legacy "go to file" page be removed?
- GitHub also uses one consistent "go to file" input

And some of the code can be simplified to improve maintainability.

If I have time, I could help to make more changes, but at the moment I don't and am not able to promise a predictable time.

These concerns can also be considered as "nits", and I won't block if other maintainers approve and merge.

wxiaoguang · 2025-11-29T02:59:18Z

services/repository/files/delete.go

+		}
+
+		for _, e := range entries {
+			if !e.IsDir() && !e.IsSubModule() {


Why IsSubModule is skipped?

If submodule is not supported, either have a TODO comment, or fix the code to support it?

I figured the dealing with .gitmodules entries would be very complex and would introduce a whole set of issues to deal with preventing leaving the repo in a broken state, especially given the scope of this PR. And I'll be honest I'm not sure I've got the knowledge to handle submodules on this project. I'll add a TODO.

brymut · 2025-11-29T06:23:05Z

Misalignments: some elements have different sizes and spaces and make the UI look not good

Could you point me to the elements? Only found the repo-file-actions-dropdown button may have odd padding.

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 10, 2025

github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Nov 10, 2025

algora-pbc bot added the 🙋 Bounty claim label Nov 10, 2025

algora-pbc bot mentioned this pull request Nov 10, 2025

Feat Request: Add Search, move Add/Upload File, delete directory & "copy path" functionality to the repo's tree view UI #35898

Open

brymut changed the title ~~Add Search, Add/Upload File, delete directory & "copy path" functionality to the repo's tree view UI~~ Add Search, move Add/Upload File, delete directory & "copy path" functionality to the repo's tree view UI Nov 10, 2025

brymut force-pushed the feat-enhance-tree-view branch from 3452673 to 1cf0812 Compare November 10, 2025 09:58

github-actions bot added the modifies/translation label Nov 10, 2025

brymut force-pushed the feat-enhance-tree-view branch 3 times, most recently from ca8791e to 457f17f Compare November 11, 2025 03:59

github-actions bot added the modifies/go Pull requests that update Go code label Nov 11, 2025

brymut force-pushed the feat-enhance-tree-view branch 3 times, most recently from f169aa3 to 809a645 Compare November 11, 2025 07:15

brymut marked this pull request as ready for review November 11, 2025 07:20

lunny added this to the 1.26.0 milestone Nov 11, 2025

brymut force-pushed the feat-enhance-tree-view branch from 809a645 to 0adcc74 Compare November 12, 2025 10:10

brymut force-pushed the feat-enhance-tree-view branch 6 times, most recently from 4540d07 to 57782c3 Compare November 13, 2025 11:04

brymut requested a review from wxiaoguang November 20, 2025 11:27

This comment was marked as resolved.

Sign in to view

brymut force-pushed the feat-enhance-tree-view branch 4 times, most recently from 7d4a08c to 765fff3 Compare November 21, 2025 14:21

brymut added 13 commits November 21, 2025 17:23

feat(repo): Add file search functionality to repository file tree

b3fb0c3

feat(repo): add tree view context menu actions

c7120de

enhance(repo): fix overflow and scrolling on search results in sideba…

34e73a1

…r search

feat(repo): enable delete directory

0205f4c

feat(repo): Added tree view to adding new file(s) view.

541313b

enhance(repo): move commit_form to modal and commit action buttons ab…

3bdb2ba

…ove editor.

enhance(repo): move delete to modal, add files to directory in file v…

15eec6f

…iew and apply patch ui improvements.

fix: use fomanticQuery instead of jquery

dc7febe

rollback modal changes

96bf745

refactor(Repo): extract directory deletion logic into a dedicated ser…

1ed8c77

…vice with testing

refactor: Lazily load file list for tree search and localize no resul…

d359a16

…ts message.

refactor: Extract file search logic and UI from ViewFileTree into a n…

645c5d6

…ew component.

enhance: debounced input and search result scroll positioning.

140c8cf

brymut force-pushed the feat-enhance-tree-view branch from 765fff3 to 140c8cf Compare November 21, 2025 14:24

Merge branch 'main' into feat-enhance-tree-view

20b1afe

wxiaoguang reviewed Nov 29, 2025

View reviewed changes

Uh oh!

Add Search, move Add/Upload File, delete directory & "copy path" functionality to the repo's tree view UI #35911

Are you sure you want to change the base?

Add Search, move Add/Upload File, delete directory & "copy path" functionality to the repo's tree view UI #35911

Conversation

brymut commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of key changes:

Detailed breakdown:

Uh oh!

lunny commented Nov 11, 2025

Uh oh!

brymut commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brymut commented Nov 12, 2025

Uh oh!

lunny commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brymut commented Nov 13, 2025

Uh oh!

lunny commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

brymut commented Nov 20, 2025

Uh oh!

This comment was marked as resolved.

brymut commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Nov 22, 2025

Uh oh!

brymut commented Nov 22, 2025

Uh oh!

brymut commented Nov 28, 2025

Uh oh!

wxiaoguang commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

brymut Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brymut commented Nov 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brymut commented Nov 10, 2025 •

edited

Loading

brymut commented Nov 12, 2025 •

edited

Loading

lunny commented Nov 12, 2025 •

edited

Loading

lunny commented Nov 13, 2025 •

edited

Loading

brymut commented Nov 21, 2025 •

edited

Loading

wxiaoguang commented Nov 29, 2025 •

edited

Loading

brymut Nov 29, 2025 •

edited

Loading