Skip to content

Commit 201391a

Browse files
authored
Merge pull request #152 from aubelsb2/rfc6749-4-1-3-2
Rfc6749 4.1.3 - client_secret isn't required
2 parents 2fc53bb + 06c3b60 commit 201391a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

manage/manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ func (m *Manager) GenerateAccessToken(ctx context.Context, gt oauth2.GrantType,
261261
if !cliPass.VerifyPassword(tgr.ClientSecret) {
262262
return nil, errors.ErrInvalidClient
263263
}
264-
} else if tgr.ClientSecret != cli.GetSecret() {
264+
} else if len(tgr.ClientSecret) > 0 && tgr.ClientSecret != cli.GetSecret() {
265265
return nil, errors.ErrInvalidClient
266266
}
267267
if tgr.RedirectURI != "" {

server/handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ type (
4646
// ClientFormHandler get client data from form
4747
func ClientFormHandler(r *http.Request) (string, string, error) {
4848
clientID := r.Form.Get("client_id")
49-
clientSecret := r.Form.Get("client_secret")
50-
if clientID == "" || clientSecret == "" {
49+
if clientID == "" {
5150
return "", "", errors.ErrInvalidClient
5251
}
52+
clientSecret := r.Form.Get("client_secret")
5353
return clientID, clientSecret, nil
5454
}
5555

0 commit comments

Comments
 (0)