fix(dasboards): remove deleted dashboards from users list #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
==========================================
- Coverage 52.44% 52.41% -0.04%
==========================================
Files 557 557
Lines 19421 19433 +12
==========================================
Hits 10185 10185
- Misses 8670 8682 +12
Partials 566 566
|
ecrupper
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Question: do you think it's a better idea to make the user updates after the deletion of the dashboard? Say the DB call fails for whatever reason, it may be a better experience for the dashboard reference to still exist on the user object if the delete fails.
ecrupper
approved these changes
Sep 13, 2024
wass3rw3rk
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard ID's for deleted dashboards need to also be deleted from a user's dashboard list, as they would continue to count towards a user's total dashboard count otherwise.