Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-vist PD minimum buffer size calculation for LibOSDP #219

Open
sidcha opened this issue Feb 7, 2025 · 0 comments
Open

Re-vist PD minimum buffer size calculation for LibOSDP #219

sidcha opened this issue Feb 7, 2025 · 0 comments

Comments

@sidcha
Copy link
Member

sidcha commented Feb 7, 2025

Discussed in #217

Originally posted by gandraX January 20, 2025
Hi,
I implemented libsodp (CP mode) on my device and connected two readers (PD) from different manufacturers. One of them has a Receive Buffer Size of 64B, and CP is unable to send any commands to it after the osdp_CAP command.
It fails in the function osdp_phy_packet_init because of this line:
exp_len = sizeof(struct osdp_packet_header) + 64; /* 64 is estimated */

Thus, libsodp requires the PD to have more than a 64B + header buffer.
I did not find explicit minimum rx buffer requirements for PD in the standard. Are there any?

Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant