Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the technology has no effect #763

Open
oiiiiiiii opened this issue Aug 21, 2024 · 2 comments
Open

Setting the technology has no effect #763

oiiiiiiii opened this issue Aug 21, 2024 · 2 comments

Comments

@oiiiiiiii
Copy link

oiiiiiiii commented Aug 21, 2024

When creating a relationship between to elements e.g. with Uses(FCMHandler, "Sends out notifications via", "HTTP") the technology (here "HTTP") is completely ignored and not being rendered to the arrow.

grafik

C4 usually contains those in "[, ]", like "[HTTP]", see https://static.structurizr.com/workspace/76749/diagrams/Containers.png

@raphael
Copy link
Member

raphael commented Aug 21, 2024

Yeah I'd be happy to merge a PR that added the technology to the link in diagrams!

@oiiiiiiii
Copy link
Author

oiiiiiiii commented Aug 21, 2024

Unfortunately I have no idea how to set up this project to that I can't really test a modified version. I took a look at the code though and I think it could be as easy as replacing graph.addEdge(rel.id, rel.sourceId, rel.destinationId, rel.description, ref.vertices, style) in the parseModel.ts file (line 269) with something like

graph.addEdge(rel.id, rel.sourceId, rel.destinationId, rel.technology ? `${rel.description}\n[${rel.technology}]` : rel.description, ref.vertices, style)

(I replaced rel.description)
The technology property seems to be implemented everywhere, just not used for the label argument of addEdge(). But again, I didn't test it and maybe it's not as easy as I think, I am not familiar with the codebase...

Sorry for not really contributing the way you had hoped :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants