Fixes

Author: Soreepeong

Dalamud/ImGuiScene/Helpers/ImGuiViewportHelpers.cs

@@ -143,6 +143,7 @@ internal static class ImGuiViewportHelpers
     /// </summary>
     public static unsafe void EnableViewportWindowBackgroundAlpha()
     {
+        // TODO: patch imgui.cpp:6126, which disables background transparency for extra viewport windows
         var offset = 0x00007FFB6ADA632C - 0x00007FFB6AD60000;
         offset += Process.GetCurrentProcess().Modules.Cast<ProcessModule>().First(x => x.ModuleName == "cimgui.dll")
                          .BaseAddress;

Dalamud/ImGuiScene/Implementations/Dx12Renderer.Heap.cs

@@ -10,8 +10,6 @@
 using TerraFX.Interop.DirectX;
 using TerraFX.Interop.Windows;
 
-using Win32 = TerraFX.Interop.Windows.Windows;
-
 namespace Dalamud.ImGuiScene.Implementations;
 
 /// <summary>
@@ -198,9 +196,10 @@ public Heap(
 
                     fixed (Guid* piid = &IID.IID_ID3D12Heap)
                     fixed (D3D12_HEAP_DESC* pDesc = &desc)
+                    fixed (ID3D12Heap** ppHeap = &this.heap.GetPinnableReference())
                     fixed (void* pName = $"{debugName} ({Util.FormatBytes((long)desc.SizeInBytes)})")
                     {
-                        device->CreateHeap(pDesc, piid, (void**)this.heap.GetAddressOf()).ThrowHr();
+                        device->CreateHeap(pDesc, piid, (void**)ppHeap).ThrowHr();
                         this.heap.Get()->SetName((ushort*)pName).ThrowHr();
                     }
 

Dalamud/Interface/Internal/DalamudIme.cs

@@ -24,7 +24,7 @@ namespace Dalamud.Interface.Internal;
 /// <summary>
 /// This class handles CJK IME.
 /// </summary>
-[ServiceManager.EarlyLoadedService]
+[ServiceManager.BlockingEarlyLoadedService]
 internal sealed unsafe class DalamudIme : IDisposable, IServiceType
 {
     private static readonly ModuleLog Log = new("IME");
@@ -142,6 +142,7 @@ internal static bool ShowCursorInInputText
     /// </summary>
     internal char InputModeIcon { get; private set; }
 
+    // TODO: include imgui_internal.h in ImGui.NET code generator
     private static ref ImGuiInputTextState TextState => ref *(ImGuiInputTextState*)(ImGui.GetCurrentContext() + 0x4588);
 
     /// <inheritdoc/>

Dalamud/Interface/Internal/InterfaceManager.cs

@@ -26,9 +26,11 @@
 using Dalamud.Storage.Assets;
 using Dalamud.Utility;
 using Dalamud.Utility.Timing;
+
 using ImGuiNET;
-using PInvoke;
+
 using Serilog;
+
 using TerraFX.Interop.DirectX;
 using TerraFX.Interop.Windows;
 
@@ -106,10 +108,10 @@ private unsafe InterfaceManager()
         this.address = new SwapChainVtableResolver();
     }
 
-    [UnmanagedFunctionPointer(CallingConvention.ThisCall)]
+    [UnmanagedFunctionPointer(CallingConvention.StdCall)]
     private unsafe delegate HRESULT PresentDelegate(IDXGISwapChain* swapChain, uint syncInterval, uint presentFlags);
 
-    [UnmanagedFunctionPointer(CallingConvention.ThisCall)]
+    [UnmanagedFunctionPointer(CallingConvention.StdCall)]
     private unsafe delegate HRESULT ResizeBuffersDelegate(IDXGISwapChain* swapChain, uint bufferCount, uint width, uint height, uint newFormat, uint swapChainFlags);
 
     [UnmanagedFunctionPointer(CallingConvention.StdCall)]