From 61f22c305c5d172cccc63c4cefc92fb752a9505f Mon Sep 17 00:00:00 2001 From: ikjeong Date: Thu, 30 Jan 2025 20:40:51 +0900 Subject: [PATCH 1/4] Ci: remove test --- .github/workflows/build.yml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0fb80a0..61d186d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -7,22 +7,7 @@ on: - main jobs: - test: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v2 - - - name: Decrypt environment variables - run: | - echo "${{ secrets.ENV }}" base64 -d > .env - - - name: Run a test - run: | - make test-app - build: - needs: test runs-on: ubuntu-latest steps: - name: Checkout From d3bad571b9351012bf99082ae51dda9a1d7360b3 Mon Sep 17 00:00:00 2001 From: ikjeong Date: Thu, 30 Jan 2025 20:42:03 +0900 Subject: [PATCH 2/4] Ci: remove decrypting env --- .github/workflows/test.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 506eaeb..9717456 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,10 +14,6 @@ jobs: - name: Checkout uses: actions/checkout@v2 - - name: Decrypt environment variables - run: | - echo "${{ secrets.ENV }}" base64 -d > .env - - name: Run a test run: | make test-app From dabbc178feab3d739a148dee37640b2a27141ff4 Mon Sep 17 00:00:00 2001 From: ikjeong Date: Thu, 30 Jan 2025 20:47:05 +0900 Subject: [PATCH 3/4] Ci: change registry to use HTTPS --- .github/workflows/build.yml | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 61d186d..66cf0a8 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -13,36 +13,21 @@ jobs: - name: Checkout uses: actions/checkout@v2 - - name: Decrypt environment variables - run: | - echo "${{ secrets.ENV }}" base64 -d > .env - - name: Build an app run: | make build-app - - name: Set up Docker daemon to using HTTP - run: | - sudo mkdir -p /etc/docker - echo '{"insecure-registries":["${{ secrets.HARBOR_REGISTRY }}:80"]}' | sudo tee /etc/docker/daemon.json - sudo systemctl restart docker - - # Because you need to use the hostname set in the harbor, you need to use it if the domain is not assigned. - - name: Set up Harbor hostname - run: | - echo "${{ secrets.HARBOR_REGISTRY }} core.harbor.domain" | sudo tee -a /etc/hosts - - name: Login to Harbor uses: docker/login-action@v2 with: - registry: ${{ secrets.HARBOR_REGISTRY }}:80 + registry: ${{ secrets.HARBOR_REGISTRY }} username: ${{ secrets.HARBOR_USERNAME }} password: ${{ secrets.HARBOR_PASSWORD }} - name: Push Docker image to Harbor run: | - docker tag fetch-system/streams:latest ${{ secrets.HARBOR_REGISTRY }}:80/fetch-system/streams:${GITHUB_SHA::7} - docker push ${{ secrets.HARBOR_REGISTRY }}:80/fetch-system/streams:${GITHUB_SHA::7} + docker tag fetch-system/streams:latest ${{ secrets.HARBOR_REGISTRY }}/fetch-system/streams:${GITHUB_SHA::7} + docker push ${{ secrets.HARBOR_REGISTRY }}/fetch-system/streams:${GITHUB_SHA::7} kustomize: runs-on: ubuntu-latest From 2aa6bd53ff7455ef93c1428723ca59ecbafc5eb1 Mon Sep 17 00:00:00 2001 From: ikjeong Date: Thu, 30 Jan 2025 20:48:29 +0900 Subject: [PATCH 4/4] Ci: change environment variable name --- .github/workflows/build.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 66cf0a8..02d7045 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -17,17 +17,17 @@ jobs: run: | make build-app - - name: Login to Harbor + - name: Login to registry uses: docker/login-action@v2 with: - registry: ${{ secrets.HARBOR_REGISTRY }} - username: ${{ secrets.HARBOR_USERNAME }} - password: ${{ secrets.HARBOR_PASSWORD }} + registry: ${{ secrets.REGISTRY_DOMAIN }} + username: ${{ secrets.REGISTRY_USERNAME }} + password: ${{ secrets.REGISTRY_PASSWORD }} - - name: Push Docker image to Harbor + - name: Push docker image to registry run: | - docker tag fetch-system/streams:latest ${{ secrets.HARBOR_REGISTRY }}/fetch-system/streams:${GITHUB_SHA::7} - docker push ${{ secrets.HARBOR_REGISTRY }}/fetch-system/streams:${GITHUB_SHA::7} + docker tag fetch-system/streams:latest ${{ secrets.REGISTRY_DOMAIN }}/fetch-system/streams:${GITHUB_SHA::7} + docker push ${{ secrets.REGISTRY_DOMAIN }}/fetch-system/streams:${GITHUB_SHA::7} kustomize: runs-on: ubuntu-latest