add missing dep to lint plugin (#1045)

mmason2-godaddy · kawikabader · web-flow · commit 87ea99835283 · 2025-03-06T09:47:27.000-08:00
* add missing dep to lint plugin

* fix type issue

* type issue

* fix: types plugin exports

* fix: rearrange type deps

* changeset

---------

Co-authored-by: Kawika Bader &lt;ekbader@gmail.com&gt;
diff --git a/.changeset/odd-parrots-kiss.md b/.changeset/odd-parrots-kiss.md
@@ -0,0 +1,15 @@
+---
+"@gasket/plugin-dynamic-plugins": patch
+"@gasket/plugin-service-worker": patch
+"@gasket/plugin-https-proxy": patch
+"@gasket/plugin-middleware": patch
+"@gasket/plugin-metadata": patch
+"@gasket/plugin-analyze": patch
+"@gasket/plugin-command": patch
+"@gasket/plugin-swagger": patch
+"@gasket/plugin-https": patch
+"@gasket/plugin-mocha": patch
+"@gasket/plugin-lint": patch
+---
+
+Add missing dep to lint plugin, adjust TS type exports
diff --git a/packages/gasket-plugin-analyze/package.json b/packages/gasket-plugin-analyze/package.json
@@ -36,12 +36,12 @@
   },
   "homepage": "https://github.com/godaddy/gasket/tree/main/packages/gasket-plugin-analyze",
   "dependencies": {
-    "@types/webpack-bundle-analyzer": "^4.7.0",
     "deepmerge": "^4.3.1",
     "webpack-bundle-analyzer": "^4.10.2"
   },
   "devDependencies": {
     "@gasket/core": "workspace:^",
+    "@types/webpack-bundle-analyzer": "^4.7.0",
     "@gasket/plugin-metadata": "workspace:^",
     "@gasket/plugin-webpack": "workspace:^",
     "@types/jest": "^29.5.14",
diff --git a/packages/gasket-plugin-command/lib/index.d.ts b/packages/gasket-plugin-command/lib/index.d.ts
@@ -39,7 +39,5 @@ declare module '@gasket/core' {
   }
 }
 
-declare module '@gasket/plugin-command' {
-}
 declare const plugin: Plugin;
 export default plugin;
diff --git a/packages/gasket-plugin-dynamic-plugins/lib/index.d.ts b/packages/gasket-plugin-dynamic-plugins/lib/index.d.ts
@@ -6,8 +6,5 @@ declare module '@gasket/core' {
   }
 }
 
-
-declare module '@gasket/plugin-dynamic-plugins' {
-  const plugin: Plugin;
-  export default plugin;
-}
+declare const plugin: Plugin;
+export default plugin;
diff --git a/packages/gasket-plugin-https-proxy/lib/index.d.ts b/packages/gasket-plugin-https-proxy/lib/index.d.ts
@@ -28,9 +28,5 @@ declare module '@gasket/core' {
   }
 }
 
-
-
-declare module '@gasket/plugin-https-proxy' {
-  const plugin: Plugin;
-  export default plugin;
-}
+declare const plugin: Plugin;
+export default plugin;
diff --git a/packages/gasket-plugin-https/package.json b/packages/gasket-plugin-https/package.json
@@ -38,7 +38,6 @@
   "homepage": "https://github.com/godaddy/gasket/tree/main/packages/gasket-plugin-https",
   "dependencies": {
     "@godaddy/terminus": "^4.12.1",
-    "@types/http-proxy": "^1.17.16",
     "create-servers": "^3.3.0",
     "diagnostics": "^2.0.2",
     "errs": "^0.3.2",
@@ -51,6 +50,7 @@
     "@gasket/plugin-metadata": "workspace:^",
     "@types/jest": "^29.5.14",
     "@types/node": "^20.17.19",
+    "@types/http-proxy": "^1.17.16",
     "create-gasket-app": "workspace:^",
     "cross-env": "^7.0.3",
     "eslint": "catalog:",
diff --git a/packages/gasket-plugin-lint/package.json b/packages/gasket-plugin-lint/package.json
@@ -45,6 +45,7 @@
     "@gasket/plugin-metadata": "workspace:^",
     "@types/jest": "^29.5.14",
     "@types/node": "^20.17.19",
+    "@typescript-eslint/parser": "^6.21.0",
     "create-gasket-app": "workspace:^",
     "cross-env": "^7.0.3",
     "eslint": "catalog:",
diff --git a/packages/gasket-plugin-metadata/lib/index.d.ts b/packages/gasket-plugin-metadata/lib/index.d.ts
@@ -85,6 +85,5 @@ declare module '@gasket/core' {
   }
 }
 
-// Export plugin separately
 declare const plugin: Plugin;
 export default plugin;
diff --git a/packages/gasket-plugin-middleware/lib/index.d.ts b/packages/gasket-plugin-middleware/lib/index.d.ts
@@ -27,7 +27,5 @@ declare module '@gasket/core' {
   }
 }
 
-declare module '@gasket/plugin-middleware' {
-  const plugin: Plugin;
-  export default plugin;
-}
+declare const plugin: Plugin;
+export default plugin;
diff --git a/packages/gasket-plugin-mocha/lib/index.d.ts b/packages/gasket-plugin-mocha/lib/index.d.ts
@@ -1,7 +1,4 @@
 import type { Plugin } from '@gasket/core';
 
-
-declare module '@gasket/plugin-mocha' {
-  const plugin: Plugin;
-  export default plugin;
-}
+declare const plugin: Plugin;
+export default plugin;
diff --git a/packages/gasket-plugin-service-worker/package.json b/packages/gasket-plugin-service-worker/package.json
@@ -36,8 +36,6 @@
   },
   "homepage": "https://github.com/godaddy/gasket/tree/main/packages/gasket-plugin-service-worker",
   "dependencies": {
-    "@types/lru-cache": "^5.1.1",
-    "@types/uglify-js": "^3.17.5",
     "deepmerge": "^4.3.1",
     "lru-cache": "^5.1.1",
     "mkdirp": "^1.0.4",
@@ -46,6 +44,8 @@
   },
   "devDependencies": {
     "@gasket/core": "workspace:^",
+    "@types/lru-cache": "^5.1.1",
+    "@types/uglify-js": "^3.17.5",
     "@gasket/plugin-command": "workspace:^",
     "@gasket/plugin-express": "workspace:^",
     "@gasket/plugin-fastify": "workspace:^",
diff --git a/packages/gasket-plugin-swagger/lib/index.d.ts b/packages/gasket-plugin-swagger/lib/index.d.ts
@@ -59,8 +59,5 @@ export function promptSwagger(
   prompt: CreatePrompt
 ): Promise<CreateContext>
 
-
-declare module '@gasket/plugin-swagger' {
-  const plugin: Plugin;
-  export default plugin;
-}
+declare const plugin: Plugin;
+export default plugin;
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,5 @@ declare module '@gasket/core' {`
`39`	`39`	`}`
`40`	`40`	`}`
`41`	`41`
`42`		`-declare module '@gasket/plugin-command' {`
`43`		`-}`
`44`	`42`	`declare const plugin: Plugin;`
`45`	`43`	`export default plugin;`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,5 @@ declare module '@gasket/core' {`
`6`	`6`	`}`
`7`	`7`	`}`
`8`	`8`
`9`		`-`
`10`		`-declare module '@gasket/plugin-dynamic-plugins' {`
`11`		`- const plugin: Plugin;`
`12`		`- export default plugin;`
`13`		`-}`
	`9`	`+declare const plugin: Plugin;`
	`10`	`+export default plugin;`
Original file line number	Diff line number	Diff line change
`@@ -28,9 +28,5 @@ declare module '@gasket/core' {`
`28`	`28`	`}`
`29`	`29`	`}`
`30`	`30`
`31`		`-`
`32`		`-`
`33`		`-declare module '@gasket/plugin-https-proxy' {`
`34`		`- const plugin: Plugin;`
`35`		`- export default plugin;`
`36`		`-}`
	`31`	`+declare const plugin: Plugin;`
	`32`	`+export default plugin;`
Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,5 @@ declare module '@gasket/core' {`
`85`	`85`	`}`
`86`	`86`	`}`
`87`	`87`
`88`		`-// Export plugin separately`
`89`	`88`	`declare const plugin: Plugin;`
`90`	`89`	`export default plugin;`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,5 @@ declare module '@gasket/core' {`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`
`30`		`-declare module '@gasket/plugin-middleware' {`
`31`		`- const plugin: Plugin;`
`32`		`- export default plugin;`
`33`		`-}`
	`30`	`+declare const plugin: Plugin;`
	`31`	`+export default plugin;`