Issues with the new default editor theme

[braids]

Tested versions

Commit 8afb2e5

System information

All applicable builds for commit 8afb2e5

Issue description

Issue Description:

Commit 8afb2e5 was merged in today to change the default theme to a new theme that had only been discussed for a month among a limited number of members of the Godot GitHub contributors. This theme lacks many design elements that were functional in Classic Godot Theme and have been promised to be addressed. However, these issues were raised early on in the PR and were still not addressed.

Additionally, this is a large change to the default environment of Godot that was taken with little feedback and no proposals. When asked in PR #111118 just after the PR was created where this change was discussed, the question was left with no response. Changing the default environment theme (which would provide the baseline for how future themes are designed) should have more input than a month discussion of a limited number of contributors.

Specific Issues with New Theme:

Scene Tree no longer has hierarchy lines in the new Default Godot Theme

Docks no longer have a darker inner BG that visually separates contents from the dock border.
Specific Examples:

• Darker Scene Tree BG no longer exists.
• Debugger BG behind text no longer appears.
• Dropdown elements in lists are indistinguishable from other elements/BG (Object Inspector, Input Map, Create dialog, TileSet editor)

Nodes in Node Editor blend into the background.

No discussion/proposal before the theme was decided as the new Default Godot Theme.

Proposed Resolution/Action:

1. Revert PR Add a new editor theme #111118 (Commit 8afb2e5) until a proper community discussion on a new default theme can be had, including multiple proposals for a new theme and not one selected for nebulous reasons.

2. Set the new default theme as an optional theme, and keep the current "Classic" theme as the default theme.

Steps to reproduce

Read PR #111118 .

Minimal reproduction project (MRP)

Read PR #111118 .

[clayjohn]

Please provide direct feedback about what you would like to see changed. In other words, explain what in particular is broken in the new theme and what you expect it to look like instead.

This is a space to report bugs not a place to complain in general. So please keep your bug reports actionable and to the point.

[braids]

@clayjohn Apologies, I've added examples of changes that this has introduced as examples of issues. These link to issues that were raised in the PR a month ago that were left unchanged when the PR was merged a month later. I have also created this ticket on the insistence of @coppolaemilio who had recommended creating an Issue regarding this PR merge.

Additionally, my example for what it should look like is the Classic Godot Theme. This can be viewed by opening Godot 4.5 Stable.

[braids]

I've also changed the "Proposed Resolution" section to read "Proposed Resolution/Action" to address "So please keep your bug reports actionable", reverting this PR will address the issues I am raising.

[shakesoda]

leaving the style preset at classic with old (or close enough) base color for now would also be preferable imo if people are really intent on continuing cooking the new theme in-tree. at the very least put some of the background fills back in, the theme contrast option is largely ruined without them

[braids]

Agreed with @shakesoda, I would not have as much of an issue with adding this theme if it wasn't set as the new Default Theme. Making a theme the default option is radically different from adding it as another option, and there should be more consensus before setting a new, incomplete theme as the default theme.

[clayjohn]

Just a reminder, this isn't a general complaints thread. We want specific actionable feedback.

Describe precisely what you consider to be a bug. Explain why it's a bug and articulate what you think the behaviour should be.

Just simply saying you don't like it and want to go back to the old theme will result in nothing happening. The old theme is still an option in the editor settings. If you want to help improve the new theme, then be constructive

[braids]

Hi @clayjohn ,

I updated the description to have the specific examples that you requested in this comment. You can find them in the section "Specific Issues with New Theme". This was added shortly before I made this comment, so I can understand the new information being missed.

[braids]

@clayjohn ,

I have updated the section "Proposed Resolution/Action" to now contain two action points. I agree with another suggestion that adding this new theme as an additional theme and not the default would be acceptable, at least until the new theme no longer has issues with the layout as described in the section "Specific Issues with New Theme".

[clayjohn]

@braids I think you aren't understanding. Let me be very clear: we have no intention to revert the new theme. Instead, we will listen to feedback from users who are unhappy with it and implement changes to the new theme in response to that feedback.

If your only suggestion is "revert the new theme" then you are going to be ignored. The only way we would revert the new theme is if way more people disliked it than people who like it, and you can see from the original PR that 10x as many people prefer the new theme than people who dislike it.

Understanding that you have valid criticisms of the new theme, we would like to improve it. But if your only suggestion is "revert the PR or nothing" then unfortunately, we will do nothing.

[braids]

@clayjohn I'm sorry, I linked to several examples of this new theme being incomplete and affecting usability while being a default theme. These issues were also brought up and unaddressed in the PR. @coppolaemilio said to raise an issue, so I am. How is this not what @coppolaemilio was asking for?

[braids]

Additonally, you've hidden this comment for being off-topic, but it has a reasonable request to not set this theme as default until the bugs and other issues are worked out. Is that unreasonable?

[braids]

Also regarding "you can see from the original PR that 10x as many people prefer the new theme than people who dislike it", there is still no answer on how this theme was selected as a new default theme. Was there a GitHub proposal ticket that requested a new theme and selected this one?