Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure default page size #244

Open
Vad1mo opened this issue Nov 10, 2024 · 1 comment · May be fixed by #290
Open

Ability to configure default page size #244

Vad1mo opened this issue Nov 10, 2024 · 1 comment · May be fixed by #290
Labels
enhancement New feature or request

Comments

@Vad1mo
Copy link
Member

Vad1mo commented Nov 10, 2024

I would be beneficial to be able to configure the default page size for different harbor cli operations.

@Vad1mo Vad1mo added the enhancement New feature or request label Nov 10, 2024
@Roaster05
Copy link
Contributor

@Vad1mo To address this issue, we can introduce a global default page size setting for the Harbor CLI. Users can configure this via the CLI configuration file (config.yaml) or an environment variable (HARBOR_CLI_DEFAULT_PAGE_SIZE).

The logic would follow a priority hierarchy:

  1. Command Line Flag: If --page-size is explicitly provided, it takes precedence.
  2. Configuration Setting: Use the value from the config file or environment variable if no flag is set.
  3. Fallback: Default to the existing hardcoded value (X) if neither is configured.
    This approach maintains backward compatibility while providing flexibility for users to define their preferred page size across CLI operations

@bupd bupd linked a pull request Dec 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants