Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for trivy dbRepository and javaDBRepository #1857

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benji78
Copy link

@benji78 benji78 commented Nov 11, 2024

This adds support for custom trivy dbRepository and javaDBRepository which was made possible through SCANNER_TRIVY_DB_REPOSITORY and SCANNER_TRIVY_JAVA_DB_REPOSITORY environment variables added in goharbor/harbor-scanner-trivy/pull/3.

Closes #1821

@benji78 benji78 force-pushed the trivy-db-repository branch from 8d0b19c to e0582ef Compare November 11, 2024 16:59
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you point me to the upstream Trviy documentation?

I can't find anything related to SCANNER_TRIVY_DB_REPOSITORY in trivy.

@benji78
Copy link
Author

benji78 commented Nov 12, 2024

Here is the documentation for --db-repository and --java-db-repository. I added the environment variables in harbor-scanner-trivy through the mentioned pull request.

@benji78 benji78 marked this pull request as draft November 17, 2024 17:37
@benji78
Copy link
Author

benji78 commented Nov 17, 2024

I will add support for multiple database repositories and mark the pull request as ready along with goharbor/harbor-scanner-trivy#7 as soon as trivy has decided which repositories to put as default.

@MinerYang MinerYang self-assigned this Nov 18, 2024
@benji78 benji78 force-pushed the trivy-db-repository branch from 9513f87 to 9625b00 Compare November 18, 2024 10:05
@benji78 benji78 marked this pull request as ready for review November 20, 2024 17:41
Signed-off-by: Benjamin Bordes <benjaminbordes78@gmail.com>

# Conflicts:
#	README.md
Signed-off-by: Benjamin Bordes <benjaminbordes78@gmail.com>
@benji78 benji78 force-pushed the trivy-db-repository branch from 9625b00 to 7b460f1 Compare November 20, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Trivy's dbRepository and javaDbRepository configurable
3 participants