gopls/internal/lsp/source: eliminate AnalyzerErrorKind

It is less clear than simply inlining the type conversion.

Change-Id: Icdf32ac46797345fd6134dde725848839ad5d8de
Reviewed-on: https://go-review.googlesource.com/c/tools/+/545203
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>

Author: findleyr

gopls/internal/lsp/cache/errors.go

@@ -259,7 +259,7 @@ func decodeDiagnostics(data []byte) []*Diagnostic {
 			Severity:       gobDiag.Severity,
 			Code:           gobDiag.Code,
 			CodeHref:       gobDiag.CodeHref,
-			Source:         AnalyzerErrorKind(gobDiag.Source),
+			Source:         DiagnosticSource(gobDiag.Source),
 			Message:        gobDiag.Message,
 			Tags:           gobDiag.Tags,
 			Related:        srcRelated,
@@ -293,7 +293,7 @@ func toSourceDiagnostic(srcAnalyzer *settings.Analyzer, gobDiag *gobDiagnostic)
 		Severity: severity,
 		Code:     gobDiag.Code,
 		CodeHref: gobDiag.CodeHref,
-		Source:   AnalyzerErrorKind(gobDiag.Source),
+		Source:   DiagnosticSource(gobDiag.Source),
 		Message:  gobDiag.Message,
 		Related:  related,
 		Tags:     srcAnalyzer.Tag,

gopls/internal/lsp/cache/pkg.go

@@ -32,12 +32,13 @@ type (
 	Metadata    = metadata.Metadata
 
 	// Diagnostics.
-	Diagnostic   = source.Diagnostic
-	SuggestedFix = source.SuggestedFix
+	Diagnostic       = source.Diagnostic
+	SuggestedFix     = source.SuggestedFix
+	DiagnosticSource = source.DiagnosticSource
 
 	// Computed objects.
 	TidiedModule   = source.TidiedModule
-	ParsedGoFile   = source.ParsedGoFile
+	ParsedGoFile   = parsego.File
 	ParsedModule   = source.ParsedModule
 	ParsedWorkFile = source.ParsedWorkFile
 	Package_       = source.Package // renamed to avoid conflict
@@ -76,7 +77,6 @@ var (
 	NewFilterer                    = source.NewFilterer
 	BuildLink                      = source.BuildLink
 	CanFix                         = source.CanFix
-	AnalyzerErrorKind              = source.AnalyzerErrorKind
 )
 
 // A Package is the union of package metadata and type checking results.

gopls/internal/lsp/source/snapshot.go

@@ -450,7 +450,3 @@ const (
 	WorkFileError            DiagnosticSource = "go.work file"
 	ConsistencyInfo          DiagnosticSource = "consistency"
 )
-
-func AnalyzerErrorKind(name string) DiagnosticSource {
-	return DiagnosticSource(name)
-}