Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store package metadata somewhere #53

Open
goodmami opened this issue Nov 20, 2020 · 2 comments
Open

Store package metadata somewhere #53

goodmami opened this issue Nov 20, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@goodmami
Copy link
Owner

LMF Packages and Collections can have metadata files like README, LICENSE, and citation.bib, but these are not stored in the database. For downloaded files, they will persist in the cache, but the cache is not meant to be a permanent record. Putting big text blobs in the database doesn't seem ideal, either. I'm not sure we even want to store these locally

We could create another data subdirectory for these. Something like .wn_data/project_meta. This might contain package directories with everything but the resource files.

@goodmami goodmami added the enhancement New feature or request label Nov 20, 2020
@goodmami goodmami added this to the v0.5.0 milestone Dec 29, 2020
@goodmami goodmami removed this from the v0.5.0 milestone Jan 28, 2021
@goodmami
Copy link
Owner Author

goodmami commented Nov 5, 2021

The easiest solution here is probably to just put them in the database rather than doing something custom. If we're just creating a new table and not modifying an existing one, we can add it without forcing users to rebuild their databases, however they wouldn't have access to the metadata of lexicons inserted before the feature is added.

We could probably have a table for READMEs, one for LICENSEs, and another for citation.bibs. E.g.,

CREATE TABLE IF NOT EXISTS licenses (
    lexicon_rowid INTEGER NOT NULL REFERENCES lexicons(rowid) ON DELETE CASCADE,
    text TEXT
)

@goodmami goodmami added the good first issue Good for newcomers label Nov 5, 2021
@fcbond
Copy link
Collaborator

fcbond commented Nov 6, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants